Bug 184552 - net/netatalk3 now silently depends on libsunacl
net/netatalk3 now silently depends on libsunacl
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Joe Marcus Clarke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-06 23:10 UTC by Bradley T. Hughes
Modified: 2013-12-08 08:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1.16 KB, patch)
2013-12-06 23:10 UTC, Bradley T. Hughes
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bradley T. Hughes 2013-12-06 23:10:00 UTC
After net/netatalk3 was updated to 3.1.0, the configure script picks up libsunacl if it was previously installed, but the port itself isn't marked as being dependent on libsunacl.

Fix: See attached patch.

Patch attached with submission follows:
How-To-Repeat: 1. make -C /usr/ports/sysutils/libsunacl install
2. make -C /usr/ports/net/netatalk3 install
3. pkg delete libsunacl
4. service netatalk start

The service fails to start because it can't find the libsunacl shared libraries (which were just removed).
Comment 1 Edwin Groothuis freebsd_committer 2013-12-06 23:10:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marcus

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Joe Marcus Clarke freebsd_committer 2013-12-08 08:06:40 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 3 dfilter freebsd_committer 2013-12-08 08:06:42 UTC
Author: marcus
Date: Sun Dec  8 08:06:34 2013
New Revision: 335870
URL: http://svnweb.freebsd.org/changeset/ports/335870

Log:
  Add missing explicit dependency on libsunacl.
  
  PR:		184552
  Submitted by:	"Bradley T. Hughes" <bradleythughes@fastmail.fm>

Modified:
  head/net/netatalk3/Makefile

Modified: head/net/netatalk3/Makefile
==============================================================================
--- head/net/netatalk3/Makefile	Sun Dec  8 08:06:03 2013	(r335869)
+++ head/net/netatalk3/Makefile	Sun Dec  8 08:06:34 2013	(r335870)
@@ -3,6 +3,7 @@
 
 PORTNAME=	netatalk
 PORTVERSION=	3.1.0
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	net
 MASTER_SITES=	SF
@@ -36,7 +37,7 @@ CONFIGURE_ARGS+=	--enable-tcp-wrappers \
 			--with-libevent-header=${LOCALBASE}/include \
 			--with-libevent-lib=${LOCALBASE}/lib/event2
 
-OPTIONS_DEFINE=PAM KRB5 LDAP SENDFILE KERBEROS DTRACE DBUS MYSQL
+OPTIONS_DEFINE=PAM KRB5 LDAP SENDFILE KERBEROS DTRACE DBUS MYSQL ACL
 OPTIONS_DEFAULT=KERBEROS DBUS
 OPTIONS_RADIO=ZEROCONF
 OPTIONS_RADIO_ZEROCONF=AVAHI MDNSRESPONDER
@@ -47,6 +48,7 @@ KRB5_DESC=	Enable Kerberos V UAM
 DTRACE_DESC=	Enable DTrace support
 SENDFILE_DESC=	Enable Sendfile support
 MYSQL_DESC=	Enable MySQL CNID backend support
+ACL_DESCR=	Enable ACL support
 
 .include <bsd.port.options.mk>
 
@@ -126,6 +128,13 @@ USE_MYSQL=	yes
 CONFIGURE_ARGS+=--with-mysql-config=/nonexistent
 .endif
 
+.if ${PORT_OPTIONS:MACL}
+LIB_DEPENDS+=	sunacl:${PORTSDIR}/sysutils/libsunacl
+CONFIGURE_ARGS+=--with-acls
+.else
+CONFIGURE_ARGS+=--without-acls
+.endif
+
 .if ${OSVERSION} < 800031
 PLIST_SUB+=	ATFUNCS="@comment "
 .else
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"