Bug 184987 - Missing support for tty DISCARD/^O
Summary: Missing support for tty DISCARD/^O
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: Adrian Chadd
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-12-19 08:50 UTC by eivinde
Modified: 2018-05-23 10:26 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (869 bytes, patch)
2013-12-19 08:50 UTC, eivinde
no flags Details | Diff
Same patch tested and used on FreeBSD 10 (870 bytes, patch)
2014-07-06 14:21 UTC, eivinde
no flags Details | Diff
Version setting resid to 0 (900 bytes, patch)
2014-08-07 19:58 UTC, eivinde
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description eivinde 2013-12-19 08:50:00 UTC
In the tty rewrite going from 7 to 8 it seems that support for
DISCARD/^O was either dropped or forgotten.

Here's a diff that gives most of the old functionality,
except output is not automatically turned back on upon input.

Fix: Patch attached with submission follows:
How-To-Repeat: Have something generate output, ^O doesn't discard the output.
Comment 1 eivinde 2014-07-06 14:21:54 UTC
Created attachment 144460 [details]
Same patch tested and used on FreeBSD 10

Added same diff used/tested on FreeBSD 10.
Comment 2 Adrian Chadd freebsd_committer 2014-07-06 17:28:56 UTC
I'll take this.
Comment 3 Adrian Chadd freebsd_committer 2014-07-06 17:29:30 UTC
So does this implement the complete missing functionality? What else is missing?
Comment 4 eivinde 2014-07-10 06:29:54 UTC
(In reply to Adrian Chadd from comment #3)
> So does this implement the complete missing functionality? What else is
> missing?

Comparing with old FreeBSD, the only thing missing is automatic
switching output back on on any keypress, not just ^O.
Comment 5 eivinde 2014-08-07 19:58:38 UTC
Created attachment 145483 [details]
Version setting resid to 0

uio->resid should be set to 0 aswell, for proper return
value.
Comment 6 Eitan Adler freebsd_committer freebsd_triage 2018-05-23 10:26:59 UTC
batch change of PRs untouched in 2018 marked "in progress" back to open.