Bug 185154 - [maintainer] news/husky-base-devel (etc.): Update development version of husky ports
[maintainer] news/husky-base-devel (etc.): Update development version of husk...
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: John Marino
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-24 12:30 UTC by Oleg Sharoyko
Modified: 2014-08-05 06:59 UTC (History)
1 user (show)

See Also:


Attachments
/tmp/husky_ports.diff.xz (5.55 KB, text/plain)
2013-12-24 12:30 UTC, Oleg Sharoyko
no flags Details
Updates husky-devel to 1.9.20140519 (svn diff --ignore-properties) (55.97 KB, patch)
2014-08-03 09:53 UTC, Oleg Sharoyko
osharoiko: maintainer‑approval+
Details | Diff
make check-plist && make stage-qa (82.27 KB, text/plain)
2014-08-03 10:12 UTC, Oleg Sharoyko
no flags Details
husky-devel.20140804.diff - updates husky-devel to 1.9.20140519 (55.21 KB, patch)
2014-08-04 15:54 UTC, Oleg Sharoyko
no flags Details | Diff
poudriere log for husky-areafix-devel-1.9.20140519 (13.95 KB, text/plain)
2014-08-04 15:57 UTC, Oleg Sharoyko
no flags Details
poudriere log for husky-devel-1.9.20140519 (55.21 KB, patch)
2014-08-04 15:57 UTC, Oleg Sharoyko
no flags Details | Diff
poudriere log for husky-devel-1.9.20140519 (12.45 KB, text/x-log)
2014-08-04 15:58 UTC, Oleg Sharoyko
no flags Details
poudriere log for husky-fidoconf-devel-1.9.20140519 (23.74 KB, text/plain)
2014-08-04 15:58 UTC, Oleg Sharoyko
no flags Details
poudriere log for husky-hpt-devel-1.9.20140519 (18.56 KB, text/plain)
2014-08-04 15:59 UTC, Oleg Sharoyko
no flags Details
poudriere log for husky-htick-devel-1.9.20140519 (15.94 KB, text/x-log)
2014-08-04 16:00 UTC, Oleg Sharoyko
no flags Details
poudriere log for husky-huskylib-devel-1.9.20140519 (20.14 KB, text/plain)
2014-08-04 16:01 UTC, Oleg Sharoyko
no flags Details
poudriere log for husky-smapi-devel-1.9.20140519,1 (14.38 KB, text/plain)
2014-08-04 16:02 UTC, Oleg Sharoyko
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Sharoyko 2013-12-24 12:30:01 UTC
	Development verisons of husky ports are outdated. Patch attacked below
	will update and refactor those ports.

Fix: Deleted files/directories:
                husky-base-devel
                husky-base-devel/Makefile
                husky-base-devel/Makefile.inc
                husky-base-devel/distinfo
                husky-base-devel/files
                husky-base-devel/files/patch-huskymak.cfg
                husky-base-devel/pkg-descr
                husky-base-devel/pkg-install
                husky-base-devel/pkg-plist
                husky-fidoconf-devel/distinfo
                husky-fidoconf-devel/files
                husky-fidoconf-devel/files/patch-Makefile
                husky-fidoconf-devel/files/patch-doc::Makefile
                husky-fidoconf-devel/files/patch-makefile.inc
                husky-fidoconf-devel/files/patch-man::Makefile
                husky-fidoconf-devel/files/patch-man::linkedto.1
                husky-fidoconf-devel/files/patch-tparser.c
                husky-hpt-devel/distinfo
                husky-hpt-devel/files
                husky-hpt-devel/files/patch-doc::Makefile
                husky-hpt-devel/pkg-plist
                husky-htick-devel/distinfo
                husky-htick-devel/files
                husky-htick-devel/files/patch-doc::Makefile
                husky-smapi-devel/distinfo
                husky-smapi-devel/files
                husky-smapi-devel/files/patch-Makefile
                husky-smapi-devel/files/patch-makefile.inc1

        Added files/directories:
                husky-areafix-devel
                husky-areafix-devel/Makefile
                husky-areafix-devel/pkg-descr
                husky-areafix-devel/pkg-plist
                husky-devel
                husky-devel/Makefile
                husky-devel/Makefile.local
                husky-devel/distinfo
                husky-devel/files
                husky-devel/files/patch-areafix_Makefile
                husky-devel/files/patch-fidoconf_Makefile
                husky-devel/files/patch-fidoconf_doc_Makefile
                husky-devel/files/patch-fidoconf_makefile.inc
                husky-devel/files/patch-fidoconf_man_Makefile
                husky-devel/files/patch-fidoconf_man_linkedto.1
                husky-devel/files/patch-hpt_Makefile
                husky-devel/files/patch-htick_doc_Makefile
                husky-devel/files/patch-huskybse_huskymak.cfg
                husky-devel/files/patch-huskylib_Makefile
                husky-devel/files/patch-smapi_Makefile
                husky-devel/pkg-descr
                husky-huskylib-devel
                husky-huskylib-devel/Makefile
                husky-huskylib-devel/pkg-descr
                husky-huskylib-devel/pkg-plist
Comment 1 Edwin Groothuis freebsd_committer 2013-12-29 02:01:14 UTC
Class Changed
From-To: maintainer-update->change-request

Fix category (submitter is not maintainer) (via the GNATS Auto Assign 
Tool)
Comment 2 Edwin Groothuis freebsd_committer 2013-12-29 02:01:15 UTC
Maintainer of news/husky-base-devel,

Please note that PR ports/185154 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/185154

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer 2013-12-29 02:01:16 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 os 2013-12-29 10:10:47 UTC
Ah, I didn't realize I've sent it from different address. This is my
fact my patch and so I approve it.

On 29 December 2013 02:01, Edwin Groothuis <edwin@freebsd.org> wrote:

> Maintainer of news/husky-base-devel,
>
> Please note that PR ports/185154 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/185154
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org



-- 
Oleg
Comment 5 Mark Linimon freebsd_committer 2013-12-30 03:41:50 UTC
State Changed
From-To: feedback->open

Submitter is maintainer from another address.
Comment 6 Oleg Sharoyko 2014-06-11 19:54:50 UTC
Hi,

Is there anything else that I can do to make this moving?

Cheers,
Oleg.
Comment 7 John Marino freebsd_committer 2014-07-26 12:41:54 UTC
It might help to re-upload the attachment as plain text - compression only hinders potential commiters from evaluating it.
Comment 8 John Marino freebsd_committer 2014-07-28 21:06:23 UTC
I think the patch is corrupt, I can't open it.

I wanted to check if the ports are staged.  If not, they can't be updated anyway.

Oleg, can you add a new attachment and do NOT compress it this time?  Bugzilla has much higher limit for file sizes so that shouldn't be an issue.
Comment 9 Oleg Sharoyko 2014-07-29 16:13:54 UTC
Yeah, it's definitely broken and I'm afraid it had not staging support. I'll work on a new patch. Are you ok with me uploading a new patch to this bug or would you prefer me opening a new one?
Comment 10 John Marino freebsd_committer 2014-07-29 16:24:18 UTC
Not only am I "ok" with that, I prefer that you keep using this PR.  Once the new patch is uploaded, I'll add "[stage]" to the title and that will give it a lot more visibility.

Ideally you'll provide a single file than "svn patch" can apply to all the ports at once.  And don't compress it, I think there's a 1Mb limit on attachments on bugzilla now (per attachment).  If you get close to that, split it into multiple attachments I guess, but it's helpful use use the visual diff feature that bugzilla has.
Comment 11 Oleg Sharoyko 2014-08-03 09:53:58 UTC
Created attachment 145294 [details]
Updates husky-devel to 1.9.20140519 (svn diff --ignore-properties)

Please take a look at the updated patch (it includes support for staging).

Files and directories that were removed:
        news/husky-base-devel/Makefile
        news/husky-base-devel/Makefile.inc
        news/husky-base-devel/distinfo
        news/husky-base-devel/files/patch-huskymak.cfg
        news/husky-base-devel/files
        news/husky-base-devel/pkg-descr
        news/husky-base-devel/pkg-install
        news/husky-base-devel/pkg-plist
        news/husky-base-devel
        news/husky-fidoconf-devel/distinfo
        news/husky-fidoconf-devel/files/patch-Makefile
        news/husky-fidoconf-devel/files/patch-doc::Makefile
        news/husky-fidoconf-devel/files/patch-makefile.inc
        news/husky-fidoconf-devel/files/patch-man::Makefile
        news/husky-fidoconf-devel/files/patch-man::linkedto.1
        news/husky-fidoconf-devel/files/patch-tparser.c
        news/husky-fidoconf-devel/files
        news/husky-hpt-devel/distinfo
        news/husky-hpt-devel/files/patch-doc::Makefile
        news/husky-hpt-devel/files
        news/husky-htick-devel/distinfo
        news/husky-htick-devel/files/patch-doc::Makefile
        news/husky-htick-devel/files
        news/husky-smapi-devel/distinfo
        news/husky-smapi-devel/files/patch-Makefile
        news/husky-smapi-devel/files/patch-makefile.inc1
        news/husky-smapi-devel/files
Comment 12 John Marino freebsd_committer 2014-08-03 09:57:42 UTC
what kind of QA has been done on them?

ideally: Poudriere logs
2nd tier: redports or tinderbox logs
3rd tier: "make check-plist" followed by "make stage-qa" output
Comment 13 Oleg Sharoyko 2014-08-03 10:12:02 UTC
Created attachment 145295 [details]
make check-plist && make stage-qa

> what kind of QA has been done on them?
> ideally: Poudriere logs
> 2nd tier: redports or tinderbox logs
> 3rd tier: "make check-plist" followed by "make stage-qa" output

make check-plist && make stage-qa looks clean to me (attached). I'll work on producing poudriere logs.
Comment 14 Oleg Sharoyko 2014-08-04 15:54:04 UTC
Created attachment 145348 [details]
husky-devel.20140804.diff - updates husky-devel to 1.9.20140519
Comment 15 Oleg Sharoyko 2014-08-04 15:57:00 UTC
Created attachment 145349 [details]
poudriere log for husky-areafix-devel-1.9.20140519
Comment 16 Oleg Sharoyko 2014-08-04 15:57:35 UTC
Created attachment 145350 [details]
poudriere log for husky-devel-1.9.20140519
Comment 17 Oleg Sharoyko 2014-08-04 15:58:10 UTC
Created attachment 145351 [details]
poudriere log for husky-devel-1.9.20140519
Comment 18 Oleg Sharoyko 2014-08-04 15:58:46 UTC
Created attachment 145352 [details]
poudriere log for husky-fidoconf-devel-1.9.20140519
Comment 19 Oleg Sharoyko 2014-08-04 15:59:31 UTC
Created attachment 145353 [details]
poudriere log for husky-hpt-devel-1.9.20140519
Comment 20 Oleg Sharoyko 2014-08-04 16:00:35 UTC
Created attachment 145354 [details]
poudriere log for husky-htick-devel-1.9.20140519
Comment 21 Oleg Sharoyko 2014-08-04 16:01:24 UTC
Created attachment 145355 [details]
poudriere log for husky-huskylib-devel-1.9.20140519
Comment 22 Oleg Sharoyko 2014-08-04 16:02:10 UTC
Created attachment 145356 [details]
poudriere log for husky-smapi-devel-1.9.20140519,1
Comment 23 Oleg Sharoyko 2014-08-04 16:08:09 UTC
I've attached poudriere logs and a slightly updated version of the patch (only has perl5 dependency in one port which actially needs it and applies cleanly now - turns out I shouldn't have tried to be too smart with svn rename).

Poudriere wasn't friendly to me - it was making read-only nullfs mounts and then was trying to remove files from them which obviously didn't work. So I had to umount them manually after every run. Also I had to run it two times first to build dependencies and second time to actually test a port. Do you know if these are known issues or am I doing something wrong with it?

I don't think it has affected the tests in any way as only the "cleaning after the work" phase was affected but let me know if you see anything strange in the logs.
Comment 24 John Marino freebsd_committer 2014-08-04 16:20:05 UTC
So I randomly picked the 16:02 log, and see this inside:

===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
====>> Checking for staging violations... done
=======================<phase: package        >============================


That's good.  Do all the ports have the same level of success?
... saves me from looking through each one. :)
Comment 25 Oleg Sharoyko 2014-08-04 18:27:02 UTC
(In reply to John Marino from comment #24)

> So I randomly picked the 16:02 log, and see this inside:
[skip]
> That's good.  Do all the ports have the same level of success?
> ... saves me from looking through each one. :)

All are looking good:

% grep -A 9 'Running Q/A tests' husky*-devel-1.9.20140519* 
husky-areafix-devel-1.9.20140519.log:====> Running Q/A tests (stage-qa)
husky-areafix-devel-1.9.20140519.log-====> Checking for pkg-plist issues (check-plist)
husky-areafix-devel-1.9.20140519.log-===> Parsing plist
husky-areafix-devel-1.9.20140519.log-===> Checking for items in STAGEDIR missing from pkg-plist
husky-areafix-devel-1.9.20140519.log-===> Checking for directories owned by MTREEs
husky-areafix-devel-1.9.20140519.log-===> Checking for directories handled by dependencies
husky-areafix-devel-1.9.20140519.log-===> Checking for items in pkg-plist which are not in STAGEDIR
husky-areafix-devel-1.9.20140519.log-===> No pkg-plist issues found (check-plist)
husky-areafix-devel-1.9.20140519.log-====>> Checking for staging violations... done
husky-areafix-devel-1.9.20140519.log-=======================<phase: package        >============================
--
husky-devel-1.9.20140519.log:====> Running Q/A tests (stage-qa)
husky-devel-1.9.20140519.log-====> Checking for pkg-plist issues (check-plist)
husky-devel-1.9.20140519.log-===> Parsing plist
husky-devel-1.9.20140519.log-===> Checking for items in STAGEDIR missing from pkg-plist
husky-devel-1.9.20140519.log-===> Checking for directories owned by MTREEs
husky-devel-1.9.20140519.log-===> Checking for directories handled by dependencies
husky-devel-1.9.20140519.log-===> Checking for items in pkg-plist which are not in STAGEDIR
husky-devel-1.9.20140519.log-===> No pkg-plist issues found (check-plist)
husky-devel-1.9.20140519.log-====>> Checking for staging violations... done
husky-devel-1.9.20140519.log-=======================<phase: package        >============================
--
husky-fidoconf-devel-1.9.20140519.log:====> Running Q/A tests (stage-qa)
husky-fidoconf-devel-1.9.20140519.log-====> Checking for pkg-plist issues (check-plist)
husky-fidoconf-devel-1.9.20140519.log-===> Parsing plist
husky-fidoconf-devel-1.9.20140519.log-===> Checking for items in STAGEDIR missing from pkg-plist
husky-fidoconf-devel-1.9.20140519.log-===> Checking for directories owned by MTREEs
husky-fidoconf-devel-1.9.20140519.log-===> Checking for directories handled by dependencies
husky-fidoconf-devel-1.9.20140519.log-===> Checking for items in pkg-plist which are not in STAGEDIR
husky-fidoconf-devel-1.9.20140519.log-===> No pkg-plist issues found (check-plist)
husky-fidoconf-devel-1.9.20140519.log-====>> Checking for staging violations... done
husky-fidoconf-devel-1.9.20140519.log-=======================<phase: package        >============================
--
husky-hpt-devel-1.9.20140519.log:====> Running Q/A tests (stage-qa)
husky-hpt-devel-1.9.20140519.log-====> Checking for pkg-plist issues (check-plist)
husky-hpt-devel-1.9.20140519.log-===> Parsing plist
husky-hpt-devel-1.9.20140519.log-===> Checking for items in STAGEDIR missing from pkg-plist
husky-hpt-devel-1.9.20140519.log-===> Checking for directories owned by MTREEs
husky-hpt-devel-1.9.20140519.log-===> Checking for directories handled by dependencies
husky-hpt-devel-1.9.20140519.log-===> Checking for items in pkg-plist which are not in STAGEDIR
husky-hpt-devel-1.9.20140519.log-===> No pkg-plist issues found (check-plist)
husky-hpt-devel-1.9.20140519.log-====>> Checking for staging violations... done
husky-hpt-devel-1.9.20140519.log-=======================<phase: package        >============================
--
husky-htick-devel-1.9.20140519.log:====> Running Q/A tests (stage-qa)
husky-htick-devel-1.9.20140519.log-====> Checking for pkg-plist issues (check-plist)
husky-htick-devel-1.9.20140519.log-===> Parsing plist
husky-htick-devel-1.9.20140519.log-===> Checking for items in STAGEDIR missing from pkg-plist
husky-htick-devel-1.9.20140519.log-===> Checking for directories owned by MTREEs
husky-htick-devel-1.9.20140519.log-===> Checking for directories handled by dependencies
husky-htick-devel-1.9.20140519.log-===> Checking for items in pkg-plist which are not in STAGEDIR
husky-htick-devel-1.9.20140519.log-===> No pkg-plist issues found (check-plist)
husky-htick-devel-1.9.20140519.log-====>> Checking for staging violations... done
husky-htick-devel-1.9.20140519.log-=======================<phase: package        >============================
--
husky-huskylib-devel-1.9.20140519.log:====> Running Q/A tests (stage-qa)
husky-huskylib-devel-1.9.20140519.log-====> Checking for pkg-plist issues (check-plist)
husky-huskylib-devel-1.9.20140519.log-===> Parsing plist
husky-huskylib-devel-1.9.20140519.log-===> Checking for items in STAGEDIR missing from pkg-plist
husky-huskylib-devel-1.9.20140519.log-===> Checking for directories owned by MTREEs
husky-huskylib-devel-1.9.20140519.log-===> Checking for directories handled by dependencies
husky-huskylib-devel-1.9.20140519.log-===> Checking for items in pkg-plist which are not in STAGEDIR
husky-huskylib-devel-1.9.20140519.log-===> No pkg-plist issues found (check-plist)
husky-huskylib-devel-1.9.20140519.log-====>> Checking for staging violations... done
husky-huskylib-devel-1.9.20140519.log-=======================<phase: package        >============================
--
husky-smapi-devel-1.9.20140519,1.log:====> Running Q/A tests (stage-qa)
husky-smapi-devel-1.9.20140519,1.log-====> Checking for pkg-plist issues (check-plist)
husky-smapi-devel-1.9.20140519,1.log-===> Parsing plist
husky-smapi-devel-1.9.20140519,1.log-===> Checking for items in STAGEDIR missing from pkg-plist
husky-smapi-devel-1.9.20140519,1.log-===> Checking for directories owned by MTREEs
husky-smapi-devel-1.9.20140519,1.log-===> Checking for directories handled by dependencies
husky-smapi-devel-1.9.20140519,1.log-===> Checking for items in pkg-plist which are not in STAGEDIR
husky-smapi-devel-1.9.20140519,1.log-===> No pkg-plist issues found (check-plist)
husky-smapi-devel-1.9.20140519,1.log-====>> Checking for staging violations... done
husky-smapi-devel-1.9.20140519,1.log-=======================<phase: package        >============================
Comment 26 John Marino freebsd_committer 2014-08-04 18:49:52 UTC
I guess you've waited long enough... :)
Comment 27 commit-hook freebsd_committer 2014-08-05 06:55:29 UTC
A commit references this bug:

Author: marino
Date: Tue Aug  5 06:54:47 UTC 2014
New revision: 364078
URL: http://svnweb.freebsd.org/changeset/ports/364078

Log:
  Update development versions of husky ports

  The husky-base-devel port was removed, and three ports were added in this
  mass update:
    - husky-areafix-devel
    - husky-devel
    - husky-huskylib-devel

  PR:		185154
  Submitted by:	maintainer (Oleg Sharoyko)

Changes:
  head/MOVED
  head/news/Makefile
  head/news/husky-areafix-devel/
  head/news/husky-areafix-devel/Makefile
  head/news/husky-areafix-devel/pkg-descr
  head/news/husky-areafix-devel/pkg-plist
  head/news/husky-base-devel/
  head/news/husky-devel/
  head/news/husky-devel/Makefile
  head/news/husky-devel/Makefile.local
  head/news/husky-devel/distinfo
  head/news/husky-devel/files/
  head/news/husky-devel/files/patch-areafix_Makefile
  head/news/husky-devel/files/patch-fidoconf_Makefile
  head/news/husky-devel/files/patch-fidoconf_doc_Makefile
  head/news/husky-devel/files/patch-fidoconf_makefile.inc
  head/news/husky-devel/files/patch-fidoconf_man_Makefile
  head/news/husky-devel/files/patch-fidoconf_man_linkedto.1
  head/news/husky-devel/files/patch-hpt_Makefile
  head/news/husky-devel/files/patch-hpt_doc_Makefile
  head/news/husky-devel/files/patch-htick_Makefile
  head/news/husky-devel/files/patch-htick_doc_Makefile
  head/news/husky-devel/files/patch-huskybse_huskymak.cfg
  head/news/husky-devel/files/patch-huskylib_Makefile
  head/news/husky-devel/files/patch-smapi_Makefile
  head/news/husky-devel/pkg-descr
  head/news/husky-fidoconf-devel/Makefile
  head/news/husky-fidoconf-devel/distinfo
  head/news/husky-fidoconf-devel/files/
  head/news/husky-fidoconf-devel/pkg-plist
  head/news/husky-hpt-devel/Makefile
  head/news/husky-hpt-devel/distinfo
  head/news/husky-hpt-devel/files/
  head/news/husky-hpt-devel/pkg-plist
  head/news/husky-htick-devel/Makefile
  head/news/husky-htick-devel/distinfo
  head/news/husky-htick-devel/files/
  head/news/husky-htick-devel/pkg-plist
  head/news/husky-huskylib-devel/
  head/news/husky-huskylib-devel/Makefile
  head/news/husky-huskylib-devel/pkg-descr
  head/news/husky-huskylib-devel/pkg-plist
  head/news/husky-smapi-devel/Makefile
  head/news/husky-smapi-devel/distinfo
  head/news/husky-smapi-devel/files/
  head/news/husky-smapi-devel/pkg-plist
Comment 28 John Marino freebsd_committer 2014-08-05 06:59:32 UTC
Thanks!