Bug 185289 - www/newsbeuter stage support, nls and podbeuter option
Summary: www/newsbeuter stage support, nls and podbeuter option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tilman Keskinoz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-30 12:00 UTC by Zsolt Udvari
Modified: 2013-12-30 16:00 UTC (History)
1 user (show)

See Also:


Attachments
newsbeuter-stage-nls.patch (2.81 KB, patch)
2013-12-30 12:00 UTC, Zsolt Udvari
no flags Details | Diff
newsbeuter.diff (2.01 KB, patch)
2013-12-30 14:24 UTC, Zsolt Udvari
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Udvari 2013-12-30 12:00:00 UTC
www/newsbeuter support STAGEDIR (its Makefile uses DESTDIR), can build package as regular user (non-root).
Introduced NLS option support and PODCASTER option (install or not podbeuter-releated stuffs).
Comment 1 Edwin Groothuis freebsd_committer 2013-12-30 12:00:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->arved

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Tilman Keskinoz freebsd_committer 2013-12-30 13:47:56 UTC
Disabling NLS option results in:
"msgfmt: Command not found" buildfailure

Because of this failure i can not commit it, please provide an updated
patch.

Nice to have:
* Please run portlint before submitting a patch
* Please don't change the default installation (e.g. use OPTIONS_DEFAULT
= PODCAST)
Comment 3 Zsolt Udvari 2013-12-30 14:24:36 UTC
Sorry, this was my failure. I think because of newsbeuter's Makefile
isn't too easy to introduce NLS option into port.

I've ran portlint and applied suggested modifications too. I hope it's
perfect now.

Thanks for feedback and corrections!


2013/12/30 Tilman Keskinöz <arved@freebsd.org>:
> Disabling NLS option results in:
> "msgfmt: Command not found" buildfailure
>
> Because of this failure i can not commit it, please provide an updated
> patch.
>
> Nice to have:
> * Please run portlint before submitting a patch
> * Please don't change the default installation (e.g. use OPTIONS_DEFAULT
> = PODCAST)

>
Comment 4 dfilter service freebsd_committer 2013-12-30 15:54:11 UTC
Author: arved
Date: Mon Dec 30 15:53:58 2013
New Revision: 338124
URL: http://svnweb.freebsd.org/changeset/ports/338124

Log:
  * Support Stagedir
  * Add Option to disable Podcast client
  
  PR:		185289
  Submitted by:	 	Zsolt Udvari <udvzsolt@gmail.com>

Modified:
  head/www/newsbeuter/Makefile
  head/www/newsbeuter/pkg-descr
  head/www/newsbeuter/pkg-plist

Modified: head/www/newsbeuter/Makefile
==============================================================================
--- head/www/newsbeuter/Makefile	Mon Dec 30 15:49:37 2013	(r338123)
+++ head/www/newsbeuter/Makefile	Mon Dec 30 15:53:58 2013	(r338124)
@@ -10,12 +10,17 @@ MASTER_SITES=	http://newsbeuter.org/down
 MAINTAINER=	arved@FreeBSD.org
 COMMENT=	An RSS feed reader for the text console
 
-LIB_DEPENDS=	stfl.1:${PORTSDIR}/devel/stfl \
+LICENSE=	MIT
+LICENSE_FILE=	${WRKSRC}/LICENSE
+
+LIB_DEPENDS=	stfl:${PORTSDIR}/devel/stfl \
 		curl:${PORTSDIR}/ftp/curl \
 		libjson.so:${PORTSDIR}/devel/json-c
 
-LICENSE=	MIT
-LICENSE_FILE=	${WRKSRC}/LICENSE
+OPTIONS_DEFINE= PODCAST
+PODCAST_DESC=	Podcast client (podbeuter)
+
+OPTIONS_DEFAULT= PODCAST
 
 USES=		gettext iconv ncurses gmake pkgconfig perl5
 USE_PERL5=	build
@@ -23,9 +28,13 @@ USE_SQLITE=	yes
 USE_GNOME=	libxml2
 USE_GCC=	any
 
-MAN1=	newsbeuter.1 podbeuter.1
+.include  <bsd.port.options.mk>
 
-NO_STAGE=	yes
+.if ${PORT_OPTIONS:MPODCAST}
+PLIST_SUB+=	PODCAST=""
+.else
+PLIST_SUB+=	PODCAST="@comment "
+.endif
 
 post-patch:
 	${REINPLACE_CMD} -e "s,share/man,man,; \

Modified: head/www/newsbeuter/pkg-descr
==============================================================================
--- head/www/newsbeuter/pkg-descr	Mon Dec 30 15:49:37 2013	(r338123)
+++ head/www/newsbeuter/pkg-descr	Mon Dec 30 15:53:58 2013	(r338124)
@@ -1,4 +1,4 @@
 Newsbeuter is an RSS feed reader for the text console.
 
 Author:	Andreas Krennmair
-WWW:	http://newsbeuter.org/
+WWW: http://newsbeuter.org/

Modified: head/www/newsbeuter/pkg-plist
==============================================================================
--- head/www/newsbeuter/pkg-plist	Mon Dec 30 15:49:37 2013	(r338123)
+++ head/www/newsbeuter/pkg-plist	Mon Dec 30 15:53:58 2013	(r338124)
@@ -1,5 +1,5 @@
 bin/newsbeuter
-bin/podbeuter
+%%PODCAST%%bin/podbeuter
 share/locale/de/LC_MESSAGES/newsbeuter.mo
 share/locale/es/LC_MESSAGES/newsbeuter.mo
 share/locale/es_ES/LC_MESSAGES/newsbeuter.mo
@@ -19,5 +19,7 @@ share/locale/zh_TW/LC_MESSAGES/newsbeute
 share/doc/newsbeuter/docbook-xsl.css
 share/doc/newsbeuter/newsbeuter.html
 share/doc/newsbeuter/examples/config
+man/man1/newsbeuter.1.gz
+%%PODCAST%%man/man1/podbeuter.1.gz
 @dirrm share/doc/newsbeuter/examples
 @dirrm share/doc/newsbeuter
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Tilman Keskinoz freebsd_committer 2013-12-30 15:54:16 UTC
State Changed
From-To: open->closed

committed, thanks