Bug 185302 - sysutils/conky staging support, option helpers
Summary: sysutils/conky staging support, option helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-30 17:50 UTC by Zsolt Udvari
Modified: 2014-01-30 19:50 UTC (History)
1 user (show)

See Also:


Attachments
conky.diff (4.67 KB, patch)
2013-12-30 17:50 UTC, Zsolt Udvari
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Udvari 2013-12-30 17:50:00 UTC
sysutils/conky staging support and use option helpers.
Comment 1 Edwin Groothuis freebsd_committer 2013-12-30 17:50:07 UTC
Maintainer of sysutils/conky,

Please note that PR ports/185302 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/185302

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer 2013-12-30 17:50:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Pawel Pekala freebsd_committer 2014-01-30 18:14:48 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pawel

I'll take it.
Comment 4 dfilter service freebsd_committer 2014-01-30 19:45:25 UTC
Author: pawel
Date: Thu Jan 30 19:45:17 2014
New Revision: 341879
URL: http://svnweb.freebsd.org/changeset/ports/341879
QAT: https://qat.redports.org/buildarchive/r341879/

Log:
  - Add staging support and use option helpers [1]
  - Remove leading article from COMMENT
  - Convert USE_GMAKE to USES=gmake
  - Convert to new LIB_DEPENDS format
  - Remove tab character from WWW: line
  
  PR:		ports/185302 [1] (based on)
  Submitted by:	Zsolt Udvari <udvzsolt@gmail.com>
  Approved by:	maintainer timeout

Modified:
  head/sysutils/conky-awesome/Makefile
  head/sysutils/conky/Makefile
  head/sysutils/conky/pkg-descr

Modified: head/sysutils/conky-awesome/Makefile
==============================================================================
--- head/sysutils/conky-awesome/Makefile	Thu Jan 30 19:40:44 2014	(r341878)
+++ head/sysutils/conky-awesome/Makefile	Thu Jan 30 19:45:17 2014	(r341879)
@@ -4,7 +4,7 @@
 PKGNAMESUFFIX=	-awesome
 
 MAINTAINER=	ntarmos@ceid.upatras.gr
-COMMENT=	An advanced, highly configurable system monitor (configured for x11-wm/awesome)
+COMMENT=	Advanced, highly configurable system monitor (configured for x11-wm/awesome)
 
 MASTERDIR=	${.CURDIR}/../conky
 DESCR=		${.CURDIR}/pkg-descr
@@ -15,5 +15,4 @@ OPTIONS_EXCLUDE=	X11
 OPTIONS_GROUP=
 OPTIONS_DEFAULT=
 
-NO_STAGE=	yes
 .include "${MASTERDIR}/Makefile"

Modified: head/sysutils/conky/Makefile
==============================================================================
--- head/sysutils/conky/Makefile	Thu Jan 30 19:40:44 2014	(r341878)
+++ head/sysutils/conky/Makefile	Thu Jan 30 19:45:17 2014	(r341879)
@@ -8,15 +8,14 @@ CATEGORIES=	sysutils
 MASTER_SITES=	SF
 
 MAINTAINER=	ntarmos@ceid.upatras.gr
-COMMENT=	An advanced, highly configurable system monitor for X
+COMMENT=	Advanced, highly configurable system monitor for X11
 
 CONFLICTS?=	conky-awesome-[0-9]*
 SLAVEDIRS=	sysutils/conky-awesome
 
-USES=		pkgconfig iconv
+USES=		gmake iconv pkgconfig
 USE_BZIP2=	yes
 GNU_CONFIGURE=	yes
-USE_GMAKE=	yes
 CONFIGURE_ARGS+=	--disable-portmon \
 			--disable-hddtemp \
 			--disable-alsa \
@@ -25,8 +24,7 @@ CONFIGURE_ARGS+=	--disable-portmon \
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 
-MAN1=		conky.1
-PLIST_FILES=	bin/conky
+PLIST_FILES=	bin/conky man/man1/conky.1.gz
 PORTEXAMPLES=	conkyrc.sample
 PORTDOCS=	README AUTHORS ChangeLog TODO NEWS \
 		docs.html variables.html config_settings.html
@@ -38,22 +36,61 @@ OPTIONS_GROUP?=	X11
 OPTIONS_GROUP_X11=	ARGB DOUBLE_BUFFER IMLIB2 XFT LUA_CAIRO LUA_IMLIB2
 OPTIONS_DEFAULT?=	X11 ARGB DOUBLE_BUFFER
 
-ARGB_DESC=		Use an ARGB visual to draw on X11
 APCUPSD_DESC=		Monitor APCUPSD
+APCUPSD_CONFIGURE_ENABLE=apcupsd
+
+ARGB_DESC=		Use an ARGB visual to draw on X11
+ARGB_CONFIGURE_ENABLE=	argb
+
 AUDACIOUS_DESC=		Control Audacious sound player
+AUDACIOUS_CONFIGURE_ENABLE=audacious
+AUDACIOUS_LIB_DEPENDS=	libaudclient.so:${PORTSDIR}/multimedia/audacious
+
 DOUBLE_BUFFER_DESC=	Enable X11 double buffering
+DOUBLE_BUFFER_CONFIGURE_ENABLE=double-buffer
+
 INOTIFY_DESC=		Monitor file changes via Inotify
+INOTIFY_CONFIGURE_ENABLE=inotify
+INOTIFY_LIB_DEPENDS=	libinotify.so:${PORTSDIR}/devel/libinotify
+
 LUA_CAIRO_DESC=		Lua-Cairo binding
+LUA_CAIRO_CONFIGURE_ENABLE=lua-cairo
+LUA_CAIRO_LIB_DEPENDS=	libcairo.so:${PORTSDIR}/graphics/cairo
+
 LUA_IMLIB2_DESC=	Lua-Imlib2 binding
+LUA_IMLIB2_CONFIGURE_ENABLE=lua-imlib2
+
 METAR_DESC=		Display METAR weather reports
+METAR_CONFIGURE_ENABLE=	weather-metar
+METAR_LIB_DEPENDS=	libcurl.so:${PORTSDIR}/ftp/curl
+
 MOC_DESC=		Control MOC (Music On Console)
+MOC_CONFIGURE_ENABLE=	moc
+
 MPD_DESC=		Control MPD (Music Player Daemon)
+MPD_CONFIGURE_ENABLE=	mpd
+
 NCURSES_DESC=		Use ncurses to draw on terminals
+NCURSES_CONFIGURE_ENABLE=ncurses
+
 RSS_DESC=		Display RSS feeds
+RSS_CONFIGURE_ENABLE=	rss
+RSS_USE=		GNOME=glib20
+RSS_LIB_DEPENDS=	libcurl.so:${PORTSDIR}/ftp/curl \
+			libxml2.so:${PORTSDIR}/textproc/libxml2
+
+XFT_CONFIGURE_ENABLE=	xft
+XFT_LIB_DEPENDS=	libXft.so:${PORTSDIR}/x11-fonts/libXft
+
 XMMS2_DESC=		Control XMMS2 media player
+XMMS2_CONFIGURE_ENABLE=	xmms2
+XMMS2_LIB_DEPENDS=	libxmmsclient.so:${PORTSDIR}/audio/xmms2
+
 XOAP_DESC=		Display XOAP weather reports
+XOAP_CONFIGURE_ENABLE=	weather-xoap
+XOAP_LIB_DEPENDS=	libcurl.so:${PORTSDIR}/ftp/curl \
+			libxml2.so:${PORTSDIR}/textproc/libxml2
 
-NO_STAGE=	yes
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MARGB} || ${PORT_OPTIONS:MDOUBLE_BUFFER} || ${PORT_OPTIONS:MIMLIB2} || ${PORT_OPTIONS:MLUA_CAIRO} || ${PORT_OPTIONS:MLUA_IMLIB2} || ${PORT_OPTIONS:MXFT} || ${PORT_OPTIONS:MX11}
@@ -65,62 +102,13 @@ CONFIGURE_ARGS+=	--disable-x11 --disable
 EXAMPLE_CONF_FILE=	${WRKSRC}/data/conky_no_x11.conf
 .endif
 
-.if ${PORT_OPTIONS:MAPCUPSD}
-CONFIGURE_ARGS+=	--enable-apcupsd
-.else
-CONFIGURE_ARGS+=	--disable-apcupsd
-.endif
-
-.if ${PORT_OPTIONS:MARGB}
-CONFIGURE_ARGS+=	--enable-argb
-.else
-CONFIGURE_ARGS+=	--disable-argb
-.endif
-
-.if ${PORT_OPTIONS:MAUDACIOUS}
-LIB_DEPENDS+=		audclient:${PORTSDIR}/multimedia/audacious
-CONFIGURE_ARGS+=	--enable-audacious
-.else
-CONFIGURE_ARGS+=	--disable-audacious
-.endif
-
-.if ${PORT_OPTIONS:MDOUBLE_BUFFER}
-CONFIGURE_ARGS+=	--enable-double-buffer
-.else
-CONFIGURE_ARGS+=	--disable-double-buffer
-.endif
-
 .if ${PORT_OPTIONS:MIMLIB2} || ${PORT_OPTIONS:MLUA_IMLIB2}
-LIB_DEPENDS+=		Imlib2:${PORTSDIR}/graphics/imlib2
+LIB_DEPENDS+=		libImlib2.so:${PORTSDIR}/graphics/imlib2
 CONFIGURE_ARGS+=	--enable-imlib2
 .else
 CONFIGURE_ARGS+=	--disable-imlib2
 .endif
 
-.if ${PORT_OPTIONS:MINOTIFY}
-LIB_DEPENDS+=		inotify:${PORTSDIR}/devel/libinotify
-CONFIGURE_ARGS+=	--enable-inotify
-.else
-CONFIGURE_ARGS+=	--disable-inotify
-.endif
-
-.if ${PORT_OPTIONS:MLUA_CAIRO}
-LIB_DEPENDS+=		cairo:${PORTSDIR}/graphics/cairo
-BUILD_DEPENDS+=		tolua++-5.1:${PORTSDIR}/lang/tolua++
-RUN_DEPENDS+=		tolua++-5.1:${PORTSDIR}/lang/tolua++
-CONFIGURE_ARGS+=	--enable-lua-cairo
-.else
-CONFIGURE_ARGS+=	--disable-lua-cairo
-.endif
-
-.if ${PORT_OPTIONS:MLUA_IMLIB2}
-BUILD_DEPENDS+=		tolua++-5.1:${PORTSDIR}/lang/tolua++
-RUN_DEPENDS+=		tolua++-5.1:${PORTSDIR}/lang/tolua++
-CONFIGURE_ARGS+=	--enable-lua-imlib2
-.else
-CONFIGURE_ARGS+=	--disable-lua-imlib2
-.endif
-
 .if ${PORT_OPTIONS:MLUA} || ${PORT_OPTIONS:MLUA_CAIRO} || ${PORT_OPTIONS:MLUA_IMLIB2}
 USE_LUA=		5.1+
 CONFIGURE_ARGS+=	--enable-lua
@@ -128,60 +116,8 @@ CONFIGURE_ARGS+=	--enable-lua
 CONFIGURE_ARGS+=	--disable-lua
 .endif
 
-.if ${PORT_OPTIONS:MMETAR}
-LIB_DEPENDS+=		curl:${PORTSDIR}/ftp/curl
-CONFIGURE_ARGS+=	--enable-weather-metar
-.else
-CONFIGURE_ARGS+=	--disable-weather-metar
-.endif
-
-.if ${PORT_OPTIONS:MMOC}
-CONFIGURE_ARGS+=	--enable-moc
-.else
-CONFIGURE_ARGS+=	--disable-moc
-.endif
-
-.if ${PORT_OPTIONS:MMPD}
-CONFIGURE_ARGS+=	--enable-mpd
-.else
-CONFIGURE_ARGS+=	--disable-mpd
-.endif
-
-.if ${PORT_OPTIONS:MNCURSES}
-CONFIGURE_ARGS+=	--enable-ncurses
-.else
-CONFIGURE_ARGS+=	--disable-ncurses
-.endif
-
-.if ${PORT_OPTIONS:MRSS}
-LIB_DEPENDS+=		curl:${PORTSDIR}/ftp/curl \
-			xml2:${PORTSDIR}/textproc/libxml2
-CONFIGURE_ARGS+=	--enable-rss
-USE_GNOME+=		glib20
-.else
-CONFIGURE_ARGS+=	--disable-rss
-.endif
-
-.if ${PORT_OPTIONS:MXFT}
-LIB_DEPENDS+=		Xft:${PORTSDIR}/x11-fonts/libXft
-CONFIGURE_ARGS+=	--enable-xft
-.else
-CONFIGURE_ARGS+=	--disable-xft
-.endif
-
-.if ${PORT_OPTIONS:MXMMS2}
-LIB_DEPENDS+=		xmmsclient:${PORTSDIR}/audio/xmms2
-CONFIGURE_ARGS+=	--enable-xmms2
-.else
-CONFIGURE_ARGS+=	--disable-xmms2
-.endif
-
-.if ${PORT_OPTIONS:MXOAP}
-LIB_DEPENDS+=		curl:${PORTSDIR}/ftp/curl \
-			xml2:${PORTSDIR}/textproc/libxml2
-CONFIGURE_ARGS+=	--enable-weather-xoap
-.else
-CONFIGURE_ARGS+=	--disable-weather-xoap
+.if ${PORT_OPTIONS:MLUA_CAIRO} || ${PORT_OPTIONS:MLUA_IMLIB2}
+LUA_COMPS=		toluaxx
 .endif
 
 post-patch:
@@ -191,23 +127,18 @@ post-patch:
 		${WRKSRC}/src/imlib2.c
 
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/src/conky ${PREFIX}/bin
-	${INSTALL_MAN} ${WRKSRC}/doc/conky.1 ${PREFIX}/man/man1
+	${INSTALL_PROGRAM} ${WRKSRC}/src/conky ${STAGEDIR}${PREFIX}/bin
+	${INSTALL_MAN} ${WRKSRC}/doc/conky.1 ${STAGEDIR}${MANPREFIX}/man/man1
 
 post-install:
-.if ${PORT_OPTIONS:MEXAMPLES}
-	@${MKDIR} ${EXAMPLESDIR}
-	@${INSTALL_DATA} ${EXAMPLE_CONF_FILE} ${EXAMPLESDIR}/conkyrc.sample
-.endif
-
-.if ${PORT_OPTIONS:MDOCS}
-	@${MKDIR} ${DOCSDIR}
+	@${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
+	${INSTALL_DATA} ${EXAMPLE_CONF_FILE} ${STAGEDIR}${EXAMPLESDIR}/conkyrc.sample
+	@${MKDIR} ${STAGEDIR}${DOCSDIR}
 .for i in README AUTHORS ChangeLog TODO NEWS
-	${INSTALL_DATA} ${WRKSRC}/${i} ${DOCSDIR}
+	${INSTALL_DATA} ${WRKSRC}/${i} ${STAGEDIR}${DOCSDIR}
 .endfor
 .for i in docs.html variables.html config_settings.html
-	${INSTALL_DATA} ${WRKSRC}/doc/${i} ${DOCSDIR}
+	${INSTALL_DATA} ${WRKSRC}/doc/${i} ${STAGEDIR}${DOCSDIR}
 .endfor
-.endif
 
 .include <bsd.port.mk>

Modified: head/sysutils/conky/pkg-descr
==============================================================================
--- head/sysutils/conky/pkg-descr	Thu Jan 30 19:40:44 2014	(r341878)
+++ head/sysutils/conky/pkg-descr	Thu Jan 30 19:45:17 2014	(r341879)
@@ -1,3 +1,3 @@
 Conky is an advanced, highly configurable system monitor for X
 
-WWW:	http://conky.sourceforge.net/
+WWW: http://conky.sourceforge.net/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Pawel Pekala freebsd_committer 2014-01-30 19:45:36 UTC
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!