Bug 185373 - graphics/kix-kmod : stagify, cleanups
Summary: graphics/kix-kmod : stagify, cleanups
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rene Ladan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-31 17:50 UTC by Rene Ladan
Modified: 2014-01-07 17:50 UTC (History)
0 users

See Also:


Attachments
file.diff (1.37 KB, patch)
2013-12-31 17:50 UTC, Rene Ladan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer 2013-12-31 17:50:00 UTC
- Stagify graphics/kix-kmod 
- cleanups for 'make check-sanity' and 'portlint -c'
- just include bsd.port.mk instead of bsd.{pre|post}.port.mk

The MASTER_SITES was defined wrongly, fixing that revealed a checksum mismatch (the file size is correct).
Can you verify that the changes are OK ?

Redports build: https://redports.org/buildarchive/20131231170201-61784

How-To-Repeat: Start removing NO_STAGE support from Mk/Uses/kmod.mk
Comment 1 Edwin Groothuis freebsd_committer 2013-12-31 17:50:06 UTC
Maintainer of graphics/kix-kmod,

Please note that PR ports/185373 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/185373

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer 2013-12-31 17:50:07 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Rene Ladan freebsd_committer 2013-12-31 18:26:45 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rene

Track
Comment 4 jon 2014-01-07 15:23:59 UTC
Hiya

[ Was it really a dozen years since I wrote this program!? :-O ]

The changes look good, thanks.

Cheers,

=97Jon
Comment 5 dfilter service freebsd_committer 2014-01-07 17:44:02 UTC
Author: rene
Date: Tue Jan  7 17:43:54 2014
New Revision: 339014
URL: http://svnweb.freebsd.org/changeset/ports/339014

Log:
  - Stagify
  - Fix MASTER_SITES and recalculate SHA256 checksum
  - Pet portlint
  - Include bsd.port.mk once
  
  PR:		ports/185373
  Submitted by:	rene
  Approved by:	maintainer <jon@witchspace.com>

Modified:
  head/graphics/kix-kmod/Makefile
  head/graphics/kix-kmod/distinfo

Modified: head/graphics/kix-kmod/Makefile
==============================================================================
--- head/graphics/kix-kmod/Makefile	Tue Jan  7 17:42:09 2014	(r339013)
+++ head/graphics/kix-kmod/Makefile	Tue Jan  7 17:43:54 2014	(r339014)
@@ -5,26 +5,20 @@ PORTNAME=       kix
 PORTVERSION=	1.0
 PORTREVISION=	1
 CATEGORIES=     graphics
-MASTER_SITES=   http://homepage.ntlworld.com/jon.belson/files/kix-1.0.tar.gz \
+MASTER_SITES=   http://homepage.ntlworld.com/jon.belson/files/ \
 	LOCAL/pgollucci
 PKGNAMESUFFIX=	-kmod
 
 MAINTAINER=	jon@witchspace.com
-COMMENT=	A graphical screensaver kernel module
-
-NO_STAGE=	yes
+COMMENT=	Graphical screensaver kernel module
 
 USES=		kmod
-.include <bsd.port.pre.mk>
 
 MAKE_ENV+=	WERROR=
 PLIST_FILES=	lib/kix_saver.ko
 SUB_FILES=	pkg-message
 
 do-install:
-	${INSTALL_KLD} ${WRKSRC}/kix_saver.ko ${PREFIX}/lib
-
-post-install:
-	@${CAT} ${PKGMESSAGE}
+	${INSTALL_KLD} ${WRKSRC}/kix_saver.ko ${STAGEDIR}${PREFIX}/lib
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>

Modified: head/graphics/kix-kmod/distinfo
==============================================================================
--- head/graphics/kix-kmod/distinfo	Tue Jan  7 17:42:09 2014	(r339013)
+++ head/graphics/kix-kmod/distinfo	Tue Jan  7 17:43:54 2014	(r339014)
@@ -1,2 +1,2 @@
-SHA256 (kix-1.0.tar.gz) = 372e7f294064fe7852086f7b977558339cf686c4d42a36d952d9479634aa475b
+SHA256 (kix-1.0.tar.gz) = 808f93721213a51251aa8614afa0b4852399eb7498bb20cd3410ad84c7645ce7
 SIZE (kix-1.0.tar.gz) = 3497
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Rene Ladan freebsd_committer 2014-01-07 17:44:49 UTC
State Changed
From-To: feedback->closed

Committed, thanks