Bug 185754 - [UPDATE] games/0verkill, fix issues reported by portlint
Summary: [UPDATE] games/0verkill, fix issues reported by portlint
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Landin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-13 20:20 UTC by hardy.schumacher
Modified: 2014-02-10 11:20 UTC (History)
0 users

See Also:


Attachments
file.diff (1.35 KB, patch)
2014-01-13 20:20 UTC, hardy.schumacher
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description hardy.schumacher 2014-01-13 20:20:00 UTC
Portlint reported some issues related to new options framework and direct use of reserved variables.

Fix: Patch attached with submission follows:
How-To-Repeat: n/a
Comment 1 Edwin Groothuis freebsd_committer 2014-01-13 20:20:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mich

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2014-02-10 11:14:45 UTC
Author: mich
Date: Mon Feb 10 11:14:37 2014
New Revision: 343620
URL: http://svnweb.freebsd.org/changeset/ports/343620
QAT: https://qat.redports.org/buildarchive/r343620/

Log:
  - Portlint reported some issues related to new options framework and direct use of reserved variables.
  
  PR:		ports/185754
  Submitted by:	Hardy Schumacher <hardy.schumacher@gmx.de>

Modified:
  head/games/0verkill/Makefile

Modified: head/games/0verkill/Makefile
==============================================================================
--- head/games/0verkill/Makefile	Mon Feb 10 10:38:25 2014	(r343619)
+++ head/games/0verkill/Makefile	Mon Feb 10 11:14:37 2014	(r343620)
@@ -31,23 +31,26 @@ post-patch:
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/0verkill ${STAGEDIR}${PREFIX}/bin
-.for file in avi bot editor server test_server
-	${INSTALL_PROGRAM} ${WRKSRC}/${file} \
-		${STAGEDIR}${PREFIX}/bin/0verkill-${file}
+.for filename in avi bot editor server test_server
+	${INSTALL_PROGRAM} ${WRKSRC}/${filename} \
+		${STAGEDIR}${PREFIX}/bin/0verkill-${filename}
 .endfor
 .if ${PORT_OPTIONS:MX11}
 	${INSTALL_PROGRAM} ${WRKSRC}/x0verkill ${STAGEDIR}${PREFIX}/bin
-.for file in avi editor
-	${INSTALL_PROGRAM} ${WRKSRC}/x${file} \
-		${STAGEDIR}${PREFIX}/bin/x0verkill-${file}
+.for filename in avi editor
+	${INSTALL_PROGRAM} ${WRKSRC}/x${filename} \
+		${STAGEDIR}${PREFIX}/bin/x0verkill-${filename}
 .endfor
 .endif
 .for dir in data grx
 	cd ${WRKSRC} && ${COPYTREE_SHARE} ${dir} ${STAGEDIR}${DATADIR}
 .endfor
+
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
-.for file in AUTHORS README.html avi.txt bot.txt doc.html
-	${INSTALL_DATA} ${WRKSRC}/doc/${file} ${STAGEDIR}${DOCSDIR}
+.for filename in AUTHORS README.html avi.txt bot.txt doc.html
+	${INSTALL_DATA} ${WRKSRC}/doc/${filename} ${STAGEDIR}${DOCSDIR}
 .endfor
+.endif
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Michael Landin freebsd_committer 2014-02-10 11:15:03 UTC
State Changed
From-To: open->closed

Committed, thanks!