Bug 185884 - devel/llvm33, devel/py-qt4, emulators/virtualbox-ose: Python 3 fixes
Summary: devel/llvm33, devel/py-qt4, emulators/virtualbox-ose: Python 3 fixes
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: needs-qa, patch
Depends on: 180467
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-19 17:20 UTC by Nathan Whitehorn
Modified: 2018-01-09 16:03 UTC (History)
7 users (show)

See Also:
rakuco: maintainer-feedback+
koobs: maintainer-feedback? (brooks)
jkim: maintainer-feedback+


Attachments
file.diff (1.81 KB, patch)
2014-01-19 17:20 UTC, Nathan Whitehorn
no flags Details | Diff
py3fixes.diff (6.85 KB, patch)
2014-01-20 02:23 UTC, nwhitehorn
no flags Details | Diff
py3-sphinx.diff (903 bytes, patch)
2014-01-25 22:16 UTC, Nathan Whitehorn
no flags Details | Diff
py3.diff (8.22 KB, patch)
2014-02-14 15:19 UTC, nwhitehorn
no flags Details | Diff
Updated Patch (5.62 KB, patch)
2014-06-08 15:03 UTC, Nathan Whitehorn
rakuco: maintainer-approval-
koobs: maintainer-approval+
koobs: maintainer-approval+
brooks: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Whitehorn freebsd_committer 2014-01-19 17:20:00 UTC
The attached patch fixes some miscellaneous issues I experienced with DEFAULT_VERSIONS=python=3.3 set in /etc/make.conf, mostly by specifying that python 2 is required. The devel/py-qt4-core bit fixes some logic to avoid byte-compiling code for the wrong python version by removing the directory not applicable to the package rather than unconditionally removing the python 3 one.

Fix: Patch attached with submission follows:
Comment 1 nwhitehorn 2014-01-20 02:23:37 UTC
An updated patch with a few more plist fixes.
-Nathan
Comment 2 Nathan Whitehorn freebsd_committer 2014-01-25 22:16:28 UTC
Here's another patch (an addition to the last rather than a replacement) 
that fixes sphinx. Doing the grammar pickle generation post-build 
happens before 2to3 is run, with the result that the command will fail 
to execute. Running it in the stage directory solves the problem.
-Nathan
Comment 3 Nathan Whitehorn freebsd_committer 2014-01-26 15:05:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-python
Comment 4 nwhitehorn 2014-02-14 15:19:14 UTC
Here's an updated version of the patch with respect to r344210.
-Nathan
Comment 5 Nathan Whitehorn freebsd_committer 2014-06-08 15:03:35 UTC
Created attachment 143532 [details]
Updated Patch

Newer version of this patch. Also see bug 180467.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-05 15:19:55 UTC
Canonicalise python@ assignment.
Comment 7 Alfred Perlstein freebsd_committer 2016-02-07 21:43:43 UTC
Koobs, is this going to be committed?
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2016-02-10 14:51:18 UTC
@Alfred I'm not sure this change comes under python@ domain, since it makes changes to ports not maintained by the python team. I should/could have noticed this when canonicalising the python@ assignment, but did not inspect the attachment contents at the time.

On first look however it appears that a few updates to the patches are probably necessary, in terms of:

* that the reported issues are still present in the ports
* if so, ensuring the diffs still apply (and are valid) against ports head
* that any python framework changes that have occurred since submission are reflected. For instance, PYTHON_PY3K_PLIST_HACK has been removed.

To ensure that future issues don't fall through the cracks like this one, it's important to create an issue per port (for port changes), or an issue per isolated/standalone change, so that individual maintainers can be automatically informed and assigned.

I have cc'd the relevant maintainers on this issue now, though 'assignment' is the primary way committers (particularly those in teams@) track their open task lists.
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2016-02-10 14:52:41 UTC
@Nathan, It would also be good if at the very least, each port's changes was in a separate attachment, such that maintainer-approval can be requested for each of them individually.
Comment 10 Raphael Kubo da Costa freebsd_committer 2016-02-10 15:07:18 UTC
The devel/py-qt4-core changes were also sent in bug 180467 and landed in ports r358702 ages ago.
Comment 11 Kubilay Kocak freebsd_committer freebsd_triage 2016-02-10 16:03:05 UTC
Thank you Raphael :)

1 down 2 to go.

I'll help coordinate resolution on this (take)
Comment 12 Brooks Davis freebsd_committer 2016-02-10 17:52:44 UTC
Comment on attachment 143532 [details]
Updated Patch

Looks fine for llvm33.  Similar fixes are likely needed for other llvm ports (none of the existing ones will likely ever work with python 3).
Comment 13 Kubilay Kocak freebsd_committer freebsd_triage 2016-02-13 11:48:39 UTC
Comment on attachment 143532 [details]
Updated Patch

Testing, ignore.
Comment 14 Walter Schwarzenfeld freebsd_triage 2018-01-09 15:29:02 UTC
I think this is overcome by events.