Bug 186018 - [PATCH] multimedia/smplayer Add missing dependency, DOCS Option
Summary: [PATCH] multimedia/smplayer Add missing dependency, DOCS Option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rusmir Dusko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-22 20:40 UTC by Rusmir Dusko
Modified: 2014-01-22 21:00 UTC (History)
0 users

See Also:


Attachments
file.diff (1.96 KB, patch)
2014-01-22 20:40 UTC, Rusmir Dusko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rusmir Dusko freebsd_committer 2014-01-22 20:40:00 UTC
- Bump PORTREVISION for dependency change
- Add dependency for multimedia/smplayer-skins
- Add DOCS Option
- Add pkg-message about multimedia/smtube
- Strip executable

Fix: Apply enclosed smplayer.diff

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2014-01-22 20:40:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dhn

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Dennis Herrmann freebsd_committer 2014-01-22 20:41:30 UTC
State Changed
From-To: open->feedback

Hey, can you take this PR for me? I am very busy atm.
Comment 3 Rusmir Dusko freebsd_committer 2014-01-22 20:54:14 UTC
State Changed
From-To: feedback->open

Maintainer has approved.
Comment 4 Rusmir Dusko freebsd_committer 2014-01-22 20:54:28 UTC
Responsible Changed
From-To: dhn->nemysis

I'll take it.
Comment 5 Rusmir Dusko freebsd_committer 2014-01-22 20:57:22 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer 2014-01-22 20:58:24 UTC
Author: nemysis
Date: Wed Jan 22 20:58:16 2014
New Revision: 340732
URL: http://svnweb.freebsd.org/changeset/ports/340732
QAT: https://qat.redports.org/buildarchive/r340732/

Log:
  - Bump PORTREVISION for dependency change
  - Add dependency for multimedia/smplayer-skins
  - Add DOCS Option
  - Add pkg-message about multimedia/smtube
  - Strip executable
  
  PR:		ports/186018
  Submitted by:	nemysis (self)
  Approved by:	maintainer

Added:
  head/multimedia/smplayer/files/pkg-message.in   (contents, props changed)
Modified:
  head/multimedia/smplayer/Makefile

Modified: head/multimedia/smplayer/Makefile
==============================================================================
--- head/multimedia/smplayer/Makefile	Wed Jan 22 20:52:31 2014	(r340731)
+++ head/multimedia/smplayer/Makefile	Wed Jan 22 20:58:16 2014	(r340732)
@@ -3,6 +3,7 @@
 
 PORTNAME=	smplayer
 DISTVERSION=	0.8.6
+PORTREVISION=	1
 CATEGORIES=	multimedia audio kde
 MASTER_SITES=	SF/${PORTNAME}/SMPlayer/${PORTVERSION}
 
@@ -10,6 +11,7 @@ MAINTAINER=	dhn@FreeBSD.org
 COMMENT=	Complete front-end based on Qt4 for mplayer
 
 RUN_DEPENDS=	mplayer:${PORTSDIR}/multimedia/mplayer \
+		${LOCALBASE}/share/smplayer/themes:${PORTSDIR}/multimedia/smplayer-skins \
 		${LOCALBASE}/share/smplayer/themes:${PORTSDIR}/multimedia/smplayer-themes
 
 USE_QT4=	gui network script xml moc_build rcc_build uic_build \
@@ -26,6 +28,10 @@ INSTALLS_ICONS=	yes
 PORTDOCS=	Changelog Copying.txt Install.txt Not_so_obvious_things.txt \
 		Readme.txt Release_notes.txt
 
+OPTIONS_DEFINE=	DOCS
+
+SUB_FILES=      pkg-message
+
 .include <bsd.port.options.mk>
 
 post-patch:
@@ -36,9 +42,9 @@ post-patch:
 		${WRKSRC}/Makefile
 
 post-install:
-.if ${PORT_OPTIONS:MDOCS}
+	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/${PORTNAME}
+
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
-	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
-.endif
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
 
 .include <bsd.port.mk>

Added: head/multimedia/smplayer/files/pkg-message.in
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/multimedia/smplayer/files/pkg-message.in	Wed Jan 22 20:58:16 2014	(r340732)
@@ -0,0 +1,7 @@
+===============================================================================
+
+SMPlayer has been installed.
+
+For Youtube Videos please use multimedia/smtube port.
+
+===============================================================================
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"