Bug 186045 - patch to x11-drivers/xf86-input-mouse to support FlipXY
Summary: patch to x11-drivers/xf86-input-mouse to support FlipXY
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-23 18:50 UTC by Brock Williams
Modified: 2018-06-21 21:30 UTC (History)
4 users (show)

See Also:

Attachments
file.diff (1.31 KB, patch)
2014-01-23 18:50 UTC, Brock Williams 		no flags Details | Diff
svn-diff-patch-src-bsd_mouse.c (1.65 KB, patch)
2018-01-12 02:17 UTC, Walter Schwarzenfeld 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brock Williams 2014-01-23 18:50:00 UTC 
Additional patch for x11-drivers/xf86-input-mouse to support FlipXY/SwapXY option.  This allows us to use an eGalax based usb hid touchscreen where the axes are inverted.  See kern/183032 for more discussion.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-24 01:13:45 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-x11

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Bartek Rutkowski freebsd_committer freebsd_triage 2016-01-01 14:41:25 UTC 
Any chance to resubmit the patch in proper format? Right now I dont see clearly against which file it should be applied.
Comment 3 Bertram Scharpf 2016-01-02 15:22:47 UTC 
As the first line says it is "src/bsd_mouse.c". And it did
not take me 2 (two!) years to find that out.

Maybe the confusing point is that this is a patch of an
already patched file. The first patch is
"/usr/ports/x11-drivers/xf86-input-mouse/files/patch-src-bsd_mouse.c".
(I give the whole path in case you do not manage to find it.)

By the way, this first patch was changed two times in the
last two years.

Sure, the proposed patch could have been designed smarter.
First of all the documentation is missing. It could have
been submitted as a patch to the prior patch. But leaving a
request that covers changes to 5 (five!) lines of code
unanswered for almost two years, and then giving such an
evasive answer, is a *real* bummer!
Comment 4 Walter Schwarzenfeld freebsd_triage 2018-01-12 02:17:13 UTC 
Created attachment 189641 [details]
svn-diff-patch-src-bsd_mouse.c
Comment 5 Walter Schwarzenfeld freebsd_triage 2018-01-12 02:17:56 UTC 
Simply appended the new patch to the old. Patch applies, but have not tested functionality.
Comment 6 Niclas Zeising freebsd_committer freebsd_triage 2018-01-12 21:40:22 UTC 
I can't test this, since I lack the hardware.  Are both patches needed, or is the old one obsoleted?
Comment 7 Niclas Zeising freebsd_committer freebsd_triage 2018-06-10 06:42:48 UTC 
Still waiting for feedback on this.