Bug 186305 - [patch] [update] graphics/pngcrush: update, staging support, take maintainership
Summary: [patch] [update] graphics/pngcrush: update, staging support, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rusmir Dusko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-31 17:20 UTC by vsjcfm
Modified: 2014-03-05 12:00 UTC (History)
0 users

See Also:


Attachments
file.txt (1.44 KB, text/plain)
2014-01-31 17:20 UTC, vsjcfm
no flags Details
patch.txt (1.40 KB, text/plain; charset=US-ASCII)
2014-02-18 11:21 UTC, vsjcfm
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description vsjcfm 2014-01-31 17:20:01 UTC
1. Update to 1.7.70
2. Staging support
As I can see, jsa@ has no time to update pngcrush seasonably (last version released at 2013-12-22), so I would like to take maintainership also.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-01-31 17:20:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jsa

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 vsjcfm 2014-02-18 11:21:09 UTC
New patch attached:
Comment 3 Rusmir Dusko freebsd_committer freebsd_triage 2014-03-03 23:58:07 UTC
Responsible Changed
From-To: jsa->nemysis

I'll take it.
Comment 4 Rusmir Dusko freebsd_committer freebsd_triage 2014-03-04 00:15:26 UTC
Joseph S. Atkinson

Do you approve this changes and to you wish to give maintianer ship
to Anton Sayetsky?



Anton Sayetsky please send svn diff, yours diff is not usable good

use only

svn co svn://svn.FreeBSD.org/ports/head /usr/ports

and use

svn checkout svn://svn.freebsd.org/ports/head/graphics/pngcrush pngcrush

then make Changes and

svn diff > ../pngcrush.diff

-- 
Best regards,
Rusmir Dusko
Comment 5 Rusmir Dusko freebsd_committer freebsd_triage 2014-03-04 01:18:36 UTC
> Someone will need to validate the patch. This port goes into flurries of
> updates to long cycles of inactivity. Patch notes are not always in sync
> with releases on the main page. Most updates are irrelevant to non-Windows
> OSes and are just rerolls against new libs. He can take it. Good luck.
> Joseph S. Atkinson

> Do you approve this changes and to you wish to give maintianer ship
> to Anton Sayetsky?

Good i look good on this patch and look that someone to validate.
Not wish to commit, when all are not good.

> > Anton Sayetsky please send svn diff, yours diff is not usable good

> > use only

> > svn co svn://svn.FreeBSD.org/ports/head /usr/ports

> > and use

> > svn checkout svn://svn.freebsd.org/ports/head/graphics/pngcrush pngcrush

> > then make Changes and

> > svn diff > ../pngcrush.diff

-- 
Best regards,
Rusmir Dusko
Comment 6 vsjcfm 2014-03-04 11:12:16 UTC
2014-03-04 2:15 GMT+02:00 Rusmir Dusko <nemysis@freebsd.org>:
> Anton Sayetsky please send svn diff, yours diff is not usable good
>
> use only
>
> svn co svn://svn.FreeBSD.org/ports/head /usr/ports
>
> and use
>
> svn checkout svn://svn.freebsd.org/ports/head/graphics/pngcrush pngcrush
>
> then make Changes and
>
> svn diff > ../pngcrush.diff
Hello,
Why'd you think that patch is not usable? I'm using only svn for a
long period of time, and this patch was generated by svn diff, of
course. Below I prove this by posting few first lines:
> Index: /usr/ports/graphics/pngcrush/Makefile
> ===================================================================
> --- /usr/ports/graphics/pngcrush/Makefile (revision 344850)
> +++ /usr/ports/graphics/pngcrush/Makefile (working copy)

The only difference that I diffed whole ports tree rather than only
pngcrush directory. So you can just cd ${PORTSDIR} && patch <
${patchfile}
But I can remake patch if it's an absolute requirement.
Comment 7 vsjcfm 2014-03-04 11:30:49 UTC
2014-03-04 2:20 GMT+02:00 Joseph S. Atkinson <jsa@freebsd.org>:
> Someone will need to validate the patch. This port goes into flurries of
> updates to long cycles of inactivity. Patch notes are not always in sync
> with releases on the main page. Most updates are irrelevant to non-Windows
> OSes and are just rerolls against new libs. He can take it. Good luck.
Few notes:
1. I'm only sending patches for ports those are installed on my
machines, so I've tested all of them - port succesfully installs &
works perfectly.
2. About updates - agreed, but at least in 1.7.68 important updates was made.
3. Yes, we can update pngcrush to 1.7.68, but it doesn't makes any
sense for me - it's easier to have latest version.
Comment 8 Mathieu Arnold freebsd_committer freebsd_triage 2014-03-05 11:50:12 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 9 dfilter service freebsd_committer freebsd_triage 2014-03-05 11:50:13 UTC
Author: mat
Date: Wed Mar  5 11:50:04 2014
New Revision: 347106
URL: http://svnweb.freebsd.org/changeset/ports/347106
QAT: https://qat.redports.org/buildarchive/r347106/

Log:
  - Update to 1.7.71
  - Stage
  - Pass maintainership to submitter
  
  maintainer timeout (1 month)
  
  PR:		186305
  Submitted by:	Anton Sayetsky
  Sponsored by:	Absolight

Modified:
  head/graphics/pngcrush/Makefile
  head/graphics/pngcrush/distinfo

Modified: head/graphics/pngcrush/Makefile
==============================================================================
--- head/graphics/pngcrush/Makefile	Wed Mar  5 11:01:24 2014	(r347105)
+++ head/graphics/pngcrush/Makefile	Wed Mar  5 11:50:04 2014	(r347106)
@@ -2,13 +2,13 @@
 # $FreeBSD$
 
 PORTNAME=	pngcrush
-PORTVERSION=	1.7.67
+PORTVERSION=	1.7.71
 CATEGORIES=	graphics
 MASTER_SITES=	SF/pmt/${PORTNAME}/${PORTVERSION}/ \
 		SF/pmt/${PORTNAME}/old-versions/1.7/${PORTVERSION}/
 DISTNAME=	${PORTNAME}-${PORTVERSION}-nolib
 
-MAINTAINER=	jsa@FreeBSD.org
+MAINTAINER=	vsjcfm@gmail.com
 COMMENT=	Optimizer for PNG files
 
 LIB_DEPENDS=	libpng15.so:${PORTSDIR}/graphics/png
@@ -20,8 +20,7 @@ MAKE_ARGS+=	CC="${CC}" CFLAGS="${CFLAGS}
 
 PLIST_FILES=	bin/pngcrush
 
-NO_STAGE=	yes
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/pngcrush ${PREFIX}/bin/pngcrush
+	${INSTALL_PROGRAM} ${WRKSRC}/pngcrush ${STAGEDIR}${PREFIX}/bin/pngcrush
 
 .include <bsd.port.mk>

Modified: head/graphics/pngcrush/distinfo
==============================================================================
--- head/graphics/pngcrush/distinfo	Wed Mar  5 11:01:24 2014	(r347105)
+++ head/graphics/pngcrush/distinfo	Wed Mar  5 11:50:04 2014	(r347106)
@@ -1,2 +1,2 @@
-SHA256 (pngcrush-1.7.67-nolib.tar.xz) = 1ed050059f38504ca9eeef5bfae88fe8c69905e7337e454254cf2fad20f8e83c
-SIZE (pngcrush-1.7.67-nolib.tar.xz) = 57908
+SHA256 (pngcrush-1.7.71-nolib.tar.xz) = cdb3a58122ff35187e126e605a82709cb33e39c52af8f16254a5408368a0aa24
+SIZE (pngcrush-1.7.71-nolib.tar.xz) = 58412
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"