Bug 186590 - [patch] converters/libiconv forces docs installation
Summary: [patch] converters/libiconv forces docs installation
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-09 15:40 UTC by Adam Weinberger
Modified: 2014-03-03 21:20 UTC (History)
0 users

See Also:


Attachments
libiconv.patch (731 bytes, patch)
2014-02-09 15:40 UTC, Adam Weinberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer 2014-02-09 15:40:00 UTC
Docs are installed unconditionally right now, even with libiconv_UNSET=DOCS,
because the pkg-plist is missing %%PORTDOCS%% markers.

Fix: Pretty easy fix though!
Comment 1 Edwin Groothuis freebsd_committer 2014-02-09 15:40:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 adamw 2014-03-03 17:20:23 UTC
Guys, any response on this? It's a pretty trivial change.

http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186590

I'm going to commit this later today unless I hear otherwise from the team.

# Adam


--
Adam Weinberger
adamw@adamw.org
http://www.adamw.org
Comment 3 Koop Mast 2014-03-03 20:35:59 UTC
No objections.
Comment 4 dfilter service freebsd_committer 2014-03-03 21:15:37 UTC
Author: adamw
Date: Mon Mar  3 21:15:30 2014
New Revision: 346968
URL: http://svnweb.freebsd.org/changeset/ports/346968
QAT: https://qat.redports.org/buildarchive/r346968/

Log:
  Don't unconditionally install DOCS. PORTREVISION bump
  for plist change.
  
  PR:		ports/186590
  Approved by:	maintainer

Modified:
  head/converters/libiconv/Makefile
  head/converters/libiconv/pkg-plist

Modified: head/converters/libiconv/Makefile
==============================================================================
--- head/converters/libiconv/Makefile	Mon Mar  3 21:13:59 2014	(r346967)
+++ head/converters/libiconv/Makefile	Mon Mar  3 21:15:30 2014	(r346968)
@@ -3,7 +3,7 @@
 
 PORTNAME=	libiconv
 PORTVERSION=	1.14
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	converters devel
 MASTER_SITES=	GNU
 

Modified: head/converters/libiconv/pkg-plist
==============================================================================
--- head/converters/libiconv/pkg-plist	Mon Mar  3 21:13:59 2014	(r346967)
+++ head/converters/libiconv/pkg-plist	Mon Mar  3 21:15:30 2014	(r346968)
@@ -17,10 +17,10 @@ man/man3/iconv_open.3.gz
 man/man3/iconv_open_into.3.gz
 man/man3/iconv_close.3.gz
 man/man3/iconvctl.3.gz
-%%DOCSDIR%%/iconv.1.html
-%%DOCSDIR%%/iconv.3.html
-%%DOCSDIR%%/iconv_close.3.html
-%%DOCSDIR%%/iconv_open.3.html
-%%DOCSDIR%%/iconv_open_into.3.html
-%%DOCSDIR%%/iconvctl.3.html
-@dirrm %%DOCSDIR%%
+%%PORTDOCS%%%%DOCSDIR%%/iconv.1.html
+%%PORTDOCS%%%%DOCSDIR%%/iconv.3.html
+%%PORTDOCS%%%%DOCSDIR%%/iconv_close.3.html
+%%PORTDOCS%%%%DOCSDIR%%/iconv_open.3.html
+%%PORTDOCS%%%%DOCSDIR%%/iconv_open_into.3.html
+%%PORTDOCS%%%%DOCSDIR%%/iconvctl.3.html
+%%PORTDOCS%%@dirrm %%DOCSDIR%%
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Adam Weinberger freebsd_committer 2014-03-03 21:15:43 UTC
State Changed
From-To: open->closed

Committed. Thanks for the review, Koop!