Bug 186638 - PATCH www/fcgiwrap: fix rc _flags
Summary: PATCH www/fcgiwrap: fix rc _flags
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-10 21:40 UTC by Johan Ström
Modified: 2014-07-13 16:32 UTC (History)
3 users (show)

See Also:

Attachments
file.diff (987 bytes, patch)
2014-02-10 21:40 UTC, Johan Ström 		no flags Details | Diff
Replacement of earlier patch. (1.34 KB, patch)
2014-07-13 12:09 UTC, A.J. "Fonz" van Werven 		freebsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Ström 2014-02-10 21:40:00 UTC 
	rc script does not handle fcgiwrap_flags properly due to two bugs in fcgiwrap.in 

	The first one is a typo, fciwrap_flags instead of fcgiwrap_flags.

	The second is the fact that ${name}_flags is passed to daemon rather than fcgiwrap.
	From rc.subr (8.4 and 9.2 at least):

		$command $rc_flags $command_args

	The attached patch fixes both problems.

Fix: --- files/fcgiwrap.patch begins here ---
How-To-Repeat: 	Install fcgiwrap, set (for example) fcgiwrap_flags="-f" to enable stdout forwarding.
	Start the script, and check ps, you will see it has not picked up the -f flag.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-07-12 11:14:50 UTC 
assign to new maintainer
Comment 2 A.J. "Fonz" van Werven 2014-07-12 11:47:28 UTC 
Thanks for reporting this. As the new maintainer of www/fcgiwrap I will look at it as soon as possible.
Comment 3 A.J. "Fonz" van Werven 2014-07-13 12:09:41 UTC 
Created attachment 144634 [details]
Replacement of earlier patch.

I created a new patch that also adds PORTREVISION. That one is now maintainer approved.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2014-07-13 15:25:03 UTC 
I'll take it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-07-13 15:30:53 UTC 
A commit references this bug:

Author: pi
Date: Sun Jul 13 15:30:09 UTC 2014
New revision: 361688
URL: http://svnweb.freebsd.org/changeset/ports/361688

Log:
  www/fcgiwrap: fix rc script, strip sbin/fcgiwrap

  PR:		186638
  Submitted by:	johan@stromnet.se
  Approved by:	freebsd@skysmurf.nl (maintainer)

Changes:
  head/www/fcgiwrap/Makefile
  head/www/fcgiwrap/files/fcgiwrap.in
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2014-07-13 16:32:01 UTC 
Committed with small change, thanks!