Bug 186652 - [smbfs] [panic] crash during umount -a -t smbfs
Summary: [smbfs] [panic] crash during umount -a -t smbfs
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 10.0-RELEASE
Hardware: Any Any
: Normal Affects Only Me
Assignee: Andrey V. Elsukov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-11 14:40 UTC by Martin
Modified: 2014-05-02 22:47 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin 2014-02-11 14:40:00 UTC
smbfs have been not responsive for all mounted shares. I tried to remount
them, but the kernel crashed shortly after executing umount -a -t smbfs.

Here is the stack trace:

#0  doadump (textdump=<value optimized out>) at pcpu.h:219
#1  0xffffffff808af530 in kern_reboot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:447
#2  0xffffffff808af8f4 in panic (fmt=<value optimized out>) at /usr/src/sys/kern/kern_shutdown.c:754
#3  0xffffffff80c8e692 in trap_fatal (frame=<value optimized out>, eva=<value optimized out>) at /usr/src/sys/amd64/amd64/trap.c:882
#4  0xffffffff80c8e969 in trap_pfault (frame=0xfffffe02298e5940, usermode=0) at /usr/src/sys/amd64/amd64/trap.c:699
#5  0xffffffff80c8e0f6 in trap (frame=0xfffffe02298e5940) at /usr/src/sys/amd64/amd64/trap.c:463
#6  0xffffffff80c75392 in calltrap () at /usr/src/sys/amd64/amd64/exception.S:232
#7  0xffffffff808f81ec in turnstile_broadcast (ts=0x0, queue=0) at /usr/src/sys/kern/subr_turnstile.c:838
#8  0xffffffff8089c860 in __mtx_unlock_sleep (c=0xfffff80207b37d08, opts=<value optimized out>, file=0xffffffff81c41001 " disordered parameters %d:%d\n", line=1) at /usr/src/sys/kern/kern_mutex.c:761
#9  0xffffffff8089c7e9 in __mtx_unlock_flags (c=<value optimized out>, opts=<value optimized out>, file=0xffffffff81c41001 " disordered parameters %d:%d\n", line=1) at /usr/src/sys/kern/kern_mutex.c:254
#10 0xffffffff81c37936 in smb_iod_invrq (iod=<value optimized out>) at /usr/src/sys/modules/smbfs/../../netsmb/smb_iod.c:91
#11 0xffffffff81c36597 in smb_iod_addrq (rqp=0xfffff80207b37c00) at /usr/src/sys/modules/smbfs/../../netsmb/smb_iod.c:116
#12 0xffffffff81c33984 in smb_rq_simple (rqp=0xfffff80207b37c00) at /usr/src/sys/modules/smbfs/../../netsmb/smb_rq.c:168
#13 0xffffffff81c31eac in smb_smb_ssnclose (vcp=<value optimized out>, scred=<value optimized out>) at /usr/src/sys/modules/smbfs/../../netsmb/smb_smb.c:464
#14 0xffffffff81c373df in smb_iod_thread (arg=0xfffff80027aec600) at /usr/src/sys/modules/smbfs/../../netsmb/smb_iod.c:180
#15 0xffffffff8088198a in fork_exit (callout=0xffffffff81c37290 <smb_iod_thread>, arg=0xfffff80027aec600, frame=0xfffffe02298e5c00) at /usr/src/sys/kern/kern_fork.c:995
#16 0xffffffff80c758ce in fork_trampoline () at /usr/src/sys/amd64/amd64/exception.S:606
#17 0x0000000000000000 in ?? ()


vmcore file is still available, if you need further information.

--
Martin Sugioarto
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-04-16 03:08:27 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-fs

Over to maintainer(s).
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-04-17 13:22:14 UTC
Author: ae
Date: Thu Apr 17 12:22:08 2014
New Revision: 264600
URL: http://svnweb.freebsd.org/changeset/base/264600

Log:
  Remove redundant unlock.
  
  This code was removed from the opensolaris and darwin's
  netsmb implementations, in DfBSD it also has been disabled.
  
  PR:		36566, 87859, 139407, 161579, 175557, 178412, 186652
  MFC after:	2 weeks
  Sponsored by:	Yandex LLC

Modified:
  head/sys/netsmb/smb_iod.c

Modified: head/sys/netsmb/smb_iod.c
==============================================================================
--- head/sys/netsmb/smb_iod.c	Thu Apr 17 12:16:51 2014	(r264599)
+++ head/sys/netsmb/smb_iod.c	Thu Apr 17 12:22:08 2014	(r264600)
@@ -87,8 +87,6 @@ smb_iod_invrq(struct smbiod *iod)
 	 */
 	SMB_IOD_RQLOCK(iod);
 	TAILQ_FOREACH(rqp, &iod->iod_rqlist, sr_link) {
-		if (rqp->sr_flags & SMBR_INTERNAL)
-			SMBRQ_SUNLOCK(rqp);
 		rqp->sr_flags |= SMBR_RESTART;
 		smb_iod_rqprocessed(rqp, ENOTCONN);
 	}
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 3 Andrey V. Elsukov freebsd_committer freebsd_triage 2014-05-02 22:47:05 UTC
State Changed
From-To: open->closed

Fixed in head/ and stable/10. 


Comment 4 Andrey V. Elsukov freebsd_committer freebsd_triage 2014-05-02 22:47:05 UTC
Responsible Changed
From-To: freebsd-fs->ae

Take it.