Bug 186669 - Removing devel/py-virtualenv/files/ broke five ports relying on py3k-fix-pkg-plist.inc in there
Summary: Removing devel/py-virtualenv/files/ broke five ports relying on py3k-fix-pkg-...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 03:00 UTC by Gereon Kaiping
Modified: 2014-02-12 05:59 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gereon Kaiping 2014-02-12 03:00:00 UTC
Ports commit r343610 (koobs, 2014-02-10 09:39:58) removed
/head/devel/py-virtualenv/files from the ports tree, but some ports
depend on a python3-fix-file in that directory.

# grep -F 'py-virtualenv/files/py3k-fix-pkg-plist.inc' devel/*/Makefile
devel/py-Jinja2/Makefile:.include
"${.CURDIR}/../py-virtualenv/files/py3k-fix-pkg-plist.inc"
devel/py-serpent/Makefile:.include
"${PORTSDIR}/devel/py-virtualenv/files/py3k-fix-pkg-plist.inc"
devel/py-stevedore/Makefile:.include
"${PORTSDIR}/devel/py-virtualenv/files/py3k-fix-pkg-plist.inc"
devel/py-watchdog/Makefile:.include
"${.CURDIR}/../py-virtualenv/files/py3k-fix-pkg-plist.inc"
devel/py-wheel/Makefile:.include
"${PORTSDIR}/devel/py-virtualenv/files/py3k-fix-pkg-plist.inc"

This leads to errors when trying to build these ports.

Fix: 

Provide devel/py-Jinja2, devel/py-serpent, devel/py-stevedore,
devel/py-watchdog and devel/py-wheel with their own copy of
py3k-fix-pkg-plist.inc and remove the path part
'${PORTSDIR}/devel/py-virtualenv/' from their Makefile.
How-To-Repeat: 
Have py33-Jinja2-2.7.1 or similar installed, and run
# portupgrade -a
make: "/usr/ports/devel/py-Jinja2/Makefile" line 93: Cannot open
/usr/ports/devel/py-Jinja2/../py-virtualenv/files/py3k-fix-pkg-plist.inc
make: Fatal errors encountered -- cannot continue** Makefile possibly
broken: devel/py-Jinja2:
** Please report this to the maintainer for devel/py-Jinja2
Comment 1 Edwin Groothuis freebsd_committer 2014-02-12 04:24:47 UTC
Responsible Changed
From-To: freebsd-ports-bugs->nivit

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2014-02-12 04:48:48 UTC
Responsible Changed
From-To: nivit->koobs

My pointyhat, I'll take it. Fix is coming shortly
Comment 3 dfilter service freebsd_committer 2014-02-12 04:56:09 UTC
Author: koobs
Date: Wed Feb 12 04:56:01 2014
New Revision: 343840
URL: http://svnweb.freebsd.org/changeset/ports/343840
QAT: https://qat.redports.org/buildarchive/r343840/

Log:
  devel/py-virtualenv: Restore py3k-fix-pkg-plist.inc
  
  Restore py3k-fix-pkg-plist.inc that other ports reference as they have not
  transitioned to AUTOPLIST and need it for Python 3.x compatibility.
  
  Add a comment to the include header as a breadcrumb with a PR reference.
  
  PR:		ports/186669
  Reported by:	Gereon Kaiping <kta1c10 ! gereon at linta dotde>
  Approved by:	maintainer (implicit, via email)

Added:
  head/devel/py-virtualenv/files/
  head/devel/py-virtualenv/files/py3k-fix-pkg-plist.inc   (contents, props changed)
Modified:
  head/devel/py-virtualenv/Makefile

Modified: head/devel/py-virtualenv/Makefile
==============================================================================
--- head/devel/py-virtualenv/Makefile	Wed Feb 12 04:55:21 2014	(r343839)
+++ head/devel/py-virtualenv/Makefile	Wed Feb 12 04:56:01 2014	(r343840)
@@ -2,6 +2,7 @@
 
 PORTNAME=	virtualenv
 PORTVERSION=	1.11.2
+PORTREVISION=	1
 CATEGORIES=	devel python
 MASTER_SITES=	CHEESESHOP
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}

Added: head/devel/py-virtualenv/files/py3k-fix-pkg-plist.inc
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/py-virtualenv/files/py3k-fix-pkg-plist.inc	Wed Feb 12 04:56:01 2014	(r343840)
@@ -0,0 +1,17 @@
+# Other ports reference this include file. DO NOT REMOVE until that is not the
+# case. See PR: ports/186669
+#
+# When Python version is 3.2+ we rewrite all the filenames
+# of TMPPLIST that end with .py[co], so that they conform
+# to PEP 3147 (see http://www.python.org/dev/peps/pep-3147/)
+PYMAGICTAG=	${PYTHON_CMD} -c 'import imp; print(imp.get_tag())'
+add-plist-post:
+	@${AWK} '\
+		/\.py[co]$$/ && !($$0 ~ "/" pc "/") {id = match($$0, /\/[^\/]+\.py[co]$$/); if (id != 0) {d = substr($$0, 1, RSTART - 1); dirs[d] = 1}; sub(/\.py[co]$$/,  "." mt "&"); sub(/[^\/]+\.py[co]$$/, pc "/&"); print; next} \
+		/^@dirrm / {d = substr($$0, 8); if (d in dirs) {print $$0 "/" pc}; print $$0; next} \
+		{print} \
+		END {if (sp in dirs) {print "@dirrm " sp "/" pc}} \
+		' \
+		pc="__pycache__" mt="$$(${PYMAGICTAG})" sp="${PYTHON_SITELIBDIR:S,${PYTHONBASE}/,,g}" \
+		${TMPPLIST} > ${TMPPLIST}.pyc_tmp
+	@${MV} ${TMPPLIST}.pyc_tmp ${TMPPLIST}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2014-02-12 05:59:29 UTC
State Changed
From-To: open->closed

Fix committed, thank you for your report Gereon!