Bug 186751 - [patch] Remove textproc/py-feedparser dependency on textproc/py-chardet and other fixes
[patch] Remove textproc/py-feedparser dependency on textproc/py-chardet and o...
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Sofian Brabez
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-14 02:20 UTC by Stephen R Guglielmo
Modified: 2014-05-28 23:10 UTC (History)
0 users

See Also:


Attachments
file.diff (3.00 KB, patch)
2014-02-14 02:20 UTC, Stephen R Guglielmo
no flags Details | Diff
textproc.py-feedparser.new.patch.txt (1.16 KB, text/plain; charset=US-ASCII)
2014-02-14 16:46 UTC, deleteme
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen R Guglielmo 2014-02-14 02:20:00 UTC
textproc/py-feedparser does not actually depend on textproc/py-chardet. It is optional character detection. textproc/py-chardet can be installed manually and imported to the application using the textproc/py-feedparser library if it's required.

This actually introduces a bug on python 3 which causes a "decoding str is not supported" error to pop up with certain feeds. See issue #403:
http://code.google.com/p/feedparser/issues/detail?id=403

I also made a few other changes while I was digging around:
-Rewrote pkg-descr (including a dead URL update)
-Changed MASTER_SITES
-Corrected the license from BSD to MIT
-Defined a minimum python version
-Made the DOCS option actually work by adding an if statement
-Bumped the port revision, of course.

Fix: Attached patch

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer 2014-02-14 02:20:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sbz

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter freebsd_committer 2014-05-28 23:06:58 UTC
Author: sbz
Date: Wed May 28 22:06:53 2014
New Revision: 355659
URL: http://svnweb.freebsd.org/changeset/ports/355659
QAT: https://qat.redports.org/buildarchive/r355659/

Log:
  - Update COMMENT
  - Update LICENSE
  - Update pkg-descr
  - Convert to USES=tar:bzip2
  - Remove unnecessary RUN_DEPENDS
  
  PR:		ports/186751
  Submitted by:	Stephen R Guglielmo <srg at guglielmo.us>

Modified:
  head/textproc/py-feedparser/Makefile
  head/textproc/py-feedparser/pkg-descr

Modified: head/textproc/py-feedparser/Makefile
==============================================================================
--- head/textproc/py-feedparser/Makefile	Wed May 28 21:54:01 2014	(r355658)
+++ head/textproc/py-feedparser/Makefile	Wed May 28 22:06:53 2014	(r355659)
@@ -3,20 +3,18 @@
 
 PORTNAME=	feedparser
 PORTVERSION=	5.1.3
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	textproc python
 MASTER_SITES=	CHEESESHOP
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
 
 MAINTAINER=	sbz@FreeBSD.org
-COMMENT=	RSS feed parser written in Python
+COMMENT=	Universal feed parser written in Python
 
-LICENSE=	BSD
-
-RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}chardet>0:${PORTSDIR}/textproc/py-chardet
+LICENSE=	MIT
 
+USES=		tar:bzip2
 USE_PYTHON=	yes
-USE_BZIP2=	yes
 USE_PYDISTUTILS=yes
 PYDISTUTILS_AUTOPLIST=	yes
 

Modified: head/textproc/py-feedparser/pkg-descr
==============================================================================
--- head/textproc/py-feedparser/pkg-descr	Wed May 28 21:54:01 2014	(r355658)
+++ head/textproc/py-feedparser/pkg-descr	Wed May 28 22:06:53 2014	(r355659)
@@ -1,16 +1,10 @@
-Universal Feed Parser is a Python module for downloading and parsing
-syndicated feeds. It can handle RSS 0.90, Netscape RSS 0.91, Userland
-RSS 0.91, RSS 0.92, RSS 0.93, RSS 0.94, RSS 1.0, RSS 2.0, Atom, and
-CDF feeds.
+Universal Feed Parser is a Python module for downloading and parsing syndicated
+feeds. It can handle RSS 0.90, Netscape RSS 0.91, Userland RSS 0.91, RSS 0.92,
+RSS 0.93, RSS 0.94, RSS 1.0, RSS 2.0, Atom 0.3, Atom 1.0, and CDF feeds.
 
-To use Universal Feed Parser, you will need Python 2.1 or later.
-Universal Feed Parser is not meant to run standalone; it is a module
-for you to use as part of a larger Python program.
+Universal Feed Parser is easy to use; the module is self-contained in a single
+file, feedparser.py, and it has one primary public function, parse.  parse
+takes a number of arguments, but only one is required, and it can be a URL, a
+local filename, or a raw string containing feed data in any format.
 
-Universal Feed Parser is easy to use; the module is self-contained in
-a single file, feedparser.py, and it has only one public function,
-parse.  parse takes a number of arguments, but only one is required,
-and it can be a URL, a local filename, or a raw string containing feed
-data in any format.
-
-WWW: http://feedparser.org/
+WWW: http://code.google.com/p/feedparser/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Sofian Brabez freebsd_committer 2014-05-28 23:07:16 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!