Bug 187337 - [patch] databases/memcached: install error with or without DOCS
Summary: [patch] databases/memcached: install error with or without DOCS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-07 00:40 UTC by Lawrence Chen
Modified: 2014-03-07 11:00 UTC (History)
0 users

See Also:


Attachments
patch (1.07 KB, patch)
2014-03-07 00:40 UTC, Lawrence Chen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lawrence Chen 2014-03-07 00:40:00 UTC
	Revision bump results in portmaster uninstalling memcached and failing
	to install.

Fix: This patch tries to address all the issues.
How-To-Repeat: 	

	Did portmaster -a, and now I have no memcached.

	In my make.conf on my servers, I have "OPTIONS_UNSET= DOCS", but its
	trying to install DOCS anyways.  And, even if I remove the install
	lines, it registers that it had installed the man page, which it didn't.

	Later when I updated on my workstation with default options, it also
	failed to (re)install.

	MAN1 isn't set.  post-install doesn't check DOCS option.  FILES_PLIST
	always lists the man page whether it installs or not.
Comment 1 Edwin Groothuis freebsd_committer 2014-03-07 00:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->swills

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Lawrence Chen 2014-03-07 01:14:29 UTC
On 2014-03-06 18:40, FreeBSD-gnats-submit@FreeBSD.org wrote:
> Thank you very much for your problem report.
> It has the internal identification `ports/187337'.

While the patch makes the port build and install....I found that I couldn't 
get into my email to get this reply (I use mail/roundcube and use memcached 
for caching and php sessions storage.)

Also found that memcached was consuming 100% of my CPU.

Undoing portions of the 'Enforce libevent2' patch has restored things on the 
3 systems I had updated.

-- 
   Name: Lawrence "The Dreamer" Chen    Call: W0LKC
  Snail: 1530 College Ave, A5          Email: beastie@tardisi.com
         Manhattan, KS 66502-2768       Blog: http://lawrencechen.net
Comment 3 dfilter service freebsd_committer 2014-03-07 10:56:40 UTC
Author: bapt
Date: Fri Mar  7 10:56:32 2014
New Revision: 347359
URL: http://svnweb.freebsd.org/changeset/ports/347359
QAT: https://qat.redports.org/buildarchive/r347359/

Log:
  Fix installing manpage
  Fix build with and without docs
  Fix memcached eating 100% of memory when built with both libevent2 and libevent 1.4
  installed at the same time by making sure to always find the event.h from libevent2 first
  
  PR:		ports/187337 ports/187340 ports/187309
  Reported by:	Lawrence "The Dreamer" Chen <beastie@tardisi.com>, Volodymyr Kostyrko <arcade@b1t.name>, Ross <basarevych@gmail.com>

Modified:
  head/databases/memcached/Makefile

Modified: head/databases/memcached/Makefile
==============================================================================
--- head/databases/memcached/Makefile	Fri Mar  7 10:49:36 2014	(r347358)
+++ head/databases/memcached/Makefile	Fri Mar  7 10:56:32 2014	(r347359)
@@ -3,7 +3,7 @@
 
 PORTNAME=	memcached
 PORTVERSION=	1.4.17
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	databases
 MASTER_SITES=	${MASTER_SITE_GOOGLE_CODE} \
 		${MASTER_SITE_GENTOO}
@@ -41,8 +41,8 @@ PLIST_DIRS=	include/memcached
 PORTDOCS=	protocol.txt readme.txt
 
 CFLAGS+=	-fstack-protector \
-		-I${LOCALBASE}/include \
-		-I${LOCALBASE}/include/event2/compat
+		-I${LOCALBASE}/include/event2/compat \
+		-I${LOCALBASE}/include
 
 DTRACE_COFNIGURE_ENABLE=	dtrace
 
@@ -65,17 +65,14 @@ BROKEN=			DTRACE broken with gcc/clang -
 post-patch:
 	@${REINPLACE_CMD} -e "s,-levent,-levent-2.0,g" ${WRKSRC}/configure
 
-post-configure:
-	@${REINPLACE_CMD} -e 's#doc/memcached.1##' ${WRKSRC}/Makefile
-
 post-install:
 	${INSTALL_SCRIPT} ${WRKSRC}/scripts/memcached-tool ${STAGEDIR}${PREFIX}/bin
-	${INSTALL_MAN} ${WRKSRC}/doc/${MAN1} ${STAGEDIR}${MAN1PREFIX}/man/man1
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
 .for i in ${PORTDOCS}
 	${INSTALL_DATA} ${WRKSRC}/doc/${i} ${STAGEDIR}${DOCSDIR}
 .endfor
 
+
 regression-test: test
 test: build
 	${MAKE} -C ${WRKSRC} test
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Baptiste Daroussin freebsd_committer 2014-03-07 10:57:06 UTC
State Changed
From-To: open->closed

Fixed Thanks!