GNU macchanger is a good tool because of it's mac's addresses database. The pool request https://github.com/alobbs/macchanger/pull/9 I hope patches will be accepted in new versions, for now I'd like to start by providing a working version. One feature was commented, because I don't know how to implement it now... Fix: Patch attached with submission follows:
Hi, if you are still interested in having this port in FreeBSD, it may (or may not) need to be reworked to support stage, and it may need updating to other newer conventions such as "USES" which is expanding all time. For staging, see http://lists.freebsd.org/pipermail/freebsd-ports-announce/2014-May/000080.html Additionally, you need to provide some sort of quality assurance. In order of preference, we are looking for: 1) "poudriere testport" or "poudriere bulk -t" logs 2) Redports or tinderbox logs Please provide an updated shar file and attach a test log. Alternatively, please indicate if you are no longer interested in having this software in the Ports Collection and that we can close the PR. Thanks!
port is staged, doesn't seem to have any bitrot. I does use pkg-plist for just a couple of files so that's an issue. A small fix and a test log would fast-track this.
(In reply to John Marino from comment #2) > port is staged, doesn't seem to have any bitrot. I does use pkg-plist for > just a couple of files so that's an issue. A small fix and a test log would > fast-track this. Sorry I didn't understand, why using pkg-plist for just a couple of files an issue? And what I have to do?
Created attachment 146493 [details] build log
(In reply to John Marino from comment #2) > port is staged, doesn't seem to have any bitrot. I does use pkg-plist for > just a couple of files so that's an issue. A small fix and a test log would > fast-track this. I removed one feature from the original macchanger during porting. I just don't know how to implement it on freebsd. And author doesn't want to accept my patches without complete features support.
(In reply to clutton from comment #3) > (In reply to John Marino from comment #2) > > port is staged, doesn't seem to have any bitrot. I does use pkg-plist for > > just a couple of files so that's an issue. A small fix and a test log would > > fast-track this. > > Sorry I didn't understand, why using pkg-plist for just a couple of files an > issue? And what I have to do? There is a policy that pkg-plist with 5 files or less needs to be embedded in Makefile using PLIST_FILES mechanism. Grep for PLIST_FILES for example. I don't have a reference in porter's handbook but it' probably there too.
regarding poudriere log, same comment as your other PR. You didn't use the "-t" option I don't believe.
(In reply to John Marino from comment #6) > (In reply to clutton from comment #3) > > (In reply to John Marino from comment #2) > > > port is staged, doesn't seem to have any bitrot. I does use pkg-plist for > > > just a couple of files so that's an issue. A small fix and a test log would > > > fast-track this. > > > > Sorry I didn't understand, why using pkg-plist for just a couple of files an > > issue? And what I have to do? > > > There is a policy that pkg-plist with 5 files or less needs to be embedded > in Makefile using PLIST_FILES mechanism. Grep for PLIST_FILES for example. > I don't have a reference in porter's handbook but it' probably there too. I know how to use plist from Makefile. Just didn't know about the policy... We'll do shortly.
Created attachment 146544 [details] build log
Created attachment 146545 [details] new shar
looks good, lets promote this.
(In reply to clutton from comment #9) > Created attachment 146544 [details] > build log poudriere build on 8.4 i386 fails, see http://people.freebsd.org/~pi/logs/net__macchanger-84i.txt Any ideas ?
if it works on all other platforms including 8.4 amd64, I'd just mark it IGNORE on 8.4-i386. It looks like the platform itself can't support it.
(In reply to John Marino from comment #13) > if it works on all other platforms including 8.4 amd64, I'd just mark it > IGNORE on 8.4-i386. It looks like the platform itself can't support it. It does not build on 8.4-amd64, either: http://people.freebsd.org/~pi/logs/84a-macchanger.txt
(In reply to Kurt Jaeger from comment #14) > (In reply to John Marino from comment #13) > > if it works on all other platforms including 8.4 amd64, I'd just mark it > > IGNORE on 8.4-i386. It looks like the platform itself can't support it. > > It does not build on 8.4-amd64, either: > > http://people.freebsd.org/~pi/logs/84a-macchanger.txt Since I ported this I can make it work on 8-x platform too. What I need more is implementing last feature, reverting to the original MAC address. And I don't know how to do this on FreeBSD... How can I read the factory MAC address when it was already changed?
> What I need more is implementing last feature, reverting to the original MAC > address. And I don't know how to do this on FreeBSD... > How can I read the factory MAC address when it was already changed? It's probably best to ask this on https://lists.freebsd.org/pipermail/freebsd-net/ I'll check how to IGNORE on 8.x in the meantime.
(In reply to Kurt Jaeger from comment #16) > > What I need more is implementing last feature, reverting to the original MAC > > address. And I don't know how to do this on FreeBSD... > > How can I read the factory MAC address when it was already changed? > > It's probably best to ask this on > > https://lists.freebsd.org/pipermail/freebsd-net/ > > I'll check how to IGNORE on 8.x in the meantime. Wait, may be it's better to deliver the whole thing...
Hi, Finding out the original MAC (ethtool style) can be done using: sysctl dev.XX.Y.nvm=1 (e.g sysctl dev.em.0.nvm=1) sysctl dev.XX.Y.debug=1 (older FreeBSD releases) Output in dmesg, or syslog contains the original MAC, at offset 0x0000. (In reply to clutton from comment #17) > (In reply to Kurt Jaeger from comment #16) > > > What I need more is implementing last feature, reverting to the original MAC > > > address. And I don't know how to do this on FreeBSD... > > > How can I read the factory MAC address when it was already changed? > > > > It's probably best to ask this on > > > > https://lists.freebsd.org/pipermail/freebsd-net/ > > > > I'll check how to IGNORE on 8.x in the meantime. > > Wait, may be it's better to deliver the whole thing...
(In reply to John Ten from comment #18) > Hi, > > Finding out the original MAC (ethtool style) can be done using: > > sysctl dev.XX.Y.nvm=1 (e.g sysctl dev.em.0.nvm=1) > sysctl dev.XX.Y.debug=1 (older FreeBSD releases) > > Output in dmesg, or syslog contains the original MAC, at offset 0x0000. > > > (In reply to clutton from comment #17) > > (In reply to Kurt Jaeger from comment #16) > > > > What I need more is implementing last feature, reverting to the original MAC > > > > address. And I don't know how to do this on FreeBSD... > > > > How can I read the factory MAC address when it was already changed? > > > > > > It's probably best to ask this on > > > > > > https://lists.freebsd.org/pipermail/freebsd-net/ > > > > > > I'll check how to IGNORE on 8.x in the meantime. > > > > Wait, may be it's better to deliver the whole thing... I see, thank you very much! I'll find some time soon to finish it.
(In reply to John Ten from comment #18) > Hi, > > Finding out the original MAC (ethtool style) can be done using: > > sysctl dev.XX.Y.nvm=1 (e.g sysctl dev.em.0.nvm=1) > sysctl dev.XX.Y.debug=1 (older FreeBSD releases) > > Output in dmesg, or syslog contains the original MAC, at offset 0x0000. > > > (In reply to clutton from comment #17) > > (In reply to Kurt Jaeger from comment #16) > > > > What I need more is implementing last feature, reverting to the original MAC > > > > address. And I don't know how to do this on FreeBSD... > > > > How can I read the factory MAC address when it was already changed? > > > > > > It's probably best to ask this on > > > > > > https://lists.freebsd.org/pipermail/freebsd-net/ > > > > > > I'll check how to IGNORE on 8.x in the meantime. > > > > Wait, may be it's better to deliver the whole thing... Apparently it works only for 3 drivers, em, and two others. Nevertheless thank you for your response.
(In reply to Kurt Jaeger from comment #12) > (In reply to clutton from comment #9) > > Created attachment 146544 [details] > > build log > > poudriere build on 8.4 i386 fails, see > > http://people.freebsd.org/~pi/logs/net__macchanger-84i.txt > > Any ideas ? It seems 8.4 platform can't see the #include <config> from poudriere... Somehow it can't see the AF_PACKET declaration from config.h, which was successfully declared. Before I'll dig further, could you please try not to use poudriere? Just 8x. Unfortunately I don't have 8, only CURRENT and 10... New version attached...
Created attachment 148455 [details] 1.7.0 version
> It seems 8.4 platform can't see the #include <config> from poudriere... > Somehow it can't see the AF_PACKET declaration from config.h, which was > successfully declared. > > Before I'll dig further, could you please try not to use poudriere? Just 8x. > Unfortunately I don't have 8, only CURRENT and 10... I've tried it on some 8.4p7-amd64 host, see http://people.freebsd.org/logs/macchanger-84amd.txt It has issues...
You probably means : https://people.freebsd.org/~pi/logs/macchanger-84amd.txt
(In reply to Rodrigo Osorio from comment #24) > You probably means : > https://people.freebsd.org/~pi/logs/macchanger-84amd.txt Yes 8-) sorry, typo...
(In reply to Kurt Jaeger from comment #25) > (In reply to Rodrigo Osorio from comment #24) > > You probably means : > > https://people.freebsd.org/~pi/logs/macchanger-84amd.txt > > Yes 8-) sorry, typo... Don't use autogen.sh, at least run «make configure» from ports, at most don't do anything you are not supposed to do as a port user :). It seems you've missed «make patch» step.
Hi! > Don't use autogen.sh, at least run «make configure» from ports, at most > don't do anything you are not supposed to do as a port user :). It seems > you've missed «make patch» step. The host I tested it is a production host, I'm not going to update the ports infrastructure on that for the sake of tests 8-}
(In reply to Kurt Jaeger from comment #27) > Hi! > > > Don't use autogen.sh, at least run «make configure» from ports, at most > > don't do anything you are not supposed to do as a port user :). It seems > > you've missed «make patch» step. > > The host I tested it is a production host, I'm not going to update the ports > infrastructure on that for the sake of tests 8-} You don't have to update your ports. Looking at your log https://people.freebsd.org/~pi/logs/macchanger-84amd.txt I can see that the make patch and/or make configure steps were missing. Just go to the port directory and type make. It will do the make patch step, and then the building step. Do not go to workdir, do not run any scripts from workdir. Having any difficulties contact me by email.
Created attachment 148556 [details] 8.x fix I wouldn't attach logs for every single jail build, because there are a plenty of them head, 10, 9, 8, 386/64. If you need them I will.
A commit references this bug: Author: pi Date: Wed Oct 22 05:34:36 UTC 2014 New revision: 371342 URL: https://svnweb.freebsd.org/changeset/ports/371342 Log: New port: net/macchanger GNU MAC Changer is an utility that makes the maniputation of MAC addresses of network interfaces easier. WWW: http://www.gnu.org/software/macchanger PR: 187363 Submitted by: clutton@zoho.com Changes: head/net/macchanger/ head/net/macchanger/Makefile head/net/macchanger/distinfo head/net/macchanger/files/ head/net/macchanger/files/patch-configure.ac head/net/macchanger/files/patch-src_main.c head/net/macchanger/files/patch-src_netinfo.c head/net/macchanger/pkg-descr
A commit references this bug: Author: pi Date: Wed Oct 22 05:35:18 UTC 2014 New revision: 371343 URL: https://svnweb.freebsd.org/changeset/ports/371343 Log: net/macchanger: Add to the build PR: 187363 Pointy hat to: myself Changes: head/net/Makefile
Committed, thanks. rodrigo: sorry, I missed that the PR was assigned to you 8-( To the submitter: Can you try to push your patches upstream ? And maybe provide a man page ? Thanks!
(In reply to Kurt Jaeger from comment #32) > Committed, thanks. rodrigo: sorry, I missed that the PR was assigned to you > 8-( > > To the submitter: Can you try to push your patches upstream ? And maybe > provide a man page ? Thanks! manpage is here. man 1 macchanger, but unfortunately the section about permanent address doesn't work in FreeBSD case, should I remove that section from man and info pages? I've just realized this inconsistency, the code is cleaned well, I mean --help and etc. But docs still has this feature. About pushing upstream, it's not complete porting, one feature was removed, and author didn't like that.
> > To the submitter: Can you try to push your patches upstream ? And maybe > > provide a man page ? Thanks! > manpage is here. man 1 macchanger, but unfortunately the section about > permanent address doesn't work in FreeBSD case, should I remove that section > from man and info pages? If you mark it as "does not work on fbsd", that would be appropriate, yes. > I've just realized this inconsistency, the code is > cleaned well, I mean --help and etc. But docs still has this feature. > > About pushing upstream, it's not complete porting, one feature was removed, > and author didn't like that. Which feature was removed and why didn't he like it ?
Created attachment 148653 [details] info patch
Created attachment 148654 [details] man patch
(In reply to Kurt Jaeger from comment #34) > > > To the submitter: Can you try to push your patches upstream ? And maybe > > > provide a man page ? Thanks! > > > manpage is here. man 1 macchanger, but unfortunately the section about > > permanent address doesn't work in FreeBSD case, should I remove that section > > from man and info pages? > > If you mark it as "does not work on fbsd", that would be appropriate, yes. > > > I've just realized this inconsistency, the code is > > cleaned well, I mean --help and etc. But docs still has this feature. > > > > About pushing upstream, it's not complete porting, one feature was removed, > > and author didn't like that. > > Which feature was removed and why didn't he like it ? Two patches submitted, put them into net/macchanger/files directory. Removed feature was reset to permanent mac address. Why he didn't like it? He wanted full port, and then stop responding.
A commit references this bug: Author: pi Date: Sun Oct 26 18:20:08 UTC 2014 New revision: 371520 URL: https://svnweb.freebsd.org/changeset/ports/371520 Log: net/macchanger: fix man page, info file to reflect change to program PR: 187363 Submitted by: clutton@zoho.com (maintainer) Changes: head/net/macchanger/Makefile head/net/macchanger/files/patch-doc-macchanger.texi head/net/macchanger/files/patch-macchanger.1
Committed, thanks!