Bug 187490 - mail/vacation: Update by MAINTAINER for Portscout
Summary: mail/vacation: Update by MAINTAINER for Portscout
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-12 17:40 UTC by Adam McDougall
Modified: 2014-08-12 10:25 UTC (History)
1 user (show)

See Also:


Attachments
Avoid portscout warnings (1.02 KB, patch)
2014-08-12 01:07 UTC, Adam McDougall
ebay: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam McDougall 2014-03-12 17:40:00 UTC
The variant of 'vacation' installed by this port was cobbled together from sendmail and a handful of other OSes and has not had a new release in many years, nor do I expect it to have or need one.  This variant is considered a native Debian package where it is hosted by Debian without an upstream, and the only changes to the distfile are small tweaks specific to Debian.  I would like a committer to set:

PORTSCOUT=    ignore:1

or whatever necessary to ignore minor updates to the base version number of 3.3.0, such as vacation_3.3.0-0.4.tar.gz.  It could potentially use a regex, but I don't know what version scheme might be used next, if an update ever happened.  
I am open to smart ways to ignore 3.3.0(.*) as opposed to all new versions.  I still require this software on a daily basis so the port should be kept.  Thanks.

Fix: 

PORTSCOUT=    ignore:1
Comment 1 Adam McDougall 2014-03-12 19:40:00 UTC
I left out a couple things by accident.

1.  This is for the mail/vacation port

2.  The current distfile is not fetchable on many mirrors;
    I suggest modifying DISTNAME as so:

DISTNAME=       ${PORTNAME}_${PORTVERSION}-0.4

I see no reason to cause a rebuild by modifying PORTVERSION since from the
FreeBSD perspective, it is just a tarball re-roll.  On the other hand it is
very small.  I verified the differences were only debian metadata between
the two.

It will require a new distinfo:

SHA256 (vacation_3.3.0-0.4.tar.gz) = 086a3dfde953aa5247a5389fa17f1f77312acd54e3cc74a0369eb363c798b567
SIZE (vacation_3.3.0-0.4.tar.gz) = 11473
Comment 2 Mark Linimon 2014-03-12 21:54:16 UTC
to which port does this PR apply?

mcl
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-12 21:56:45 UTC
Class Changed
From-To: change-request->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 4 Adam McDougall 2014-03-12 23:16:38 UTC
On 03/12/2014 17:54, Mark Linimon wrote:
> to which port does this PR apply?
> 
> mcl
> 

Sorry I forgot to put that in the Synopsis, it is for mail/vacation.
The PR has been updated with more information and some additional
changes.  Thanks.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-06-29 15:21:29 UTC
i suggest you attach a proper patch.
If you do that, I'll commit it for you.
Comment 6 John Marino freebsd_committer freebsd_triage 2014-07-26 13:51:38 UTC
no patch was provided.
Comment 7 Adam McDougall 2014-08-12 01:07:49 UTC
Created attachment 145691 [details]
Avoid portscout warnings
Comment 8 Adam McDougall 2014-08-12 01:09:08 UTC
I am extremely sorry for letting this lapse.  I really appreciate your offer and I hope my attached patch can be committed or reviewed if insufficient.  Thank you.
Comment 9 John Marino freebsd_committer freebsd_triage 2014-08-12 10:17:22 UTC
FYI, this needs a portrevision bump, it's changing the package.
Comment 10 commit-hook freebsd_committer freebsd_triage 2014-08-12 10:25:08 UTC
A commit references this bug:

Author: marino
Date: Tue Aug 12 10:24:54 UTC 2014
New revision: 364690
URL: http://svnweb.freebsd.org/changeset/ports/364690

Log:
  mail/vacation: set PORTSCOUT to ignore, switch tarballs

  There are only minor metadifferences between the new and old tarball,
  but bump portrevision anyway.  PortScout needs to stop looking for updates
  because they won't come and anything it finds will be a false positive.

  PR:		187490
  Submitted by:	maintainer (Adam McDougall)

Changes:
  head/mail/vacation/Makefile
  head/mail/vacation/distinfo
Comment 11 John Marino freebsd_committer freebsd_triage 2014-08-12 10:25:51 UTC
Okay, it's in.  Thanks!