Bug 187666 - databases/py-MySQLdb: SSL support broken
Summary: databases/py-MySQLdb: SSL support broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-python mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-17 17:20 UTC by Michael Gmelin
Modified: 2014-03-18 15:20 UTC (History)
0 users

See Also:


Attachments
file.diff (449 bytes, patch)
2014-03-17 17:20 UTC, Michael Gmelin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gmelin 2014-03-17 17:20:00 UTC
Due to "HAVE_OPENSSL" no longer being emitted by mysql-config, py-MySQLdb and all the version specific ports (py-MySQLdb55 etc.) don't support SSL anymore, even though the underlying mysql client library does support it.

The attached patch to _mysql.c fixes this (this should go to files etc., I'm in quite a hurry, so this is really only the patch itself, not a patch for the port skeleton).

It has been taken from upstream:
http://sourceforge.net/p/mysql-python/svn/656/

Fix: Attached patch.

Patch attached with submission follows:
How-To-Repeat: Install and connect to mysql using ssl.
Comment 1 Edwin Groothuis freebsd_committer 2014-03-17 17:20:04 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-python

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2014-03-18 15:10:49 UTC
Author: demon
Date: Tue Mar 18 15:10:46 2014
New Revision: 348573
URL: http://svnweb.freebsd.org/changeset/ports/348573
QAT: https://qat.redports.org/buildarchive/r348573/

Log:
  Fix SSL support.
  
  PR:		187666
  Submitted by:	Michael Gmelin <freebsd@grem.de>

Added:
  head/databases/py-MySQLdb/files/
  head/databases/py-MySQLdb/files/patch-_mysql.c   (contents, props changed)
Modified:
  head/databases/py-MySQLdb/Makefile

Modified: head/databases/py-MySQLdb/Makefile
==============================================================================
--- head/databases/py-MySQLdb/Makefile	Tue Mar 18 15:10:20 2014	(r348572)
+++ head/databases/py-MySQLdb/Makefile	Tue Mar 18 15:10:46 2014	(r348573)
@@ -3,7 +3,7 @@
 
 PORTNAME=	MySQLdb
 DISTVERSION=	1.2.3
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	databases python
 MASTER_SITES=	SF/mysql-python/mysql-python/${PORTVERSION}
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}

Added: head/databases/py-MySQLdb/files/patch-_mysql.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/databases/py-MySQLdb/files/patch-_mysql.c	Tue Mar 18 15:10:46 2014	(r348573)
@@ -0,0 +1,13 @@
+--- _mysql.c.orig	2014-03-18 19:07:07.000000000 +0400
++++ _mysql.c	2014-03-18 19:07:40.000000000 +0400
+@@ -102,6 +102,10 @@ static int _mysql_server_init_done = 0;
+ #define check_server_init(x) if (!_mysql_server_init_done) _mysql_server_init_done = 1
+ #endif
+ 
++#if MYSQL_VERSION_ID >= 50500
++#define HAVE_OPENSSL 1
++#endif
++
+ PyObject *
+ _mysql_Exception(_mysql_ConnectionObject *c)
+ {
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Dmitry Sivachenko freebsd_committer 2014-03-18 15:10:53 UTC
State Changed
From-To: open->closed

Patch committed, thanks!