Bug 187801 - [patch] science/mpqc: support LDFLAGS (fixes libghemical)
Summary: [patch] science/mpqc: support LDFLAGS (fixes libghemical)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Maho Nakata
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-20 22:40 UTC by Tijl Coosemans
Modified: 2014-05-30 18:53 UTC (History)
0 users

See Also:


Attachments
mpqc.patch (2.13 KB, patch)
2014-03-20 22:40 UTC, Tijl Coosemans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer freebsd_triage 2014-03-20 22:40:00 UTC
The attached patch makes the port use LDFLAGS from Mk/Uses/fortran.mk
such that the libraries and executables are linked with the runtime
libraries from lang/gcc instead of the base system.

This fixes this build error in libghemical:
http://beefy2.isc.freebsd.org/bulk/91amd64-default/2014-03-19_18h55m31s/logs/errors/libghemical-3.0.0_2.log

Tested on redports:
mpqc: https://redports.org/buildarchive/20140320200601-29431/
mpqc-mpich: https://redports.org/buildarchive/20140320202454-12424/
libghemical: https://redports.org/buildarchive/20140320202534-78415/
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-03-20 22:40:04 UTC
Responsible Changed
From-To: freebsd-ports-bugs->maho

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-03-25 06:30:24 UTC
Author: maho
Date: Tue Mar 25 06:30:21 2014
New Revision: 349105
URL: http://svnweb.freebsd.org/changeset/ports/349105
QAT: https://qat.redports.org/buildarchive/r349105/

Log:
  support LDFLAGS (fixes libghemical)
  
  PR:		187801
  Submitted by:	tijl@

Modified:
  head/science/mpqc/Makefile
  head/science/mpqc/files/patch-LocalMakefile.in

Modified: head/science/mpqc/Makefile
==============================================================================
--- head/science/mpqc/Makefile	Tue Mar 25 06:26:16 2014	(r349104)
+++ head/science/mpqc/Makefile	Tue Mar 25 06:30:21 2014	(r349105)
@@ -3,7 +3,7 @@
 
 PORTNAME=	mpqc
 PORTVERSION=	2.3.1
-PORTREVISION=	18
+PORTREVISION=	19
 CATEGORIES=	science parallel
 MASTER_SITES=	SF
 
@@ -59,7 +59,8 @@ CXXFLAGS=	-O3 -tpp7 -xMKW -Vaxlib
 CONFIGURE_ARGS+=--with-cc=${CC} \
 		--with-cxx=${CXX} \
 		--with-f77=${FC} \
-		--with-libdirs=-L${LOCALBASE}/lib \
+		--with-include="-I${WRKDIR} -I${LOCALBASE}/include" \
+		--with-libdirs="-L${LOCALBASE}/lib ${LDFLAGS}" \
 		--with-blas="${BLAS}" \
 		--with-lapack="${LAPACK}" \
 		--with-coptflags="${CFLAGS}" \
@@ -71,15 +72,9 @@ CONFIGURE_ARGS+=--with-cc=${CC} \
 CONFIGURE_ARGS+=--with-libs="-lsvml"
 .endif
 .if defined(WITH_MPICH)
-CONFIGURE_ARGS+=--with-libdirs="-L${LOCALBASE}/lib -L${LOCALBASE}/lib"\
-		--enable-always-use-mpi
+CONFIGURE_ARGS+=--enable-always-use-mpi
 CONFIGURE_ENV+=	PTHREAD_LIBS="${PTHREAD_LIBS}"
 .endif
-.if defined(WITH_MPICH)
-CONFIGURE_ARGS+=--with-include="-I${LOCALBASE}/include -I${WRKDIR} -I${LOCALBASE}/include"
-.else
-CONFIGURE_ARGS+=--with-include="-I${WRKDIR} -I${LOCALBASE}/include"
-.endif
 
 MPQC_COMMAND=	${PREFIX}/bin/mpqc
 

Modified: head/science/mpqc/files/patch-LocalMakefile.in
==============================================================================
--- head/science/mpqc/files/patch-LocalMakefile.in	Tue Mar 25 06:26:16 2014	(r349104)
+++ head/science/mpqc/files/patch-LocalMakefile.in	Tue Mar 25 06:30:21 2014	(r349105)
@@ -5,10 +5,10 @@
    LTLINK = $(LIBTOOL) --mode=link
    ifneq ($(BUILDID),)
 -    LTLINKLIBOPTS = -rpath $(libdir) -release $(BUILDID) -version-info $(SC_SO_VERSION)
-+    LTLINKLIBOPTS = %%EXTRARPATH%% -rpath $(libdir) -release $(BUILDID) -version-info $(SC_SO_VERSION)
++    LTLINKLIBOPTS = $(LDFLAGS) -rpath $(libdir) -release $(BUILDID) -version-info $(SC_SO_VERSION)
    else
 -    LTLINKLIBOPTS = -rpath $(libdir) -version-info $(SC_SO_VERSION)
-+    LTLINKLIBOPTS = %%EXTRARPATH%% -rpath $(libdir) -version-info $(SC_SO_VERSION)
++    LTLINKLIBOPTS = $(LDFLAGS) -rpath $(libdir) -version-info $(SC_SO_VERSION)
    endif
    LTLINKBINOPTS =
    LTCOMP = $(LIBTOOL) --mode=compile
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2014-05-30 18:52:41 UTC
State Changed
From-To: open->closed

Committed in r349105.