Bug 187847 - news/slrn self encoding tool does not match the right charset.
Summary: news/slrn self encoding tool does not match the right charset.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Johan van Selst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-23 09:00 UTC by David Marec
Modified: 2014-03-26 19:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Marec 2014-03-23 09:00:01 UTC
To avoid posting messages in UTF-8 when it is not needed, the following rule
is defined in the slrn resource file:

-- 
charset outgoing "us-ascii,iso-8859-1,iso-8859-15,utf-8"
--

This means that slrn  will 'try the settings from left to right and use the
first for which encoding succeeds'.

Since iconv was moved to the base system, this self-encoding-selector does not work anymore.

Fix: 

Adds the "--with-non-gnu-iconv" magic flag to tell to slrn that it deals not with the gnu iconv, to the make file:


CONFIGURE_ARGS+=--enable-ipv6 --disable-inews --with-slrnpull \
	--with-non-gnu-iconv ${ICONV_CONFIGURE_ARG}
How-To-Repeat: Use the following charset selection rule in your "slrnrc" file:

  charset outgoing "us-ascii,iso-8859-1,iso-8859-15,utf-8"

and try to post messages filled with non-ascii characters.
Comment 1 Edwin Groothuis freebsd_committer 2014-03-23 15:42:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->johans

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2014-03-26 18:54:59 UTC
Author: johans
Date: Wed Mar 26 18:54:55 2014
New Revision: 349278
URL: http://svnweb.freebsd.org/changeset/ports/349278
QAT: https://qat.redports.org/buildarchive/r349278/

Log:
  Fix character set selection that was broken with iconv from base
  
  PR:		ports/187847
  Submitted by:	David Marec <david.marec@davenulle.org>

Modified:
  head/news/slrn/Makefile

Modified: head/news/slrn/Makefile
==============================================================================
--- head/news/slrn/Makefile	Wed Mar 26 18:52:27 2014	(r349277)
+++ head/news/slrn/Makefile	Wed Mar 26 18:54:55 2014	(r349278)
@@ -3,6 +3,7 @@
 
 PORTNAME=	slrn
 PORTVERSION=	1.0.1
+PORTREVISION=	1
 CATEGORIES=	news ipv6
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME} \
 		http://www.jedsoft.org/slrn/download/
@@ -18,7 +19,7 @@ USES=		gmake iconv
 
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS+=--enable-ipv6 --disable-inews --with-slrnpull \
-		${ICONV_CONFIGURE_ARG}
+		--with-non-gnu-iconv ${ICONV_CONFIGURE_ARG}
 
 ALL_TARGET=	all
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Johan van Selst freebsd_committer 2014-03-26 18:55:09 UTC
State Changed
From-To: open->closed

Committed, thanks.