Bug 187914 - [patch] make www/owncloud optional dependencies optional
Summary: [patch] make www/owncloud optional dependencies optional
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kevin Lo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-25 02:10 UTC by Adam Weinberger
Modified: 2014-04-25 00:50 UTC (History)
0 users

See Also:


Attachments
owncloud.patch (1.25 KB, patch)
2014-03-25 02:10 UTC, Adam Weinberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer 2014-03-25 02:10:00 UTC
Some of the optional dependencies for www/owncloud that are hardcoded
are by no means lightweight... mp3info and php5-ldap especially. They
are not necessary for running owncloud and are easily placed behind
some OPTIONS.

The attached patch turns some of these things into OPTIONS, and defaults
them to ON so that the net sum for packaging is still the same.
Comment 1 Edwin Groothuis freebsd_committer 2014-03-25 02:10:04 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kevlo

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer 2014-04-25 00:43:27 UTC
Author: adamw
Date: Thu Apr 24 23:43:22 2014
New Revision: 352080
URL: http://svnweb.freebsd.org/changeset/ports/352080
QAT: https://qat.redports.org/buildarchive/r352080/

Log:
  Make owncloud's dependencies a little more lightweight. mp3info
  and php-ldap are optional, but bring in a lot of other stuff.
  Turn them, along with php-exif and php-ssl, into OPTIONS. Default
  them to ON, so the default package will be unchanged. No PORTREVISION
  bump.
  
  PR:		ports/187914
  Approved by:	maintainer timeout (1 month)

Modified:
  head/www/owncloud/Makefile

Modified: head/www/owncloud/Makefile
==============================================================================
--- head/www/owncloud/Makefile	Thu Apr 24 23:34:39 2014	(r352079)
+++ head/www/owncloud/Makefile	Thu Apr 24 23:43:22 2014	(r352080)
@@ -11,12 +11,9 @@ COMMENT=	Personal cloud which runs on yo
 
 LICENSE=	AGPLv3
 
-BUILD_DEPENDS=	mp3info:${PORTSDIR}/audio/mp3info
-RUN_DEPENDS:=	${BUILD_DEPENDS}
-
 USE_BZIP2=	yes
-USE_PHP=	bz2 ctype curl dom exif fileinfo filter gd hash iconv json \
-		ldap mbstring openssl pdo session simplexml xml xmlreader \
+USE_PHP=	bz2 ctype curl dom fileinfo filter gd hash iconv json \
+		mbstring pdo session simplexml xml xmlreader \
 		xsl wddx zip zlib
 WANT_PHP_WEB=	yes
 
@@ -29,12 +26,22 @@ SUB_FILES=	pkg-message
 PLIST_SUB=	OWNCLOUD_USERNAME=${OWNCLOUD_USERNAME} \
 		OWNCLOUD_GROUPNAME=${OWNCLOUD_GROUPNAME}
 
+OPTIONS_DEFINE=	EXIF LDAP MP3INFO SSL
 OPTIONS_MULTI=	DB
 OPTIONS_MULTI_DB=	MYSQL PGSQL SQLITE
-OPTIONS_DEFAULT=	SQLITE
+OPTIONS_DEFAULT=	EXIF LDAP MP3INFO SQLITE SSL
+
+EXIF_DESC=	Image rotation support
+MP3INFO_DESC=	MP3 ID3 tags support
+
+EXIF_USE=	PHP=exif
+LDAP_USE=	PHP=ldap
+MP3INFO_BUILD_DEPENDS=	mp3info:${PORTSDIR}/audio/mp3info
+MP3INFO_RUN_DEPENDS=	${MP3INFO_BUILD_DEPENDS}
 MYSQL_USE=	MYSQL=client PHP=mysql,pdo_mysql
 PGSQL_USE=	PGSQL=yes PHP=pdo_pgsql,pgsql
 SQLITE_USE=	PHP=pdo_sqlite,sqlite3
+SSL_USE=	PHP=openssl
 
 do-install:
 	@${MKDIR} -m 0755 ${STAGEDIR}${WWWDIR}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Adam Weinberger freebsd_committer 2014-04-25 00:43:42 UTC
State Changed
From-To: open->closed

I took your silence as approval and committed this patch.