Bug 187965 - [acpi] [patch] Intel Baytrail-M NUC panics because of buggy ACPI table
Summary: [acpi] [patch] Intel Baytrail-M NUC panics because of buggy ACPI table
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: Takanori Watanabe
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-26 18:00 UTC by Takuya ASADA
Modified: 2018-10-04 00:43 UTC (History)
1 user (show)

See Also:
bugmeister: mfc-stable10?
bugmeister: mfc-stable9?
bugmeister: mfc-stable8?

Attachments
file.diff (1.55 KB, patch)
2014-03-26 18:00 UTC, Takuya ASADA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Takuya ASADA freebsd_committer freebsd_triage 2014-03-26 18:00:00 UTC 
Intel Baytrail-M NUC(DN2820FYKH) does not able to boot FreeBSD-CURRENT/amd64, because of its buggy ACPI table.

It has two incorrect parameters on MADT: 

Type=Local APIC NMI
ACPI CPU=1
LINT Pin=60
Flags={Polarity=active-hi, Trigger=0x2} <-- trigger value is incorrect. 2 is reserved

Type=Local APIC NMI
ACPI CPU=2
LINT Pin=61
Flags={Polarity=0x2, Trigger=level} <-- polarity value is incorrect. 2 is reserved

Because of this, interrupt_trigger() panics with "Bogus Interrupt Trigger Mode".
Also interrupt_polarity() panics with "Bogus Interrupt Polarity".

I think this is BIOS bug, but we can do some workaround for the machine.

Fix: Linux uses level trigger and low polarity if the value is 0x2(reserved).
http://lxr.linux.no/linux+v3.13.5/arch/x86/kernel/acpi/boot.c#L1094

We can do similar workaround, but with warning message.
Patch is attached.

Patch attached with submission follows:
How-To-Repeat: Boot -CURRENT on NUC.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-04-20 02:48:45 UTC 
State Changed
From-To: open->open
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2014-04-20 02:48:45 UTC 
Responsible Changed
From-To: freebsd-amd64->freebsd-acpi
Comment 3 John Baldwin freebsd_committer freebsd_triage 2014-04-21 19:28:02 UTC 
State Changed
From-To: open->patched

This was fixed in HEAD in r263795 and r263859.
Comment 4 John Baldwin freebsd_committer freebsd_triage 2014-04-21 19:28:02 UTC 
Responsible Changed
From-To: freebsd-acpi->takawata

This was fixed in HEAD in r263795 and r263859.
Comment 5 Ed Maste freebsd_committer freebsd_triage 2018-10-04 00:43:39 UTC 
Reported fixed