Bug 188068 - [PATCH] mail/milter-bogom for staging
Summary: [PATCH] mail/milter-bogom for staging
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-30 08:20 UTC by dirk.meyer
Modified: 2014-04-15 11:11 UTC (History)
0 users

See Also:


Attachments
file.diff (1.57 KB, patch)
2014-03-30 08:20 UTC, dirk.meyer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dirk.meyer 2014-03-30 08:20:00 UTC
	convert port to staging
	undo silent install
	drop MAN8PREFIX, which fails on custom PREFIX
	add trailing / to install for robustness

Fix: apply patch:
Comment 1 Edwin Groothuis freebsd_committer 2014-03-30 08:20:03 UTC
Maintainer of mail/milter-bogom,

Please note that PR ports/188068 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/188068

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer 2014-03-30 08:20:04 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Dirk Meyer freebsd_committer 2014-03-30 09:59:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

I will take care of it.
Comment 4 dfilter service freebsd_committer 2014-04-15 10:05:51 UTC
Author: dinoex
Date: Tue Apr 15 09:05:47 2014
New Revision: 351315
URL: http://svnweb.freebsd.org/changeset/ports/351315
QAT: https://qat.redports.org/buildarchive/r351315/

Log:
  - use STAGEDIR
  - drop MAN8PREFIX
  - undo silent install
  - robust INSTALL
  PR:		188068
  Approved by:	(Maintainer Timeout)

Modified:
  head/mail/milter-bogom/Makefile

Modified: head/mail/milter-bogom/Makefile
==============================================================================
--- head/mail/milter-bogom/Makefile	Tue Apr 15 08:55:52 2014	(r351314)
+++ head/mail/milter-bogom/Makefile	Tue Apr 15 09:05:47 2014	(r351315)
@@ -14,8 +14,6 @@ COMMENT=	Simple sendmail milter to inter
 
 RUN_DEPENDS=	bogofilter:${PORTSDIR}/mail/bogofilter
 
-MAN8=		bogom.8
-
 MAKE_ARGS=	CPPFLAGS="-DDEF_CONF=\\\"${PREFIX}/etc/bogom.conf\\\" ${PTHREAD_CFLAGS}" \
 		LIBS="-lmilter ${PTHREAD_LIBS}"
 
@@ -23,31 +21,30 @@ USE_RC_SUBR=	milter-bogom
 SUB_FILES=	pkg-message
 
 PLIST_FILES=	sbin/bogom \
+		man/man8/bogom.8.gz \
 		etc/bogom.conf-example
 
 PORTDOCS=	README CHANGELOG
 
-NO_STAGE=	yes
+.include <bsd.port.options.mk>
+
 post-patch:
-	@${REINPLACE_CMD} -e 's|/etc|${PREFIX}/etc|g' ${WRKSRC}/bogom.8
-	@${REINPLACE_CMD} -e \
+	${REINPLACE_CMD} -e 's|/etc|${PREFIX}/etc|g' ${WRKSRC}/bogom.8
+	${REINPLACE_CMD} -e \
 		's|/usr/local/bin/bogofilter|${LOCALBASE}/bin/bogofilter|g' \
 		${WRKSRC}/bogom.8 \
 		${WRKSRC}/bogom.conf-example \
 		${WRKSRC}/milter.c
 
 do-install:
-	@${INSTALL_PROGRAM} ${WRKSRC}/bogom ${PREFIX}/sbin
-	@${INSTALL_MAN} ${WRKSRC}/bogom.8 ${MAN8PREFIX}/man/man8
-	@${INSTALL_DATA} ${WRKSRC}/bogom.conf-example ${PREFIX}/etc
-.if !defined(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
+	${INSTALL_PROGRAM} ${WRKSRC}/bogom ${STAGEDIR}${PREFIX}/sbin/
+	${INSTALL_MAN} ${WRKSRC}/bogom.8 ${STAGEDIR}${PREFIX}/man/man8/
+	${INSTALL_DATA} ${WRKSRC}/bogom.conf-example ${STAGEDIR}${PREFIX}/etc/
+.if ${PORT_OPTIONS:MDOCS}
+	${MKDIR} ${STAGEDIR}${DOCSDIR}
 .for f in ${PORTDOCS}
-	@${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
+	${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}${DOCSDIR}/
 .endfor
 .endif
 
-post-install:
-	@${CAT} ${PKGMESSAGE}
-
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Dirk Meyer freebsd_committer 2014-04-15 11:11:30 UTC
State Changed
From-To: feedback->closed

committed.