Bug 188387 - fix build: textproc/htmlc
Summary: fix build: textproc/htmlc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-09 04:10 UTC by Timothy Beyer
Modified: 2014-04-20 20:10 UTC (History)
1 user (show)

See Also:


Attachments
htmlc.diff (787 bytes, patch)
2014-04-09 04:10 UTC, Timothy Beyer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Beyer 2014-04-09 04:10:00 UTC
- turn off warnings as errors flag (-warn-error A) (extraneous variables), which fixes the build for newer versions of ocamlc.

- Add license file support (license is a custom Inria license)

Fix: The included patch
How-To-Repeat: 
    Apply patch and build port
Comment 1 dfilter service freebsd_committer 2014-04-20 19:56:11 UTC
Author: antoine
Date: Sun Apr 20 18:56:07 2014
New Revision: 351628
URL: http://svnweb.freebsd.org/changeset/ports/351628
QAT: https://qat.redports.org/buildarchive/r351628/

Log:
  Fix build
  
  PR:		ports/188387
  Submitted by:	maintainer
  Reported by:	pkg-fallout

Modified:
  head/textproc/htmlc/Makefile

Modified: head/textproc/htmlc/Makefile
==============================================================================
--- head/textproc/htmlc/Makefile	Sun Apr 20 18:11:41 2014	(r351627)
+++ head/textproc/htmlc/Makefile	Sun Apr 20 18:56:07 2014	(r351628)
@@ -6,14 +6,13 @@ PORTVERSION=	2.21.0
 CATEGORIES=	textproc
 MASTER_SITES=	http://htmlc.inria.fr/ \
 		http://caml.inria.fr/distrib/bazar-ocaml/htmlc/
-EXTRACT_SUFX=	.tgz
 
 MAINTAINER=	beyert@cs.ucr.edu
-COMMENT=	A text file generator
+COMMENT=	Text file generator
 
 BUILD_DEPENDS=	ocamlc:${PORTSDIR}/lang/ocaml
 
-USES=	gmake
+USES=		gmake tar:tgz
 
 PLIST_FILES=	bin/htmlc bin/htmlc.byt share/htmlc/env
 PLIST_DIRS=	share/htmlc
@@ -23,12 +22,11 @@ PORTDOCS=	LICENSE INSTALL README JoeCaml
 HAS_CONFIGURE=	yes
 CONFIGURE_ARGS=	--prefix ${LOCALBASE}
 
-.include <bsd.port.pre.mk>
-
 post-patch:
 	${RM} -f ${WRKSRC}/doc/Makefile
 	${TOUCH} ${WRKSRC}/doc/Makefile
 	${ECHO} "all:" > ${WRKSRC}/doc/Makefile
+	${REINPLACE_CMD} 's|-warn-error A||g' ${WRKSRC}/config/Makefile
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/compiler/htmlc ${STAGEDIR}${PREFIX}/bin
@@ -47,4 +45,4 @@ do-install:
 	${INSTALL_DATA} ${WRKSRC}/doc/fra.htm ${STAGEDIR}${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/doc/index.htm ${STAGEDIR}${DOCSDIR}
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 2 Antoine Brodin freebsd_committer 2014-04-20 19:56:35 UTC
State Changed
From-To: open->closed

Patch committed minus the LICENSE change 
For a custom LICENSE to be valid, you have to set 4 things: 
- LICENSE 
- LICENSE_NAME 
- LICENSE_FILE or LICENSE_TEXT 
- LICENSE_PERMS
Comment 3 dfilter service freebsd_committer 2014-04-20 20:07:47 UTC
Author: antoine
Date: Sun Apr 20 19:07:44 2014
New Revision: 351631
URL: http://svnweb.freebsd.org/changeset/ports/351631
QAT: https://qat.redports.org/buildarchive/r351631/

Log:
  MFH: r351628
  
  Fix build
  
  PR:		ports/188387
  Submitted by:	maintainer
  Reported by:	pkg-fallout
  Approved by:	portmgr (self)

Modified:
  branches/2014Q2/textproc/htmlc/Makefile
Directory Properties:
  branches/2014Q2/   (props changed)

Modified: branches/2014Q2/textproc/htmlc/Makefile
==============================================================================
--- branches/2014Q2/textproc/htmlc/Makefile	Sun Apr 20 19:06:04 2014	(r351630)
+++ branches/2014Q2/textproc/htmlc/Makefile	Sun Apr 20 19:07:44 2014	(r351631)
@@ -6,14 +6,13 @@ PORTVERSION=	2.21.0
 CATEGORIES=	textproc
 MASTER_SITES=	http://htmlc.inria.fr/ \
 		http://caml.inria.fr/distrib/bazar-ocaml/htmlc/
-EXTRACT_SUFX=	.tgz
 
 MAINTAINER=	beyert@cs.ucr.edu
-COMMENT=	A text file generator
+COMMENT=	Text file generator
 
 BUILD_DEPENDS=	ocamlc:${PORTSDIR}/lang/ocaml
 
-USES=	gmake
+USES=		gmake tar:tgz
 
 PLIST_FILES=	bin/htmlc bin/htmlc.byt share/htmlc/env
 PLIST_DIRS=	share/htmlc
@@ -23,12 +22,11 @@ PORTDOCS=	LICENSE INSTALL README JoeCaml
 HAS_CONFIGURE=	yes
 CONFIGURE_ARGS=	--prefix ${LOCALBASE}
 
-.include <bsd.port.pre.mk>
-
 post-patch:
 	${RM} -f ${WRKSRC}/doc/Makefile
 	${TOUCH} ${WRKSRC}/doc/Makefile
 	${ECHO} "all:" > ${WRKSRC}/doc/Makefile
+	${REINPLACE_CMD} 's|-warn-error A||g' ${WRKSRC}/config/Makefile
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/compiler/htmlc ${STAGEDIR}${PREFIX}/bin
@@ -47,4 +45,4 @@ do-install:
 	${INSTALL_DATA} ${WRKSRC}/doc/fra.htm ${STAGEDIR}${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/doc/index.htm ${STAGEDIR}${DOCSDIR}
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"