Bug 188491 - [patch] devel/py-setuptoolXY: fix PYTHON_VERSION
Summary: [patch] devel/py-setuptoolXY: fix PYTHON_VERSION
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-12 06:00 UTC by John Hein
Modified: 2014-04-26 20:40 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (1.31 KB, patch)
2014-04-12 06:00 UTC, John Hein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2014-04-12 06:00:00 UTC
The current settings in py-setuptools{27,32,33,34}/Makefile for
PYTHON_VERSION are wrong (X.Y instead of pythonX.Y), but sort of work
by chance rather than design.  If it weren't for some unintended luck
from the way _PYTHON_VERSION is set and the .MAKEFLAGS line in
bsd.python.mk that forcibly sets
PYTHON_VERSION=python${_PYTHON_VERSION}, these ports would fail with
something like:

Makefile error: bad value for PYTHON_VERSION: 3.3.
Legal values are:
  python2.7 (default)
  python3.1
  python3.2
  python3.3
  python3.4
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-04-12 18:32:43 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-python

Over to maintainer(s).
Comment 2 Sunpoet Po-Chuan Hsieh freebsd_committer 2014-04-12 22:40:00 UTC
Responsible Changed
From-To: freebsd-python->sunpoet

I'll take it.
Comment 3 dfilter service freebsd_committer 2014-04-26 20:31:16 UTC
Author: sunpoet
Date: Sat Apr 26 19:31:10 2014
New Revision: 352367
URL: http://svnweb.freebsd.org/changeset/ports/352367
QAT: https://qat.redports.org/buildarchive/r352367/

Log:
  - Fix PYTHON_VERSION
  
  PR:		ports/188491
  Submitted by:	John Hein <john.hein@microsemi.com>

Modified:
  head/devel/py-setuptools27/Makefile
  head/devel/py-setuptools32/Makefile
  head/devel/py-setuptools33/Makefile
  head/devel/py-setuptools34/Makefile

Modified: head/devel/py-setuptools27/Makefile
==============================================================================
--- head/devel/py-setuptools27/Makefile	Sat Apr 26 18:43:44 2014	(r352366)
+++ head/devel/py-setuptools27/Makefile	Sat Apr 26 19:31:10 2014	(r352367)
@@ -3,7 +3,7 @@
 
 PKGNAMESUFFIX=	${PYTHON_SUFFIX}
 
-PYTHON_VERSION=	2.7
+PYTHON_VERSION=	python2.7
 
 MASTERDIR=	${.CURDIR}/../py-setuptools
 

Modified: head/devel/py-setuptools32/Makefile
==============================================================================
--- head/devel/py-setuptools32/Makefile	Sat Apr 26 18:43:44 2014	(r352366)
+++ head/devel/py-setuptools32/Makefile	Sat Apr 26 19:31:10 2014	(r352367)
@@ -3,7 +3,7 @@
 
 PKGNAMESUFFIX=	${PYTHON_SUFFIX}
 
-PYTHON_VERSION=	3.2
+PYTHON_VERSION=	python3.2
 
 MASTERDIR=	${.CURDIR}/../py-setuptools
 

Modified: head/devel/py-setuptools33/Makefile
==============================================================================
--- head/devel/py-setuptools33/Makefile	Sat Apr 26 18:43:44 2014	(r352366)
+++ head/devel/py-setuptools33/Makefile	Sat Apr 26 19:31:10 2014	(r352367)
@@ -3,7 +3,7 @@
 
 PKGNAMESUFFIX=	${PYTHON_SUFFIX}
 
-PYTHON_VERSION=	3.3
+PYTHON_VERSION=	python3.3
 
 MASTERDIR=	${.CURDIR}/../py-setuptools
 

Modified: head/devel/py-setuptools34/Makefile
==============================================================================
--- head/devel/py-setuptools34/Makefile	Sat Apr 26 18:43:44 2014	(r352366)
+++ head/devel/py-setuptools34/Makefile	Sat Apr 26 19:31:10 2014	(r352367)
@@ -3,7 +3,7 @@
 
 PKGNAMESUFFIX=	${PYTHON_SUFFIX}
 
-PYTHON_VERSION=	3.4
+PYTHON_VERSION=	python3.4
 
 MASTERDIR=	${.CURDIR}/../py-setuptools
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Sunpoet Po-Chuan Hsieh freebsd_committer 2014-04-26 20:31:28 UTC
State Changed
From-To: open->closed

Committed. Thanks!