Bug 188770 - [patch] print/ghostcript9 - remove unecessary chown & fix stage as non-root
Summary: [patch] print/ghostcript9 - remove unecessary chown & fix stage as non-root
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Document Engineering Group (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-18 20:00 UTC by John Hein
Modified: 2014-04-28 17:30 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (1.45 KB, patch)
2014-04-18 20:00 UTC, John Hein 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2014-04-18 20:00:00 UTC 
The ${CHOWN} in the post-install in print/ghostscript9/Makefile is not
needed - the created package specifies @owner root for packages that
have been created via the staging process.

I also moved the strip from post-install to 'install -s' in the make
infrastructure.  This allows 'make stage' as a regular user (otherwise,
you get 'permission denied' trying to strip a read-only file - noticed
when using portmaster with PM_SU_CMD=/usr/local/bin/sudo).

I didn't add a strip for the shared lib since we usually don't do
that for ports and that would be a change of behavior.

Fix: No need to bump portrevision.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-04-20 18:09:37 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->doceng

Over to maintainer(s).
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-04-28 17:22:53 UTC 
Author: mat
Date: Mon Apr 28 16:22:49 2014
New Revision: 352522
URL: http://svnweb.freebsd.org/changeset/ports/352522
QAT: https://qat.redports.org/buildarchive/r352522/

Log:
  Fix build as a user, really this time.
  
  PR:		188770
  Submitted by:	John Hein
  Sponsored by:	Absolight

Added:
  head/print/ghostscript9/files/patch-base-unix-dll.mak   (contents, props changed)
Modified:
  head/print/ghostscript9/Makefile

Modified: head/print/ghostscript9/Makefile
==============================================================================
--- head/print/ghostscript9/Makefile	Mon Apr 28 16:22:28 2014	(r352521)
+++ head/print/ghostscript9/Makefile	Mon Apr 28 16:22:49 2014	(r352522)
@@ -162,7 +162,6 @@ post-install-docs:
 		( cd ${STAGEDIR}${DOCSDIR} && ${TAR} -xof - )
 
 post-install:
-	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/gsc ${STAGEDIR}${PREFIX}/bin/gsx
 	${LN} -sf gsc ${STAGEDIR}${PREFIX}/bin/gs
 	${LN} -s -f ${LOCALBASE}/share/fonts/CIDFont \
 		${STAGEDIR}${DATADIR}/${PORTVERSION}/Resource/CIDFont/fonts

Added: head/print/ghostscript9/files/patch-base-unix-dll.mak
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/print/ghostscript9/files/patch-base-unix-dll.mak	Mon Apr 28 16:22:49 2014	(r352522)
@@ -0,0 +1,13 @@
+--- base/unix-dll.mak.orig	2012-08-08 02:01:36.000000000 -0600
++++ base/unix-dll.mak	2014-04-18 12:12:34.000000000 -0600
+@@ -162,8 +162,8 @@
+ 	-mkdir -p $(DESTDIR)$(bindir)
+ 	-mkdir -p $(DESTDIR)$(libdir)
+ 	-mkdir -p $(DESTDIR)$(gsincludedir)
+-	$(INSTALL_PROGRAM) $(GSSOC) $(DESTDIR)$(bindir)/$(GSSOC_XENAME)
+-	$(INSTALL_PROGRAM) $(GSSOX) $(DESTDIR)$(bindir)/$(GSSOX_XENAME)
++	$(INSTALL_PROGRAM) -s $(GSSOC) $(DESTDIR)$(bindir)/$(GSSOC_XENAME)
++	$(INSTALL_PROGRAM) -s $(GSSOX) $(DESTDIR)$(bindir)/$(GSSOX_XENAME)
+ 	$(INSTALL_PROGRAM) $(BINDIR)/$(GS_SONAME_MAJOR_MINOR) $(DESTDIR)$(libdir)/$(GS_SONAME_MAJOR_MINOR)
+ 	$(RM_) $(DESTDIR)$(libdir)/$(GS_SONAME)
+ 	ln -s $(GS_SONAME_MAJOR_MINOR) $(DESTDIR)$(libdir)/$(GS_SONAME)
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2014-04-28 17:23:01 UTC 
State Changed
From-To: open->closed

Committed, thanks!