Bug 188934 - [PATCH] security/p5-Net-SSLeay: strip library, add EXAMPLES .if block
Summary: [PATCH] security/p5-Net-SSLeay: strip library, add EXAMPLES .if block
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-24 02:30 UTC by Horia Racoviceanu
Modified: 2014-04-24 09:20 UTC (History)
0 users

See Also:


Attachments
file.diff (810 bytes, patch)
2014-04-24 02:30 UTC, Horia Racoviceanu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Horia Racoviceanu 2014-04-24 02:30:00 UTC
====> Running Q/A tests (stage-qa)
Warning: lib/perl5/site_perl/5.16/mach/auto/Net/SSLeay/SSLeay.so is not stripped consider using ${STRIP_CMD}

..

=======================<phase: deinstall      >============================
====>> Checking for orphaned files and directories in stage directory (missing from plist)
====>> Files or directories orphaned:
%%EXAMPLESDIR%%
%%EXAMPLESDIR%%/bio.pl
%%EXAMPLESDIR%%/bulk.pl
%%EXAMPLESDIR%%/callback.pl
%%EXAMPLESDIR%%/cb-testi.pl
%%EXAMPLESDIR%%/cli-cert.pl
%%EXAMPLESDIR%%/ephemeral.pl
%%EXAMPLESDIR%%/get_authenticated_page.pl
%%EXAMPLESDIR%%/get_page.pl
%%EXAMPLESDIR%%/get_page_cert.pl
%%EXAMPLESDIR%%/https-proxy-snif.pl
%%EXAMPLESDIR%%/makecert.pl
%%EXAMPLESDIR%%/minicli.pl
%%EXAMPLESDIR%%/passwd-cb.pl
%%EXAMPLESDIR%%/req.conf
%%EXAMPLESDIR%%/ssl-inetd-serv.pl
%%EXAMPLESDIR%%/ssl_diff.pl
%%EXAMPLESDIR%%/sslcat.pl
%%EXAMPLESDIR%%/sslecho.pl
%%EXAMPLESDIR%%/stdio_bulk.pl
%%EXAMPLESDIR%%/tcpcat.pl
%%EXAMPLESDIR%%/tcpecho.pl
%%EXAMPLESDIR%%/x509_cert_details.pl

Fix: - Bump PORTREVISION for post-install changes
- Strip library
- Add EXAMPLES .if block
- Break lines at around 80 characters

Build log:
https://redports.org/buildarchive/20140424010607-64657/

Patch attached with submission follows:
How-To-Repeat: Disable EXAMPLES and rebuild
Comment 1 Edwin Groothuis freebsd_committer 2014-04-24 02:30:04 UTC
Responsible Changed
From-To: freebsd-ports-bugs->perl

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Mathieu Arnold freebsd_committer 2014-04-24 08:58:19 UTC
Responsible Changed
From-To: perl->mat

Take
Comment 3 Mathieu Arnold 2014-04-24 09:01:15 UTC
Hi,

Have you checked that the port still works when the .so is stripped ?

-- 
Mathieu Arnold
Comment 4 Mathieu Arnold freebsd_committer 2014-04-24 09:10:22 UTC
State Changed
From-To: open->closed

Committed the strip bit, thanks :-)
Comment 5 dfilter service freebsd_committer 2014-04-24 09:10:25 UTC
Author: mat
Date: Thu Apr 24 08:10:21 2014
New Revision: 351987
URL: http://svnweb.freebsd.org/changeset/ports/351987
QAT: https://qat.redports.org/buildarchive/r351987/

Log:
  - Strip .so (make test still passes afterwards)[1]
  - Cleanup trailing slash
  
  PR:		ports/188934 [1]
  Submitted by:	Horia Racoviceanu [1]
  Sponsored by:	Absolight

Modified:
  head/security/p5-Net-SSLeay/Makefile

Modified: head/security/p5-Net-SSLeay/Makefile
==============================================================================
--- head/security/p5-Net-SSLeay/Makefile	Thu Apr 24 08:05:19 2014	(r351986)
+++ head/security/p5-Net-SSLeay/Makefile	Thu Apr 24 08:10:21 2014	(r351987)
@@ -3,6 +3,7 @@
 
 PORTNAME=	Net-SSLeay
 PORTVERSION=	1.58
+PORTREVISION=	1
 CATEGORIES=	security perl5
 MASTER_SITES=	CPAN
 PKGNAMEPREFIX=	p5-
@@ -26,8 +27,9 @@ PORTEXAMPLES=	*
 SHEBANG_FILES=	examples/*.pl
 
 post-install:
-	@${MKDIR} ${STAGEDIR}${EXAMPLESDIR}/
-	${INSTALL_SCRIPT} ${WRKSRC}/examples/*.pl ${STAGEDIR}${EXAMPLESDIR}/
+	${STRIP_CMD} ${STAGEDIR}${SITE_PERL}/${PERL_ARCH}/auto/Net/SSLeay/SSLeay.so
+	${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
+	${INSTALL_SCRIPT} ${WRKSRC}/examples/*.pl ${STAGEDIR}${EXAMPLESDIR}
 	${INSTALL_DATA} ${WRKSRC}/examples/req.conf ${STAGEDIR}${EXAMPLESDIR}/req.conf
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"