We want to have ocaml-gsl-1.15.1 in the ports and take the opportunity of the upgrade to add staging.
I still have a small issue on this, something causes pkg-static to print some noise, but I could not figure out the origin of this:
===> Registering installation for ocaml-gsl-1.15.1
pkg-static: lstat(/work/a/ports/math/ocamlgsl/work/stage/usr/local/lib/ocaml/site-lib/ocaml-gsl/): No such file or directory
(See build logs on RedPorts https://redports.org/buildarchive/20140426214626-32751)/
Also, I have a patch to Mk/bsd.ocaml.mk which I will post as a followup to this PR.
Fix: Patch attached with submission follows:
This is the patch to Mk/bsd.ocaml.mk which I promised when opening the
While ports/189039 is not technically a maintainer update,
I'm happy that someone is interested in this port, as I'm
not using ocaml regularly any more. So, Michael, if you're
interested in taking over maintainership, feel free to do
so and change the MAINTAINER line.
I'll take it.
since the port was *very* outdated I assumed it was not actually
maintained and subscribed myself as new MAINTAINERâ¦ I hope I did no went
*too* rogue! :-)
Assuming the bsd.ocaml.mk patch is still valid (is it?), I would think that would affect the original patch. Speaking of, the original patch obviously won't commit without conflict which I can tell from the first hunk.
Can somebody confirm bsd.ocaml.mk patch is good and regenerate the original patch set before I really look at this?
I am not sure what you mean.
I submitted the two patches separately because I did so using GNATS, which does not allow submitting several files simultaneously.
I think someone knowledgeable of bsd.ocaml.mk should review the patch to that file, the SVN history suggests that bapt could be the appropriate person.
Are not you pretty much "Mr. OCaml" these days? I think your opinion is as important as anyone is. The patch basically looks correct to me, I had to apply something like that locally this week.
RE: the other patch
It obviously doesn't apply anymore, I can tell that from seeing the old header which has been gone a long time. Can a new one be regenerate and attached?
Created attachment 143653 [details]
patch for the math/ocamlgsl port itself
Created attachment 143654 [details]
patch for Mk/bsd.ocaml.mk
So, I regenerated patches, I hope they now look fine!
The ocamlgsl patch looks fine, but the bsd.ocaml.mk patch makes it appear that bsd.ocaml.mk doesn't exist, and this is the version version.
That's not the case -- I thought the patch would be like 10 new lines or something, applied against the existing file. Maybe there was a mistake generating it?
And I assume it needs to be committed before the port is updated, is that correct?
Created attachment 143658 [details]
patch for Mk/bsd.ocaml.mk
Yes, there was a mistake. The newly generated patch should now be clean!
> And I assume it needs to be committed before the port is updated,
> is that correct?
It is correct!
A commit references this bug:
Date: Wed Jun 11 01:40:10 UTC 2014
New revision: 357405
math/ocamlgsl: Update version 0.6.0 => 1.15.1
As part of this update, bsd.ocaml.mk has been updated to essentially
disable USE_OCAML_LDCONFIG for staged ports. This means when all
ocaml ports are staged, USE_OCAML_LDCONFIG won't work at all. It
breaks staging; I don't know what the long term plan is -- maybe some
sort of post-install script will arrive...
Submitted by: maintainer (Michael Gruenewald)
Portlint pets: marino