Bug 189359 - lang/tcl-wrapper: should install the sample configuration file by default
Summary: lang/tcl-wrapper: should install the sample configuration file by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-tcltk (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-04 18:20 UTC by Thierry Thomas
Modified: 2014-05-05 15:03 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2014-05-04 18:20:00 UTC 
	tclsh is not usable out of the box: it failw with the message

Configuration file not found: /usr/local/etc/tclsh.conf
Please see the sample configuration file for details:
/usr/local/etc/tclsh.conf.sample

	Then, it cannot be used by other ports as a dependency.

Fix: 

Please install the sample configuration file as the default conf
	if the user has not already one.
How-To-Repeat: 	Just run tclsh.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-04 18:20:03 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->tcltk

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2014-05-05 14:57:44 UTC 
Author: gahr
Date: Mon May  5 13:57:35 2014
New Revision: 353003
URL: http://svnweb.freebsd.org/changeset/ports/353003
QAT: https://qat.redports.org/buildarchive/r353003/

Log:
  - Use the sample configuration file if the actual one is not available.This
  makes the wrapper usable right after make install.
  
  PR:		189359
  Submitted by:	Thierry Thomas <thierry@FreeBSD.org>

Modified:
  head/lang/tcl-wrapper/Makefile
  head/lang/tcl-wrapper/files/wrapper.in

Modified: head/lang/tcl-wrapper/Makefile
==============================================================================
--- head/lang/tcl-wrapper/Makefile	Mon May  5 13:48:25 2014	(r353002)
+++ head/lang/tcl-wrapper/Makefile	Mon May  5 13:57:35 2014	(r353003)
@@ -3,7 +3,7 @@
 
 PORTNAME=	wrapper
 PORTVERSION=	1.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	lang tcl
 MASTER_SITES=	# empty
 PKGNAMEPREFIX=	${TX_PORT}-

Modified: head/lang/tcl-wrapper/files/wrapper.in
==============================================================================
--- head/lang/tcl-wrapper/files/wrapper.in	Mon May  5 13:48:25 2014	(r353002)
+++ head/lang/tcl-wrapper/files/wrapper.in	Mon May  5 13:57:35 2014	(r353003)
@@ -6,6 +6,10 @@
 %%TX_SHELL_U%%=
 %%TX_SHELL_U%%_CONF=%%TX_CONF_FULL%%
 
+if [ ! -f "${%%TX_SHELL_U%%_CONF}" ]; then
+    %%TX_SHELL_U%%_CONF=${%%TX_SHELL_U%%_CONF}.sample
+fi
+
 if [ -f "${%%TX_SHELL_U%%_CONF}" ]; then
   . ${%%TX_SHELL_U%%_CONF}
   if [ -n "${%%TX_SHELL_U%%}" ]; then
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Pietro Cerutti freebsd_committer freebsd_triage 2014-05-05 15:03:42 UTC 
State Changed
From-To: open->closed

Fixed in a slightly different way. Now, if tclsh.conf doesn't exist, 
tclsh.conf.sample gets sourced instead. Thanks for the report!