Bug 189379 - benchmarks/phoronix-test-suite requires php5-dom
Summary: benchmarks/phoronix-test-suite requires php5-dom
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Matuska
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-05 20:30 UTC by Walter Hop
Modified: 2015-01-15 18:53 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (385 bytes, patch)
2014-05-05 20:30 UTC, Walter Hop 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Hop 2014-05-05 20:30:00 UTC 
The Phoronix Test Suite (benchmarks/phoronix-test-suite) needs the php DOM extension (textproc/php5-dom) to function.

This dependency should be made explicit by the port.

Fix: Require php5 DOM extension.

Patch attached with submission follows:
How-To-Repeat: 1. Install benchmarks/phoronix-test-suite package or port without a php5-dom package installed.
2. Run 'phoronix-test-suite', which should give the following error message:

The following PHP extensions are REQUIRED by the Phoronix Test Suite:

DOM      The PHP Document Object Model (DOM) is required for XML operations.

The following PHP extensions are OPTIONAL but recommended:

PHP FPDF PHP FPDF is recommended if wishing to generate PDF reports.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-05 20:30:07 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 lightside 2015-01-15 16:22:08 UTC 
Hello, Walter Hop.

Your changes for "USE_PHP+=dom" are included with update to new 5.4.1 version, submitted on PR 196766.
I inform you, because I saw your PR in submit process and did the same changes individually.
Comment 3 Walter Hop 2015-01-15 18:53:27 UTC 
Nice!