Bug 189861 - security/gnutls3: unconditional dependency print/texinfo is probably wrong
security/gnutls3: unconditional dependency print/texinfo is probably wrong
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: Normal Affects Only Me
Assigned To: Bryan Drewery
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-16 14:50 UTC by freebsd
Modified: 2014-05-25 16:10 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description freebsd 2014-05-16 14:50:00 UTC
security/gnutls3 has an unconditional build dependency on print/texinfo.

I believe makeinfo is only needed if DOCS option is set.

When I comment out textinfo dependency and have DOCS off, I am able to build gnutls just fine (and /usr/local/bin/makefile is not on system).

I also grepped the log; makeinfo doesn't appear

Fix: 

1) confirm that makeinfo is not needed for anything other than DOCS support
2) Once confirmed, remove the unnecessary build depends
Comment 1 Edwin Groothuis freebsd_committer 2014-05-16 14:50:04 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bdrewery

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter freebsd_committer 2014-05-25 16:02:38 UTC
Author: bdrewery
Date: Sun May 25 15:02:34 2014
New Revision: 355250
URL: http://svnweb.freebsd.org/changeset/ports/355250
QAT: https://qat.redports.org/buildarchive/r355250/

Log:
  - Convert to USES=libtool
  - texinfo is only needed when DOCS is selected [1]
  
  PR:		ports/189861 [1]
  Reported by:	marino [1]

Modified:
  head/security/gnutls3/Makefile
  head/security/gnutls3/pkg-plist

Modified: head/security/gnutls3/Makefile
==============================================================================
--- head/security/gnutls3/Makefile	Sun May 25 14:43:43 2014	(r355249)
+++ head/security/gnutls3/Makefile	Sun May 25 15:02:34 2014	(r355250)
@@ -3,6 +3,7 @@
 
 PORTNAME=	gnutls
 PORTVERSION=	3.1.23
+PORTREVISION=	1
 CATEGORIES=	security net
 MASTER_SITES=	ftp://ftp.gnutls.org/gcrypt/gnutls/v3.1/
 PKGNAMESUFFIX=	${GNUTLS_SUFFIX}
@@ -10,7 +11,6 @@ PKGNAMESUFFIX=	${GNUTLS_SUFFIX}
 MAINTAINER=	bdrewery@FreeBSD.org
 COMMENT=	GNU Transport Layer Security library
 
-BUILD_DEPENDS=	${LOCALBASE}/bin/makeinfo:${PORTSDIR}/print/texinfo
 LIB_DEPENDS=	libgpg-error.so:${PORTSDIR}/security/libgpg-error \
 		libnettle.so:${PORTSDIR}/security/nettle \
 		libp11-kit.so:${PORTSDIR}/security/p11-kit \
@@ -19,9 +19,7 @@ LIB_DEPENDS=	libgpg-error.so:${PORTSDIR}
 
 GNUTLS_SUFFIX=	3
 
-USES=		gmake iconv pkgconfig tar:xz
-USE_AUTOTOOLS=	libtool
-USE_GNOME=	ltverhack
+USES=		gmake iconv libtool:keepla pkgconfig tar:xz
 USE_LDCONFIG=	${PREFIX}/lib/gnutls3
 CPPFLAGS+=	-I${LOCALBASE}/include -fPIC
 LDFLAGS=	-L${LOCALBASE}/lib
@@ -49,6 +47,8 @@ LIBDANE_DESC=	DNSSEC support for DANE (d
 LIBDANE_LIB_DEPENDS=	libunbound.so:${PORTSDIR}/dns/unbound
 LIBDANE_CONFIGURE_OFF=	--disable-libdane
 
+DOCS_BUILD_DEPENDS=	${LOCALBASE}/bin/makeinfo:${PORTSDIR}/print/texinfo
+
 CXX_CONFIGURE_ENABLE=	cxx
 
 .include <bsd.port.options.mk>

Modified: head/security/gnutls3/pkg-plist
==============================================================================
--- head/security/gnutls3/pkg-plist	Sun May 25 14:43:43 2014	(r355249)
+++ head/security/gnutls3/pkg-plist	Sun May 25 15:02:34 2014	(r355250)
@@ -46,22 +46,27 @@ info/gnutls3/pkcs11-vision.png
 %%LIBDANE%%lib/gnutls3/libgnutls-dane.la
 %%LIBDANE%%lib/gnutls3/libgnutls-dane.so
 %%LIBDANE%%lib/gnutls3/libgnutls-dane.so.0
+%%LIBDANE%%lib/gnutls3/libgnutls-dane.so.0.0.0
 lib/gnutls3/libgnutls-openssl.a
 lib/gnutls3/libgnutls-openssl.la
 lib/gnutls3/libgnutls-openssl.so
 lib/gnutls3/libgnutls-openssl.so.27
+lib/gnutls3/libgnutls-openssl.so.27.0.2
 lib/gnutls3/libgnutls-xssl.a
 lib/gnutls3/libgnutls-xssl.la
 lib/gnutls3/libgnutls-xssl.so
 lib/gnutls3/libgnutls-xssl.so.0
+lib/gnutls3/libgnutls-xssl.so.0.0.0
 lib/gnutls3/libgnutls.a
 lib/gnutls3/libgnutls.la
 lib/gnutls3/libgnutls.so
 lib/gnutls3/libgnutls.so.28
+lib/gnutls3/libgnutls.so.28.21.3
 %%CXX%%lib/gnutls3/libgnutlsxx.a
 %%CXX%%lib/gnutls3/libgnutlsxx.la
 %%CXX%%lib/gnutls3/libgnutlsxx.so
 %%CXX%%lib/gnutls3/libgnutlsxx.so.28
+%%CXX%%lib/gnutls3/libgnutlsxx.so.28.1.0
 libdata/pkgconfig/gnutls3.pc
 %%LIBDANE%%libdata/pkgconfig/gnutls3-dane.pc
 %%LIBDANE%%man/man1/danetool3.1.gz
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Bryan Drewery freebsd_committer 2014-05-25 16:02:40 UTC
State Changed
From-To: open->closed

Fixed, thanks