Bug 189975 - devel/cssc: sccs create segfaults
Summary: devel/cssc: sccs create segfaults
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-19 23:00 UTC by Richard Kettlewell
Modified: 2014-12-14 13:12 UTC (History)
3 users (show)

See Also:


Attachments
Fix port and upgrade to the latest version available (4.94 KB, patch)
2014-11-29 11:04 UTC, Rodrigo Osorio
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Kettlewell 2014-05-19 23:00:00 UTC
[richard@neutraloid ~]$ mkdir test
[richard@neutraloid ~]$ cd test
[richard@neutraloid ~/test]$ touch one
[richard@neutraloid ~/test]$ mkdir SCCS
[richard@neutraloid ~/test]$ sccs create one

one:
sccs: admin: Signal 11 (core dumped)

[richard@neutraloid ~/test]$ gdb /usr/local/libexec/cssc/admin admin.core
GNU gdb 6.1.1 [FreeBSD]
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "amd64-marcel-freebsd"...(no debugging symbols found)...
Core was generated by `admin'.
Program terminated with signal 11, Segmentation fault.
Reading symbols from /usr/lib/libc++.so.1...(no debugging symbols found)...done.
Loaded symbols for /usr/lib/libc++.so.1
Reading symbols from /lib/libcxxrt.so.1...(no debugging symbols found)...done.
Loaded symbols for /lib/libcxxrt.so.1
Reading symbols from /lib/libm.so.5...(no debugging symbols found)...done.
Loaded symbols for /lib/libm.so.5
Reading symbols from /lib/libgcc_s.so.1...(no debugging symbols found)...done.
Loaded symbols for /lib/libgcc_s.so.1
Reading symbols from /lib/libc.so.7...(no debugging symbols found)...done.
Loaded symbols for /lib/libc.so.7
Reading symbols from /libexec/ld-elf.so.1...(no debugging symbols found)...done.
Loaded symbols for /libexec/ld-elf.so.1
#0  0x0000000800b02e96 in __cxa_begin_catch () from /lib/libcxxrt.so.1
(gdb) bt
#0  0x0000000800b02e96 in __cxa_begin_catch () from /lib/libcxxrt.so.1
#1  0x0000000000404399 in ?? ()
#2  0x00007fffffffd330 in ?? ()
#3  0x0000000000404389 in ?? ()
Previous frame identical to this frame (corrupt stack?)

[richard@neutraloid ~/test]$ pkg info cssc
cssc-1.3.0
Name           : cssc
Version        : 1.3.0
Installed on   : Mon May 19 22:32:41 BST 2014
Origin         : devel/cssc
Architecture   : freebsd:10:x86:64
Prefix         : /usr/local
Categories     : devel
Licenses       : GPLv3
Maintainer     : oliver@fromme.com
WWW            : http://www.gnu.org/software/cssc/
Comment        : Workalike for the source code control system SCCS
Options        :
        BINARY         : on
Flat size      : 1.21MiB
Description    :
CSSC is the GNU Project's replacement for SCCS.  SCCS is a proprietary suite
of tools which is provided with most commercial versions of Unix.  The purpose
behind CSSC is to provide a work-alike for SCCS which can be used on the
various Free versions of Unix.

SCCS was the only major form of source code control on Unix platforms for many
years, until RCS came along.  SCCS was an effective method for small projects,
but these days it is less popular, particularly for projects involving large
numbers of files.  A certain amount of old software is still in SCCS form, and
CSSC is designed to retrieve that software.  Once retrieved, it is recommended
to bring the source under the control of a more modern source code control
system, such as git or Apache Subversion.

However, SCCS (and CSSC) is still perfectly adequate for small projects.  For
example, if you are familiar with SCCS, it is not unreasonable to control the
files in /etc and /usr/local/etc on your private FreeBSD machine with CSSC.

WWW: http://www.gnu.org/software/cssc/

How-To-Repeat: [richard@neutraloid ~]$ mkdir test
[richard@neutraloid ~]$ cd test
[richard@neutraloid ~/test]$ touch one
[richard@neutraloid ~/test]$ mkdir SCCS
[richard@neutraloid ~/test]$ sccs create one

one:
sccs: admin: Signal 11 (core dumped)
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-05-20 14:54:43 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs

ports PR.
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-20 14:55:34 UTC
Maintainer of devel/cssc,

Please note that PR ports/189975 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/189975

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2014-05-20 14:55:35 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 oliver 2014-05-20 15:18:28 UTC
Unfortunately I cannot reproduce the problem under FreeBSD 9.x
(I've tried both i386 and amd64) with gcc as system compiler:

        $ mkdir test
        $ cd test
        $ touch one
        $ mkdir SCCS
        $ sccs create one
        
        one:
        admin: warning: SCCS/s.one: No id keywords.
        get: warning: SCCS/s.one: No id keywords.
        1.1
        0 lines
        $ 

Unfortunately I do not have a FreeBSD 10 system (yet), so I'm
not able to debug this.  If someone else can look into this,
please be my guest.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-07-25 13:23:14 UTC
Add Oliver back to PR (lost in conversion to bugzilla)
Comment 6 Rodrigo Osorio freebsd_committer freebsd_triage 2014-11-29 10:35:53 UTC
rjk@ still interested by sccs ? I have
Comment 7 Rodrigo Osorio freebsd_committer freebsd_triage 2014-11-29 10:37:09 UTC
rjk@ still interested by sccs ? I have a fix to test if you want.
Comment 8 Rodrigo Osorio freebsd_committer freebsd_triage 2014-11-29 11:04:15 UTC
Created attachment 149986 [details]
Fix port and upgrade to the latest version available
Comment 9 Richard Kettlewell 2014-11-29 11:10:21 UTC
Would be happy to give it a try.
Comment 10 Rodrigo Osorio freebsd_committer freebsd_triage 2014-11-29 11:27:34 UTC
I attach a patch to fix the port
Comment 11 Richard Kettlewell 2014-11-29 17:45:54 UTC
Works for me!
Comment 12 Rodrigo Osorio freebsd_committer freebsd_triage 2014-11-30 22:31:00 UTC
waiting for maintainer approval
Comment 13 Rodrigo Osorio freebsd_committer freebsd_triage 2014-12-08 12:08:40 UTC
last call to maintainer.
Comment 14 commit-hook freebsd_committer freebsd_triage 2014-12-08 21:47:41 UTC
A commit references this bug:

Author: rodrigo
Date: Mon Dec  8 21:46:41 UTC 2014
New revision: 374333
URL: https://svnweb.freebsd.org/changeset/ports/374333

Log:
  Fix crash when built with clang by forcing gcc
  Moves license to makes portlint happy
  Bump portrevision

  PR:		ports/189975
  Submitted by:	rodrigo
  MFH:		2014Q4

Changes:
  head/devel/cssc/Makefile
  head/devel/cssc/distinfo
  head/devel/cssc/files/
Comment 15 Rodrigo Osorio freebsd_committer freebsd_triage 2014-12-08 21:48:12 UTC
committed, thanks
Comment 16 commit-hook freebsd_committer freebsd_triage 2014-12-14 13:12:43 UTC
A commit references this bug:

Author: rodrigo
Date: Sun Dec 14 13:12:15 UTC 2014
New revision: 374701
URL: https://svnweb.freebsd.org/changeset/ports/374701

Log:
  MFH: r374333

  Upgrade to 1.4.0 and fix core dumps with clang
  - Fix Savannah bug #33633 (coredump in prs -d:GB:)
  - Accept entirely empty comment lines (lacking the initial space).
  - Fix Savannah bug bug #33153: "prs" includes "AUTO NULL DELTA"s.
  - NEWS: Point out the change of tar file format used for the
    distribution file.  Also mention the recent updates to googletest
    and gnulib.
  - Fix crash when built with clang by forcing gcc
  - Moves license to makes portlint happy

  PR:		ports/189975
  Submitted by:	rodrigo
  Approved by:	portmgr

Changes:
_U  branches/2014Q4/
  branches/2014Q4/devel/cssc/Makefile
  branches/2014Q4/devel/cssc/distinfo
  branches/2014Q4/devel/cssc/files/