mail/postgrey does not support staging Fix: Apply attached patch.
Maintainer of mail/postgrey, Please note that PR ports/190082 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/190082 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Hey this has been sitting for a week. I've gotten super busy with work and haven't tested out the patch yet. The changes look ok, but I need to test it before I give the ok to commit. This is just a quick follow-up to ACK the PR and avoid maintainer timeout. I'll test and follow-up with a commit req this weekend.
Darren, Thanks for your quick reply. Did you had time to check on that patch? - Martin
*** Bug 190468 has been marked as a duplicate of this bug. ***
Two months have passed and only 4 weeks to stage all ports, so marking this as maintainer timeout, patch-ready (Although I would have liked to have seen poudriere testlogs first)
A commit references this bug: Author: marino Date: Wed Aug 6 15:20:08 UTC 2014 New revision: 364191 URL: http://svnweb.freebsd.org/changeset/ports/364191 Log: Stage mail/postgrey PR: 190082 Submitted by: freebsd (nagilum.org) Add'l work by: marino Approved by: maintainer timeout (2.5 months) Changes: head/mail/postgrey/Makefile head/mail/postgrey/pkg-plist
I made a few changes, off the top of my head: - reordered pkg-plist to something more standard - renamed MAN1 variable to MPAGES (MAN1 was used by old code, confusing) - two more files need shebang fixes (caught by stage-qa_ - The first shebangfix file was not listed corrected (had ${WRKSRC} prefix) - Lots of 80-column wrapping - All the install commands were masked, this is against policy - switched INSTALL -d to MKDIR command (equivalent but cleaner) - joined directory creation to single command - removed pre- and post- install targets, redundant now (it does this already) It passed poudriere cleanly for me after all that.