Bug 190124 - misc. fixes for databases/p5-Bucardo
Summary: misc. fixes for databases/p5-Bucardo
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-22 22:20 UTC by Jimmy Olgeni
Modified: 2014-06-09 12:31 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (158 bytes, patch)
2014-05-22 22:20 UTC, Jimmy Olgeni
no flags Details | Diff
file.diff (241 bytes, patch)
2014-05-22 22:20 UTC, Jimmy Olgeni
no flags Details | Diff
file.diff (414 bytes, patch)
2014-05-22 22:20 UTC, Jimmy Olgeni
no flags Details | Diff
Regenerated patch file (1.66 KB, patch)
2014-06-07 17:44 UTC, Jimmy Olgeni
olgeni: maintainer-approval? (mat)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jimmy Olgeni freebsd_committer 2014-05-22 22:20:02 UTC
The databases/p5-Bucardo port needs a few minor fixes:

- Set license to BSD2CLAUSE.
- Set rcvar to bucardo_ctl_enable; do not call set_rcvar.
- Add missing items to pkg-plist.

Fix: PORTNAME=	Bucardo
 PORTVERSION=	4.5.0
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	databases perl5
 MASTER_SITES=	http://bucardo.org/downloads/ ${MASTER_SITE_LOCAL}
 MASTER_SITE_SUBDIR=	mat/
@@ -12,7 +12,7 @@
 MAINTAINER=	mat@FreeBSD.org
 COMMENT=	Asynchronous PostgreSQL replication system

-LICENSE=	BSD
+LICENSE=	BSD2CLAUSE
 LICENSE_FILE=	${WRKSRC}/LICENSE

 BUILD_DEPENDS=	p5-DBI>=1.51:${PORTSDIR}/databases/p5-DBI \
--- scripts/bucardo_ctl.rc.orig
 +++ scripts/bucardo_ctl.rc
-@@ -15,6 +15,7 @@
+@@ -11,10 +11,11 @@
+ . /etc/rc.subr
+
+ name="bucardo_ctl"
+-rcvar=`set_rcvar`
++rcvar="bucardo_ctl_enable"
  command="/usr/local/bin/${name}"
-
+
  load_rc_config $name
 +bucardo_ctl_enable=${bucardo_ctl_enable:-"NO"}
  bucardo_ctl_flags=${bucardo_ctl_flags:-"--dbuser bucardo --dbname bucardo"}
-
+
  rc_usage="start|stop|reload|restart|status|kick [sync_name]"
Comment 1 Edwin Groothuis freebsd_committer 2014-05-22 22:20:11 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mat

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Jimmy Olgeni freebsd_committer 2014-06-07 17:44:49 UTC
Created attachment 143496 [details]
Regenerated patch file

Hi,

I replaced the mangled GNATS diff with a proper patch.
Comment 3 commit-hook freebsd_committer 2014-06-09 12:31:35 UTC
A commit references this bug:

Author: mat
Date: Mon Jun  9 12:31:18 UTC 2014
New revision: 357143
URL: http://svnweb.freebsd.org/changeset/ports/357143

Log:
  - Set license to BSD2CLAUSE.
  - Set rcvar to bucardo_ctl_enable; do not call set_rcvar.

  PR:		190124
  Submitted by:	olgeni@
  Sponsored by:	Absolight

Changes:
  head/databases/p5-Bucardo/Makefile
  head/databases/p5-Bucardo/files/patch-scripts_bucardo__ctl.rc