Stage the port, and update to 1.9.8 Fix: See attached diff Patch attached with submission follows:
Created attachment 143300 [details] Updated patch Hi, I have tested your patch and made a few changes. The patch is attached to the bug report. In both patches I introduced again the %%PREFIX%% and the post-patch target. The prefix can be changed and shouldn't be hardcoded in the port. This is the correct way to handle this. In lib/util.py I added a check for FreeBSD, the port was failing claiming "Unknown system". Can you review and approve these changes? Also, the port now only has an https master site. While this could do, not all peoople have unlimited connectivity, especially proxies sometimes filter https. Could you investigate if a plain http master site can be found and added to MASTER_SITES? Thanks in advance.
Hi Guido. The %%PREFIX%% thing is wrong and should be removed again to how I submitted the patch. With PREFIX thing "make stage" fails. It is not needed because the python installation wrapper system *already handles the prefix*, so it ends up being replaced twice. I cannot test the FreeBSD thing but that's fine in principle of course. Can you just remove the "s" in https from MASTER SITES? Plain http works fine.
I'm performing some tests, but it does not looks correct without the PREFIX thing. First of all in your patches you're hardconfding /usr/local/share. in setyp.py you're changing: -usr_share = '/usr/share' -if not os.access(usr_share, os.W_OK): - usr_share = os.getenv("XDG_DATA_HOME", os.path.join(os.getenv("HOME"), ".local", "share")) +usr_share = '/usr/local/share' if pythion was taking care of that it should work with /usr/share too. You're also hardcoding it in util.py: - return "/Library/Application Support/Electrum" + return os.path.join('/usr/local', "share", "electrum") You can test by putting a wrong path here and see the port fail. These should really be dynamically changed in case a non standard prefix is used. With this kind of patch the port isn't failing, a log for example: http://www.madpilot.net/~mad/electrum-1.9.8.log With python ports there is anyway a python caused problem because some python files will get installed anyway to LOCALBASE, so this port will not work correctly anyway when using PREFIX != LOCALBASE, but this is not a good reason to hardcode /usr/local a PREFIX. I'm attaching a new patch to this bug since the previous one I sent actually contained a mistake. Please review and test this one.
Created attachment 143323 [details] New patch
Comment on attachment 143300 [details] Updated patch Hi Guido, Yes this works fine for me to with and without staging. It's odd because I'm sure the old one worked fine, and when I originally tried this myself I got doubled paths like /usr/obj/dports/finance/electrum/work/stage/usr/local/share/usr/obj/dports/finance/electrum/work/stage/usr/local/share/locale/vi_VN/LC_MESSAGES But this isn't happening now so please go ahead and commit your change, it looks good to me. Thanks for your help.
And remove the 's' of https if you don't want it; it still seems to be there.
Committed, Thanks!
A commit references this bug: Author: madpilot Date: Tue Jun 3 10:55:26 UTC 2014 New revision: 356326 URL: http://svnweb.freebsd.org/changeset/ports/356326 Log: - Update to 1.9.8 - Stagify PR: 190398 Submitted by: kyuupichan@gmail.com (maintainer) Changes: head/finance/electrum/Makefile head/finance/electrum/distinfo head/finance/electrum/files/patch-lib__util.py head/finance/electrum/files/patch-setup.py head/finance/electrum/pkg-plist
*** Bug 188682 has been marked as a duplicate of this bug. ***