Bug 190822 - [PATCH] x11-fonts/indic-ttf: option MALAYALAM missing from Makefile
Summary: [PATCH] x11-fonts/indic-ttf: option MALAYALAM missing from Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-09 08:04 UTC by Christopher Hall
Modified: 2014-07-20 20:20 UTC (History)
2 users (show)

See Also:

Attachments
Add MALAYALAM to Options variables in Makefile (537 bytes, patch)
2014-06-09 08:04 UTC, Christopher Hall 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Hall 2014-06-09 08:04:27 UTC 
Created attachment 143555 [details]
Add MALAYALAM to Options variables in Makefile

option MALAYALAM missing is missing in the current version

when running "make config" this font does not show in the config dialog.

I noticed this when checking that EMACS could show all fonts on the
"hello" page.  After patching and reinstalling the font, EMACS was
able to show fonts on the Malayalam line.
Comment 1 William Grzybowski freebsd_committer freebsd_triage 2014-06-24 18:16:49 UTC 
We cannot commit ports without Stage support anymore, any chance you can add that update as well?
Comment 2 Christopher Hall 2014-07-18 03:02:14 UTC 
It looks like this port was updated to already add stage support: the Makefile shows this:
# $FreeBSD: head/x11-fonts/indic-ttf/Makefile 360616 2014-07-04 14:05:20Z vanilla $

and there are commands to install into STAGEDIR

However the MALAYALAM option patch from this was not added.

I used my patch and rebuilt the port, it still works.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-07-20 20:18:57 UTC 
A commit references this bug:

Author: marino
Date: Sun Jul 20 20:18:49 UTC 2014
New revision: 362368
URL: http://svnweb.freebsd.org/changeset/ports/362368

Log:
  x11-fonts/indic-ttf: Restore missing MALAYALAM option, then clean up

  The MALAYALAM option was in place but not actually defined, so it
  apparently got lost somewhere along the way.  Restore it, then simplify
  the port using OPTIONS_SUB=yes.  The definitions of FONTSDIR and
  CONFAVAILDIR weren't liked on DragonFly poudriere so those were reworked
  to something more robust.  While here pet portlint and do some cosmetic
  alignments.

  PR:		190822
  Submitted by:	Christopher Hall

Changes:
  head/x11-fonts/indic-ttf/Makefile
Comment 4 John Marino freebsd_committer freebsd_triage 2014-07-20 20:20:10 UTC 
Thanks!