Bug 190907 - [patch] Improvements for devel/jline
Summary: [patch] Improvements for devel/jline
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jimmy Olgeni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-10 19:35 UTC by Jimmy Olgeni
Modified: 2014-10-26 21:03 UTC (History)
1 user (show)

See Also:
mkamm: maintainer-feedback+

Attachments
Misc. fixes for jline (2.85 KB, patch)
2014-06-10 19:35 UTC, Jimmy Olgeni 		olgeni: maintainer-approval? (mkamm)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jimmy Olgeni freebsd_committer freebsd_triage 2014-06-10 19:35:05 UTC 
Created attachment 143651 [details]
Misc. fixes for jline

A few improvements:

- Add staging support.
- Fix COMMENT according to Porter's Handbook.
- LICENSE is actually BSD2CLAUSE.
- Use SUB_FILES to process pkg-message.
- Do not installed a jar file with versioned file name.
- Remove internal plist target, which is superseded by staging.
Comment 1 mkamm 2014-06-16 13:21:51 UTC 
Looks very professional!
(BTW: Glad to see someone still uses it.)
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-17 19:01:44 UTC 
This was approved, changing status to stop false positive on searches.
Comment 3 mkamm 2014-09-21 21:55:22 UTC 
Comment on attachment 143651 [details]
Misc. fixes for jline

yes, approved
Comment 4 Jimmy Olgeni freebsd_committer freebsd_triage 2014-10-26 21:03:19 UTC 
Needs to be reworked for current port.