Here is a proposal for updating dhcprelya to 4.8 and adding staging support.
Created attachment 143679 [details] svn diff patch
How was this proposal tested?
Build tested with "poudriere testport": root@orange:~ # poudriere testport -o net/dhcprelya -j 100amd64 -z server ====>> Creating the reference jail... done ====>> Mounting system devices for 100amd64-default-server ====>> Mounting ports/packages/distfiles ====>> Mounting packages from: /usr/local/poudriere/data/packages/100amd64-default-server (etc...) =========================================================================== ====>> Checking for filesystem violations... done =======================<phase: run-depends >============================ =========================================================================== =======================<phase: stage >============================ ===> Staging for dhcprelya-4.8 ===> Generating temporary packing list install -s -m 555 dhcprelya /wrkdirs/usr/ports/net/dhcprelya/work/stage//usr/local/sbin/ install -s -m 555 dhcprelya_log_plugin.so /wrkdirs/usr/ports/net/dhcprelya/work/stage//usr/local/lib/ install -s -m 555 dhcprelya_option82_plugin.so /wrkdirs/usr/ports/net/dhcprelya/work/stage//usr/local/lib/ /bin/mkdir -p /wrkdirs/usr/ports/net/dhcprelya/work/stage//usr/local/share/doc/dhcprelya install -o root -g wheel -m 444 /wrkdirs/usr/ports/net/dhcprelya/work/sem-hub-dhcprelya-32d3356/README /wrkdirs/usr/ports/net/dhcprelya/work/stage//usr/local/share/doc/dhcprelya ====> Compressing man pages (compress-man) ===> Staging rc.d startup script(s) =========================================================================== ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for directories owned by MTREEs ===> Checking for directories handled by dependencies ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) ====>> Checking for staging violations... done =======================<phase: package >============================ ===> Building package for dhcprelya-4.8 =========================================================================== =======================<phase: install-mtree >============================ =========================================================================== =======================<phase: install >============================ ===> Installing for dhcprelya-4.8 ===> Checking if net/dhcprelya already installed ===> Registering installation for dhcprelya-4.8 Installing dhcprelya-4.8... done ===> SECURITY REPORT: This port has installed the following files which may act as network servers and may therefore pose a remote security risk to the system. /usr/local/sbin/dhcprelya This port has installed the following startup scripts which may cause these network services to be started at boot time. /usr/local/etc/rc.d/dhcprelya If there are vulnerabilities in these programs there may be a security risk to the system. FreeBSD makes no guarantee about the security of ports included in the Ports Collection. Please type 'make deinstall' to deinstall the port if this is a concern. =========================================================================== ====>> Checking shared library dependencies libc.so.7 => /lib/libc.so.7 (0x80081f000) libc.so.7 => /lib/libc.so.7 (0x800ea0000) libpcap.so.8 => /lib/libpcap.so.8 (0x800826000) libthr.so.3 => /lib/libthr.so.3 (0x800c7b000) libutil.so.9 => /lib/libutil.so.9 (0x800a69000) =======================<phase: deinstall >============================ ===> Deinstalling for net/dhcprelya ===> Deinstalling Deinstallation has been requested for the following 1 packages: dhcprelya-4.8 The deinstallation will free 88 KB [1/1] Deleting dhcprelya-4.8... done =========================================================================== ====>> Checking for extra files and directories ====>> Installing from package Installing dhcprelya-4.8... done ====>> Cleaning up ===> Cleaning for dhcprelya-4.8 ====>> Deinstalling package Deinstallation has been requested for the following 1 packages: dhcprelya-4.8 The deinstallation will free 88 KB [1/1] Deleting dhcprelya-4.8... done build of /usr/ports/net/dhcprelya ended at Wed Jun 11 19:15:44 CEST 2014 build time: 00:00:07 ====>> Cleaning up And the software was tested on a virtual lab: http://bsdrp.net/documentation/examples/dhcp_relay_and_server_lab Is enough or did I forgot some tests ?
poudriere testport is enough[1] This is good information that you should always put on PRs. believe me, a lot of patches obviously aren't tested. [1] The one exception is when a port works for FreeBSD 8 and 9, but not 10 or 11 for some reason (and vice versa), and poudriere was only checked for one release. This can also happen between i386 and amd64.
A commit references this bug: Author: marino Date: Wed Jun 11 18:05:55 UTC 2014 New revision: 357514 URL: http://svnweb.freebsd.org/changeset/ports/357514 Log: net/dhcprelya: Update version 4.7 => 4.8 and support stage PR: 190932 Submitted by: olivier (cochard.me) Approved by: staging blanket verified: Passed redports 8x Changes: head/net/dhcprelya/Makefile head/net/dhcprelya/distinfo
good patch, it built cleanly 8x on redports. Thanks! I assumed you were maintainer, but he's CC'd now.
"I assumed you were maintainer" - most brilliant piece :-)
A commit references this bug: Author: marino Date: Wed Jun 18 22:24:02 UTC 2014 New revision: 358327 URL: http://svnweb.freebsd.org/changeset/ports/358327 Log: net/dhcprelya: correct license, BSD-4 => BSD-3-clause The previous commit incorrectly listed the license as 4-clause BSD. The error probably came from the clauses being listed as 1, 2, 4. Revbump! PR: 190932 Reported by: eadler Changes: head/net/dhcprelya/Makefile