Bug 190969 - [PATCH] games/warsow: Update to v1.51
Summary: [PATCH] games/warsow: Update to v1.51
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on: 190968
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-12 15:05 UTC by lightside
Modified: 2015-06-27 21:56 UTC (History)
1 user (show)

See Also:


Attachments
Proposed patch (2.64 KB, text/plain)
2014-06-12 15:05 UTC, lightside
no flags Details
Proposed patch (since 361986 revision) (2.52 KB, patch)
2014-07-22 05:22 UTC, lightside
no flags Details | Diff
Proposed patch (since 361986 revision) (3.12 KB, patch)
2014-09-03 21:00 UTC, lightside
no flags Details | Diff
The poudriere build log (FreeBSD 10 amd64) (19.04 KB, application/x-zip-compressed)
2014-09-03 21:00 UTC, lightside
no flags Details
Proposed patch (since 367888 revision) (3.12 KB, patch)
2014-09-15 13:00 UTC, lightside
no flags Details | Diff
Proposed patch for no xrandr (since 369291 revision) (1.64 KB, patch)
2014-09-27 04:29 UTC, lightside
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2014-06-12 15:05:01 UTC
Created attachment 143710 [details]
Proposed patch

Patch to update games/warsow port from 1.5 to 1.51 version.

Updated games/warsow-data port (to 1.51 version) required to run.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-06-13 04:30:59 UTC
Over to maintainers.
Comment 2 lightside 2014-07-22 05:22:00 UTC
Created attachment 144866 [details]
Proposed patch (since 361986 revision)

- Added patch according to 361986 revision changes
- Renamed extension of the patch to diff
Comment 3 lightside 2014-09-03 21:00:07 UTC
Created attachment 146752 [details]
Proposed patch (since 361986 revision)

Fixed some issues found by ports-mgmt/portlint.
Also tested with poudriere and added (archived) build log.
Comment 4 lightside 2014-09-03 21:00:31 UTC
Created attachment 146753 [details]
The poudriere build log (FreeBSD 10 amd64)
Comment 5 lightside 2014-09-15 13:00:27 UTC
Created attachment 147343 [details]
Proposed patch (since 367888 revision)

Updated diff file after PORTREVISION changes.
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2014-09-24 13:43:39 UTC
JFYI, the commit was delayed because it crashed on my box.

The cause is that new version of warsow unconditionally uses XRandr, but it's not supported with nvidia blob, and the game crashes. Yesterday I've managed to hack-fix it, so I'm adding an option to disable XRandr and committing it.
Comment 7 lightside 2014-09-25 06:17:05 UTC
(In reply to Dmitry Marakasov from comment #6)
> JFYI, the commit was delayed because it crashed on my box.

Ok, I understood.

> The cause is that new version of warsow unconditionally uses XRandr, but
> it's not supported with nvidia blob, and the game crashes. Yesterday I've
> managed to hack-fix it, so I'm adding an option to disable XRandr and
> committing it.

I don't have such issues on my setup with following ports installed:
x11/nvidia-driver-340.32 (new version, but also worked on previous one).
x11-servers/xorg-server-1.7.7_14,1
x11-wm/xfce4-wm-4.10.1
Comment 8 lightside 2014-09-25 10:11:35 UTC
I can confirm, there is presence of warsow.core file inside of home directory, from time to time. But I didn't see the reason of it, while application runs.
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-09-25 20:18:11 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Sep 25 20:18:06 UTC 2014
New revision: 369291
URL: http://svnweb.freebsd.org/changeset/ports/369291

Log:
  - Update to v1.51

  PR:		190969
  Submitted by:	lightside@gmx.com

Changes:
  head/games/warsow/Makefile
  head/games/warsow/distinfo
  head/games/warsow/files/extra-patch-no-xrandr
  head/games/warsow/files/patch-Makefile
Comment 10 Dmitry Marakasov freebsd_committer freebsd_triage 2014-09-25 20:21:41 UTC
Committed with minor changes:

- Use PORTDATA
- Make XRandr optional
- Remove unneeded DIST_SUBDIR
Comment 11 lightside 2014-09-27 04:27:46 UTC
After looking the patch to disable XRandr, I think there is a possibility to use XLib functions to get width and height of screen by using XDisplayWidth and XDisplayHeight functions. I propose the patch to complete the port for current version.
Comment 12 lightside 2014-09-27 04:29:03 UTC
Created attachment 147711 [details]
Proposed patch for no xrandr (since 369291 revision)
Comment 13 lightside 2015-06-27 21:56:19 UTC
Ok, let's close this PR, which was related to the update, mainly.