Created attachment 143788 [details]
This is a patch upgrades moosefs to 1.6.27-5.
It also includes following fixes:
- support for staging
- fixing issues with config locations
- updated rc scripts
- cgiserv now runs as an unprivileged user
- ability to reload config without restarting
Note: please update moosefs-chunkserver and moosefs-client at the same time.
Created attachment 143789 [details]
Created attachment 143790 [details]
Created attachment 143791 [details]
Could I get an update regarding this?
Yes, I think we can commit these patchs. Thanks!
I must be missing something. These patches remove bsd.port.moosefs.mk which defines PORTVERSION and PORTREVISION among other things, but it doesn't seem to move the definition to the master port.
All I see is DISTVERSION hardcoded.
So what gives? Is this a giant oversight or did I miss something?
okay, looking at bsd.port.mk, it seems PORTVERSION is not needed if DISTVERSION is given. I don't think that removes the need for PORTREVISION?=0 though, otherwise slaves can't define PORTREVISION independently.
I am going to convert all these .cfg.dist to .cfg.sample so we can use the cleaner @sample keyword in pkg-plist
It turns out that the vendor makefile tries to change ownership to mfs:mfs before the user and group are created, so I have to patch the makefile. Since I'm patching it anyway, I'm putting the .dist => .sample change here as well instead of post-install.
combine with using @owner, @group in the pkg-plist, it's passing poudriere testport now.
okay, I see now that there is no shared information like PORTVERSION or distinfo. Each slave port stands alone, so there's no need for portrevision?= 0
A commit references this bug:
Date: Sat Jul 12 10:17:00 UTC 2014
New revision: 361607
sysutils/moosefs-*: Upgrade version 1.6.27 => 1.6.27-5 and Stage support
This was a master and two slave ports. Now each port stands alone, each
with it's own defined distinfo which allows for the separate mk to be
* Ownership of slave ports restored to chifeng. They were reset in
error because their staging was combined with master staging
* Configure locations uniformly fixed to /etc/mfs
* cgiserv now runs as unpriviledged user
* Fixes ability to reload config without restarting
* Uses @sample keyword for config files now
* fixes -master, -chunkserver, and -client ports
Submitted by: takeda (takeda.tk)
Approved by: maintainer (chifeng)
Minor fixes: marino
Okay, it's done. chifeng has been removed as maintainer from the slave ports but I put him back. He was removed since no PR existed for his ports but obviously it did (just combined with -master PR)