Bug 191120 - [Maintainer] textproc/teckit: libtool and other cleanup
Summary: [Maintainer] textproc/teckit: libtool and other cleanup
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-17 12:12 UTC by Nikola Lečić
Modified: 2014-08-16 10:06 UTC (History)
2 users (show)

See Also:

Attachments
teckit-2.5.1_1.diff (1.41 KB, patch)
2014-06-17 12:12 UTC, Nikola Lečić 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikola Lečić 2014-06-17 12:12:00 UTC 
Created attachment 143862 [details]
teckit-2.5.1_1.diff

Log:
 * CATEGORIES+=converters
 * correct use of LIB_DEPENDS, INSTALL_TARGET
 * USES=libtool
 * it needs GNU_CONFIGURE=yes
 * correct use of OPTIONS_DEFINE=DOCS
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2014-06-28 03:58:42 UTC 
this port is already stage, no action needed here.
Comment 2 Nikola Lečić 2014-06-28 15:50:16 UTC 
This was not staging patch, but cleaning patch.
So, please, retake this PR. As I wrote:

teckit-2.5.1_1.diff
Log:
 * CATEGORIES+=converters
 * correct use of LIB_DEPENDS, INSTALL_TARGET
 * USES=libtool
 * it needs GNU_CONFIGURE=yes
 * correct use of OPTIONS_DEFINE=DOCS
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2014-06-28 16:01:05 UTC 
reopen
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-16 09:53:10 UTC 
3 commits have occurred to this port (not including today's) and the patch doesn't apply anymore.

I'll throw away the Makefile portion and try to make the changes manually.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-16 09:55:02 UTC 
even that part is obsolete...
Comment 6 John Marino freebsd_committer freebsd_triage 2014-08-16 09:57:06 UTC 
The only thing that hasn't already been done is adding this to the converters category.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-08-16 10:06:15 UTC 
A commit references this bug:

Author: marino
Date: Sat Aug 16 10:05:46 UTC 2014
New revision: 365071
URL: http://svnweb.freebsd.org/changeset/ports/365071

Log:
  textproc/teckit: CATEGORIES+= converters

  This is the only thing remaining from the PR, everything else was already
  done in sweeps.

  PR:		191120
  Submitted by:	maintainer (Nikola Lecic)

Changes:
  head/textproc/teckit/Makefile
Comment 8 John Marino freebsd_committer freebsd_triage 2014-08-16 10:06:50 UTC 
done.