Bug 191152 - [NEW PORT] x11-fonts/hasklig
Summary: [NEW PORT] x11-fonts/hasklig
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-18 10:46 UTC by Gleb Popov
Modified: 2014-06-27 17:11 UTC (History)
1 user (show)

See Also:


Attachments
Archive with new port (1.00 KB, application/gzip)
2014-06-18 10:46 UTC, Gleb Popov
no flags Details
Archive with new port (951 bytes, application/gzip)
2014-06-26 06:14 UTC, Gleb Popov
no flags Details
Archive with new port (949 bytes, application/gzip)
2014-06-27 05:39 UTC, Gleb Popov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb Popov freebsd_committer 2014-06-18 10:46:07 UTC
Created attachment 143896 [details]
Archive with new port
Comment 1 Raphael Kubo da Costa freebsd_committer 2014-06-20 10:54:34 UTC
> DISTNAME=Hasklig-${PORTVERSION}

Missing a tab here.

> BUILD_DEPENDS=fc-cache:${PORTSDIR}/x11-fonts/fontconfig
> RUN_DEPENDS:=	${BUILD_DEPENDS}

I believe fontconfig can be declared as a runtime dependency only, as it is only invoked when the port is installed and deinstalled. In any case, the second assignment could be a normal one, since nothing else changes BUILD_DEPENDS.

> @unexec /bin/rm %D/%%FONTSDIR%%/fonts.cache-1 2>/dev/null || /usr/bin/true
> @dirrm %%FONTSDIR%%
> @exec %%LOCALBASE%%/bin/fc-cache -f -v %D/%%FONTSDIR%% || /usr/bin/true

Please use the @fc keyword instead: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-keywords.html
Comment 2 Gleb Popov freebsd_committer 2014-06-20 16:59:08 UTC
(In reply to Raphael Kubo da Costa from comment #1)
> > DISTNAME=Hasklig-${PORTVERSION}
> 
> Missing a tab here.
> 
> > BUILD_DEPENDS=fc-cache:${PORTSDIR}/x11-fonts/fontconfig
> > RUN_DEPENDS:=	${BUILD_DEPENDS}
> 
> I believe fontconfig can be declared as a runtime dependency only, as it is
> only invoked when the port is installed and deinstalled. In any case, the
> second assignment could be a normal one, since nothing else changes
> BUILD_DEPENDS.
> 
> > @unexec /bin/rm %D/%%FONTSDIR%%/fonts.cache-1 2>/dev/null || /usr/bin/true
> > @dirrm %%FONTSDIR%%
> > @exec %%LOCALBASE%%/bin/fc-cache -f -v %D/%%FONTSDIR%% || /usr/bin/true
> 
> Please use the @fc keyword instead:
> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-
> keywords.html

I've stolen this Makefile from x11-fonts/ubuntu-font. And, BTW, i still have no idea how fontconfig gets run on install.

Ok, i'll fix your points and attach a new patch.
Comment 3 Raphael Kubo da Costa freebsd_committer 2014-06-20 18:39:41 UTC
> And, BTW, i still have no idea how fontconfig gets run on install.

You can see how this is implemented by looking at Keywords/fc.yaml.
Comment 4 Gleb Popov freebsd_committer 2014-06-26 06:14:24 UTC
Created attachment 144139 [details]
Archive with new port

Updated port.
Comment 5 Raphael Kubo da Costa freebsd_committer 2014-06-26 19:44:01 UTC
(In reply to Raphael Kubo da Costa from comment #1)
> > BUILD_DEPENDS=fc-cache:${PORTSDIR}/x11-fonts/fontconfig
> > RUN_DEPENDS:=	${BUILD_DEPENDS}
> 
> I believe fontconfig can be declared as a runtime dependency only, as it is
> only invoked when the port is installed and deinstalled. In any case, the
> second assignment could be a normal one, since nothing else changes
> BUILD_DEPENDS.

I didn't see any change in this part, even though the port built fine here without the BUILD_DEPENDS line. Have you given it any thought?
Comment 6 Gleb Popov freebsd_committer 2014-06-27 05:39:05 UTC
Created attachment 144186 [details]
Archive with new port

Ah, sorry, missed it.
Comment 7 Raphael Kubo da Costa freebsd_committer 2014-06-27 17:07:50 UTC
I'm going to commit a version that moves DISTNAME one line up and uses RUN_DEPENDS= instead of RUN_DEPENDS:= (I've explained the difference between those two before). Please run portlint before submitting.
Comment 8 commit-hook freebsd_committer 2014-06-27 17:09:52 UTC
A commit references this bug:

Author: rakuco
Date: Fri Jun 27 17:09:44 UTC 2014
New revision: 359584
URL: http://svnweb.freebsd.org/changeset/ports/359584

Log:
  Add x11-fonts/hasklig.

  Hasklig is a Haskell code font with monospaced ligatures based on Source Code
  Pro font. It adds nice representations of such operators like (->), (>>=),
  (-<) and so on.

  WWW: http://github.com/i-tu/Hasklig

  PR:		191152
  Submitted by:	arrowdodger <6yearold@gmail.com>

Changes:
  head/x11-fonts/Makefile
  head/x11-fonts/hasklig/
  head/x11-fonts/hasklig/Makefile
  head/x11-fonts/hasklig/distinfo
  head/x11-fonts/hasklig/pkg-descr
  head/x11-fonts/hasklig/pkg-plist