Bug 191189 - [patch] graphics/libvisual04: Fix warning in installed header
Summary: [patch] graphics/libvisual04: Fix warning in installed header
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-19 15:54 UTC by Koop Mast
Modified: 2014-06-27 20:47 UTC (History)
0 users

See Also:


Attachments
Fix installed headers issues with clang. (4.53 KB, patch)
2014-06-19 15:55 UTC, Koop Mast
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Koop Mast freebsd_committer 2014-06-19 15:54:11 UTC
Apply patch from upstream to fix a warning. This allows me to build the gstreamer1 libvisual plugin with -Werror.
Comment 1 Koop Mast freebsd_committer 2014-06-19 15:55:12 UTC
Created attachment 143930 [details]
Fix installed headers issues with clang.
Comment 2 Chris Rees freebsd_committer 2014-06-24 18:59:17 UTC
OK, I'm officially confused :)

Your patch has a tiny bit of patch in it, which doesn't do anything, and the referenced commit doesn't apply properly, and when massaged in, clang still complains about redefining NULL!

Have I missed something?

Chris
Comment 3 Koop Mast freebsd_committer 2014-06-27 16:47:22 UTC
The patch is needed to "fix" the following error:

make[3]: Entering directory `/usr/home/kwm/cvs/freedesktop/gst-plugins-base/ext/libvisual'
  CC       libgstlibvisual_la-plugin.lo
In file included from plugin.c:25:
In file included from ./visual.h:29:
In file included from /usr/local/include/libvisual-0.4/libvisual/libvisual.h:29:
In file included from /usr/local/include/libvisual-0.4/libvisual/lv_bits.h:28:
/usr/local/include/libvisual-0.4/libvisual/lv_defines.h:68:10: error: 
      '__packed' macro redefined [-Werror]
# define __packed               __attribute__ ((packed))
         ^
/usr/include/sys/cdefs.h:230:9: note: previous definition is here
#define __packed        __attribute__((__packed__))
        ^
1 error generated.
gmake[3]: *** [libgstlibvisual_la-plugin.lo] Error 1
Comment 4 Koop Mast freebsd_committer 2014-06-27 17:36:44 UTC
(In reply to Chris Rees from comment #2)
> OK, I'm officially confused :)
> 
> Your patch has a tiny bit of patch in it, which doesn't do anything, and the
> referenced commit doesn't apply properly, and when massaged in, clang still
> complains about redefining NULL!
> 
> Have I missed something?
> 
> Chris

Yeah the reference commit doesn't apply. But the changes are good enough.
Comment 5 commit-hook freebsd_committer 2014-06-27 20:47:09 UTC
A commit references this bug:

Author: crees
Date: Fri Jun 27 20:46:59 UTC 2014
New revision: 359607
URL: http://svnweb.freebsd.org/changeset/ports/359607

Log:
  Apply patch from upstream to fix a warning.
  This allows build of the gstreamer1 libvisual plugin with -Werror.

  PR:		ports/191189
  Submitted by:	kwm

Changes:
  head/graphics/libvisual04/Makefile
  head/graphics/libvisual04/files/patch-libvisual-lv_defines.h
  head/graphics/libvisual04/files/patch-libvisual-lv_mem.h
  head/graphics/libvisual04/pkg-plist