Bug 191267 - [UPDATE]: databases/py-redis to 2.10.1
Summary: [UPDATE]: databases/py-redis to 2.10.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Raphael Kubo da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-22 09:56 UTC by Melvyn Sopacua
Modified: 2014-06-23 17:21 UTC (History)
2 users (show)

See Also:


Attachments
update-py-redis-2.10.1.patch (2.15 KB, patch)
2014-06-22 09:56 UTC, Melvyn Sopacua
no flags Details | Diff
Fix HTMLDOCS issues (2.26 KB, patch)
2014-06-22 21:40 UTC, Melvyn Sopacua
no flags Details | Diff
Proposed fixes (1.79 KB, patch)
2014-06-23 07:14 UTC, Raphael Kubo da Costa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Melvyn Sopacua 2014-06-22 09:56:33 UTC
Created attachment 144018 [details]
update-py-redis-2.10.1.patch

Updates to 2.10.1 and add support to build HTML documentation via sphinx.

Fix:
Build archives:
https://redports.org/buildarchive/20140622093200-49963/
https://redports.org/buildarchive/20140622090401-30908/
https://redports.org/buildarchive/20140622085456-77151/
Comment 1 Raphael Kubo da Costa freebsd_committer 2014-06-22 18:55:53 UTC
Building with HTMLDOCS on fails in check-plist:

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/.buildinfo
Comment 2 Melvyn Sopacua 2014-06-22 19:55:41 UTC
Guess I need to wrap that for the NOPORTDOCS case, coming up.
Comment 3 Melvyn Sopacua 2014-06-22 20:11:42 UTC
(In reply to Raphael Kubo da Costa from comment #1)

> Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/.buildinfo

If that's the only one, then it's PORTDOCS=* that doesn't include hidden files. Easiest fix is to remove it in post-install, which I'm doing now. But thanks for prompting me to check the NOPORTDOCS case as well.
Comment 4 Melvyn Sopacua 2014-06-22 21:40:50 UTC
Created attachment 144048 [details]
Fix HTMLDOCS issues

Buildarchive: https://redports.org/buildarchive/20140622202300-12929/
Comment 5 Raphael Kubo da Costa freebsd_committer 2014-06-22 22:19:05 UTC
Thanks for the update, but check-plist still fails here, albeit with a different error, when HTMLDOCS is on.

With poudriere, I get this:
===> No pkg-plist issues found (check-plist)
====>> Checking for staging violations... done
====>> Error: Filesystem touched during stage (files must install to ${STAGEDIR}):
extra: usr/local/share/doc/py27-redis

If I just use `make clean build stage stage-qa check-plist' I get this during the installation phase:
mkdir: /usr/local/share/doc/py27-redis: Permission denied
*** Error code 1
Comment 6 Raphael Kubo da Costa freebsd_committer 2014-06-22 22:20:38 UTC
Oh, it's just a missing ${STAGEDIR} in your mkdir call in post-install. I'll fix that in the commit.
Comment 7 commit-hook freebsd_committer 2014-06-22 22:22:29 UTC
A commit references this bug:

Author: rakuco
Date: Sun Jun 22 22:22:12 UTC 2014
New revision: 358855
URL: http://svnweb.freebsd.org/changeset/ports/358855

Log:
  - Updates to 2.10.1
  - Add support to build HTML documentation via sphinx.

  PR:		191267
  Submitted by:	melvyn@magemana.nl (maintainer)

Changes:
  head/databases/py-redis/Makefile
  head/databases/py-redis/distinfo
Comment 8 Raphael Kubo da Costa freebsd_committer 2014-06-22 22:23:12 UTC
Committed, thanks.
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2014-06-23 02:45:56 UTC
Submitter is not maintainer. Re-opening.

@Raphael: as per list reply, please:

 - Rename the HTMLDOCS option name to DOCS
 - Use USES=uniquefiles for uniquely-prefixed python doc directories.
Comment 10 Raphael Kubo da Costa freebsd_committer 2014-06-23 07:14:04 UTC
Created attachment 144058 [details]
Proposed fixes

Sorry for the screw-up! Let me know if this is what you have in mind. It still hasn't been QA'd as you said in the list reply, though.
Comment 11 commit-hook freebsd_committer 2014-06-23 17:20:22 UTC
A commit references this bug:

Author: rakuco
Date: Mon Jun 23 17:20:09 UTC 2014
New revision: 358976
URL: http://svnweb.freebsd.org/changeset/ports/358976

Log:
  - Use the more standard DOCS option instead of HTMLDOCS.
  - Set PYTHON_CONCURRENT_INSTALL and do not manually set DOCSDIR so that
    multiple versions can be installed concurrently.

  PR:		191267
  Submitted by:	rakuco
  Approved by:	koobs (the actual maintainer :-)

Changes:
  head/databases/py-redis/Makefile
Comment 12 Raphael Kubo da Costa freebsd_committer 2014-06-23 17:21:01 UTC
Committed after an ack from koobs in http://permalink.gmane.org/gmane.os.freebsd.devel.cvs.ports/310248