Bug 191276 - [maintainer-update] net/rtg: update to use mysqli and fix some dependancies
Summary: [maintainer-update] net/rtg: update to use mysqli and fix some dependancies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-22 15:30 UTC by Daniel Austin
Modified: 2014-06-22 19:04 UTC (History)
1 user (show)

See Also:


Attachments
20140622-rtg.diff (12.95 KB, patch)
2014-06-22 15:30 UTC, Daniel Austin
no flags Details | Diff
revised patch (v2) (13.01 KB, patch)
2014-06-22 18:57 UTC, Daniel Austin
freebsd-ports: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Austin 2014-06-22 15:30:58 UTC
Created attachment 144029 [details]
20140622-rtg.diff

Update to use PHP mysqli extensions (as mysql extension is deprecated these days)
	Fix runtime dependancies to pull in perl's DBI and DBD::mysql modules for target maker.
	Add some options to pull in dependancies for mysql server and php web modules if needed.

Fix:
Added files:
  files/patch-etc-95.php

Modified files:
  Makefile
  files/patch-etc-rtg.php
  files/patch-etc-view.php
Comment 1 Daniel Austin 2014-06-22 15:31:37 UTC
Tested with poudriere, logs at http://poudriere.dan.tm/latest-per-pkg/rtg/0.7.4_11/
Comment 2 Raphael Kubo da Costa freebsd_committer 2014-06-22 18:37:53 UTC
Hi. Building with the MYSQL option set fails here, you're likely missing some build dependency:

configure: error: Cannot find MySQL header files under /usr/local
===>  Script "configure" failed unexpectedly.
Comment 3 Daniel Austin 2014-06-22 18:57:09 UTC
Created attachment 144037 [details]
revised patch (v2)

fixed the mysql dependancy
Comment 4 Daniel Austin 2014-06-22 18:57:48 UTC
Thanks for that - i've replaced the patch with a new diff that sorts it with both options on and off.
(different USE_MYSQL options!)
Comment 5 commit-hook freebsd_committer 2014-06-22 19:04:11 UTC
A commit references this bug:

Author: rakuco
Date: Sun Jun 22 19:03:48 UTC 2014
New revision: 358821
URL: http://svnweb.freebsd.org/changeset/ports/358821

Log:
  - Update to use PHP mysqli extensions (as mysql extension is deprecated
    these days)
  - Fix runtime dependencies to pull in perl's DBI and DBD::mysql modules for
    target maker.
  - Add some options to pull in dependencies for mysql server and php web
    modules if needed.

  PR:		191276
  Submitted by:	 Daniel Austin <freebsd-ports@dan.me.uk> (maintainer)

Changes:
  head/net/rtg/Makefile
  head/net/rtg/files/patch-etc-95.php
  head/net/rtg/files/patch-etc-rtg.php
  head/net/rtg/files/patch-etc-view.php
Comment 6 Raphael Kubo da Costa freebsd_committer 2014-06-22 19:04:33 UTC
Committed, thanks!