Created attachment 144035 [details] add-3.6.2.patch Django-redis is a BSD Licensed, full featured Redis cache/session backend for Django. Why use django-redis? - In active development. - Modular client system (pluggable clients). - Master-Slave support in the default client. - Complete battery of tests. - Used in production in several projects as cache and session storage. - Supports infinite timeouts. - Python 3 support in same code base. - Facilities for raw access to Redis client/connection pool. - Highly configurable (can emulate memcached exception behavior, for example). - Unix sockets supported by default. - Pluggable parsers. WWW: http://niwibe.github.io/django-redis/ Fix: Buildarchive: https://redports.org/buildarchive/20140622174401-80741/
I'll take it, review pending
Great submission Melvyn, especially the included change to www/Makefile and including redports logs. Review: - Include portlint output (For either pass or fail) - RUN_DEPENDS=, not +=, for the initial assignment, += for later assignments or conditional dependencies. - Use Django pkgname (with respective versions) matching, rather than file for py-django dependency check - Remove 'In active development' from pkg-descr, not a feature & information could become stale - Tab align USE_PYTHON value - Add regression-test target (regression-test: build) - Add test dependencies to TEST_DEPENDS Bonus: - Add TESTS option - Add TEST_DEPENDS to BUILD_DEPENDS when TESTS option is set - Test suite passes (add output to bug comment) - Create PR/Issue upstream to add `python setup.py test` integration
Please attach a second version of your changes addressing those items
Will work on that tonight.
(In reply to Kubilay Kocak from comment #2) > Great submission Melvyn, especially the included change to www/Makefile and > including redports logs. Thank you. > - Use Django pkgname (with respective versions) matching, rather than > file for py-django dependency check I copied this from www/django-mezzanine which is part of this effort. I'm setting up a new project with mezzanine and redis caching, but the mezzanine port is quite outdated. Since you also maintain that, are you already working to upgrade it? I've built 80% of a mezzanine 3.1.2 port, cause I need it short-term, but if you're already working on that, I can hold off on those submissions to bugzilla (2 new ports needed: tzlocal and requests-oauth). > - Remove 'In active development' from pkg-descr, not a feature & > information could become stale Gotha. > - Create PR/Issue upstream to add `python setup.py test` integration I'll have to read up on that, but going for the bonus points.
Ack, looks like I copied this from django-annoying. Here's list of ports that do it this way: www/py-django-annoying/Makefile www/py-django-app-plugins/Makefile www/py-django-appmedia/Makefile www/py-django-caching-app-plugins/Makefile www/py-django-classy-tags/Makefile www/py-django-json-rpc/Makefile www/py-django-keyedcache/Makefile www/py-django-photologue/Makefile www/py-django-piston/Makefile www/py-django-profiles/Makefile www/py-django-signals-ahoy/Makefile www/py-django-tables2/Makefile www/py-django-tagging/Makefile www/py-django-threaded-multihost/Makefile www/py-django-tinymce/Makefile
Testing can't be done, they're not packaged: https://github.com/niwibe/django-redis/blob/master/MANIFEST.in Additionally, they'd require a working redis server, which is a blocker and a settings file within a django project that points to it. These are made to run on an already setup project to detect issues in the stack.
Created attachment 144080 [details] Add py-django-redis-3.6.2 Portlint: looks fine Redports: https://redports.org/buildarchive/20140623202801-37364/ Full changelog: changeset: 358594:d07f0e892b4b branch: ports-mrs user: Melvyn Sopacua <melvyn@magemana.nl> date: Sun Jun 22 12:28:37 2014 +0200 files: www/Makefile www/py-django-redis/Makefile www/py-django-redis/distinfo www/py-django-redis/pkg-descr description: Add redis support for Django. changeset: 358595:b5e3d6ae3271 branch: ports-mrs user: Melvyn Sopacua <melvyn@magemana.nl> date: Sun Jun 22 17:56:13 2014 +0200 files: www/py-django-redis/Makefile description: Prefix already adds the trailing dash changeset: 358601:9f68cb219499 branch: ports-mrs user: Melvyn Sopacua <melvyn@magemana.nl> date: Mon Jun 23 21:30:03 2014 +0200 files: www/py-django-redis/pkg-descr description: Remove some lines from the pkg-descr: 1) active development is a good intention (koobs@) 2) since tests aren't packaged to PyPI, don't mention them. changeset: 358602:db6d10880682 branch: ports-mrs user: Melvyn Sopacua <melvyn@magemana.nl> date: Mon Jun 23 21:37:58 2014 +0200 files: www/py-django-redis/Makefile description: Fixes suggested by koobs@: - use django version instead of file detection - tab-align USE_PYTHON with values below (8 for ts) changeset: 358603:6dcfa7fa1df4 branch: ports-mrs tag: tip user: Melvyn Sopacua <melvyn@magemana.nl> date: Mon Jun 23 22:21:25 2014 +0200 files: www/py-django-redis/Makefile www/py-django-redis/pkg-descr description: Pet portlint: - Wrap at 72 chars (portlint says 80 but I prefer mail width) - Remove trailing dot in COMMENT
A commit references this bug: Author: koobs Date: Fri Jun 27 09:13:29 UTC 2014 New revision: 359482 URL: http://svnweb.freebsd.org/changeset/ports/359482 Log: [NEW] www/py-django-redis: Full featured Redis cache/session backend for Django Django-redis is a BSD Licensed, full featured Redis cache/session backend for Django. Why use django-redis? * Modular client system (pluggable clients). * Master-Slave support in the default client. * Used in production in several projects as cache and session storage. * Supports infinite timeouts. * Python 3 support in same code base. * Facilities for raw access to Redis client/connection pool. * Highly configurable (can emulate memcached exception behavior, for example). * Unix sockets supported by default. * Pluggable parsers. WWW: http://niwibe.github.io/django-redis PR: 191281 Submitted by: melvyn at magemana dot nl (with minor changes) Changes: head/www/Makefile head/www/py-django-redis/ head/www/py-django-redis/Makefile head/www/py-django-redis/distinfo head/www/py-django-redis/pkg-descr
Great job Melvyn! Committed with minor changes.