Bug 191356 - [patch] security/heimdal consistent byte order for seed data with base system heimdal
Summary: [patch] security/heimdal consistent byte order for seed data with base system...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-25 06:23 UTC by dewayne
Modified: 2014-07-27 18:16 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dewayne 2014-06-25 06:23:56 UTC 
This patch enables heimdal port and heimdal base to be consistent and talk nicely to each other.  Please refer to errata notice "FreeBSD Errata Notice FreeBSD-EN-14:08.heimdal"

(Note: spaces are substituted for tabs below, tabs should be reinserted before _gsskrb5...)

Suggest to add security/heimdal/files/patch-lib__ggapi__krb5__prf.c
@@ -119,7 +119,7 @@
     while(dol > 0) {
        size_t tsize;

-       _gsskrb5_encode_om_uint32(num, input.data);
+       _gsskrb5_encode_be_om_uint32(num, input.data);

        ret = krb5_crypto_prf(context, crypto, &input, &output);
        if (ret) {
Comment 1 dewayne 2014-06-25 06:25:33 UTC 
Apologies I missed cut/pasting the top lines:

--- lib/gssapi/krb5/prf.c.orig    2014-06-25 15:30:54.000000000 +1000
+++ lib/gssapi/krb5/prf.c 2014-06-25 15:31:45.000000000 +1000
@@ -119,7 +119,7 @@
     while(dol > 0) {
        size_t tsize;

-       _gsskrb5_encode_om_uint32(num, input.data);
+       _gsskrb5_encode_be_om_uint32(num, input.data);

        ret = krb5_crypto_prf(context, crypto, &input, &output);
Comment 2 John Marino freebsd_committer freebsd_triage 2014-07-26 07:16:39 UTC 
dewayne, fyi - posting the patch as an attachment is preferred 100 times more than posting a patch as a comment based on the committer's workflow.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-07-27 18:15:25 UTC 
A commit references this bug:

Author: marino
Date: Sun Jul 27 18:14:32 UTC 2014
New revision: 363088
URL: http://svnweb.freebsd.org/changeset/ports/363088

Log:
  security/heimdal: Establish consistency for seed data with base heimdal

  This patch enables heimdal port and heimdal bad to be consistent [in byte
  order for seed data] and talk nicely to each other.  Please refer to
  FreeBSD Errata Notice FreeBSD-EN-14:08.heimdal.  This port is not
  unmaintained.

  PR:		191356
  Submitted by:	dewayne (heuristicsystems.com.au)

Changes:
  head/security/heimdal/Makefile
  head/security/heimdal/files/patch-lib_gssapi_krb5_prf.c
Comment 4 John Marino freebsd_committer freebsd_triage 2014-07-27 18:16:08 UTC 
Thanks!