Bug 191387 - www/py-django_compressor: Update to to 1.4
Summary: www/py-django_compressor: Update to to 1.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords: easy, patch, patch-ready
Depends on: 191386
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-26 06:09 UTC by Melvyn Sopacua
Modified: 2014-12-31 06:42 UTC (History)
2 users (show)

See Also:


Attachments
update-py-django_compressor-1.4.patch (2.05 KB, patch)
2014-06-26 06:09 UTC, Melvyn Sopacua
no flags Details | Diff
Depend on BeautifulSoup 4.x (1.93 KB, patch)
2014-06-29 20:15 UTC, Melvyn Sopacua
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Melvyn Sopacua 2014-06-26 06:09:19 UTC
Created attachment 144138 [details]
update-py-django_compressor-1.4.patch

Update to 1.4: 

- Warn about BeautifulSoup only working on Python 2.x
- Add py-slimit option
- Change dependency check for beatifulsoup to pkg version mechanics

Fix:
Redports: https://redports.org/buildarchive/20140625071100-18626/
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-06-26 07:27:29 UTC
www/py-beautifulsoup32 currently allows installation under Python 3.x.

I read that BeautifulSoup 4.x officially supports Python 3.x

If the above is correct, shouldn't the www/beautifulsoup32 port be modified (limited to -2.7), and then this port modified to use beautifulsoup4 if the Python version in use is 3.x?

The django_compressor docs dont *explicitly* state BeautifulSoup 4.x support, but apparently it does. See: 

https://github.com/django-compressor/django-compressor/issues/532

While I'm here:

* CC maintainer and wg@ (beautifulsoup maintainer)
* Assign to me
Comment 2 William Grzybowski freebsd_committer freebsd_triage 2014-06-26 15:16:22 UTC
I am only the maintainer of beautifulsoup 4, not 3.2. I don't think there is anything for me here ;)
Comment 3 Melvyn Sopacua 2014-06-26 19:44:41 UTC
http://django-compressor.readthedocs.org/en/latest/quickstart/#dependencies:

pip install "BeautifulSoup<4.0"

===>   Returning to build of py33-beautifulsoup32-3.2.1
===>   py33-beautifulsoup32-3.2.1 depends on file: /usr/local/bin/python3.3 - found
===>  Configuring for py33-beautifulsoup32-3.2.1
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "setup.py", line 22
    print "Unit tests have failed!"
                                  ^
SyntaxError: invalid syntax
*** [do-configure] Error code 1

Stop in /usr/ports/www/py-beautifulsoup32.

(print() is a function not a statement in python 3.x)
Comment 4 Melvyn Sopacua 2014-06-27 05:32:21 UTC
There's also this:
https://github.com/django-compressor/django-compressor/issues/531

In short: I agree that we should switch to beautifulsoup 4.x. Will come with new patch.
Comment 5 Melvyn Sopacua 2014-06-29 20:15:00 UTC
Created attachment 144268 [details]
Depend on BeautifulSoup 4.x

changeset:   359581:c1e883a5f682
branch:      ports-mrs
tag:         tip
user:        Melvyn Sopacua <melvyn@magemana.nl>
date:        Sun Jun 29 22:04:32 2014 +0200
files:       www/py-django_compressor/Makefile
description:
Depend on BeatifulSoup 4.x

- Update dependency
- Remove python 2 warning


changeset:   358607:f12f8d7bd545
branch:      ports-mrs
user:        Melvyn Sopacua <melvyn@magemana.nl>
date:        Wed Jun 25 09:09:42 2014 +0200
files:       www/py-django_compressor/Makefile www/py-django_compressor/distinfo
description:
Update to 1.4:

- Warn about BeautifulSoup only working on Python 2.x
- Add py-slimit option
Comment 6 Melvyn Sopacua 2014-06-29 20:29:10 UTC
Redports: https://redports.org/buildarchive/20140629194000-40164/

This port is impossible to test for me. It's not setup to be run in a django project and currently lack the resources (time, baremetal FreeBSD) to fiddle with virtualenv. I did file a report:

https://github.com/django-compressor/django-compressor/issues/534
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2014-08-30 03:10:04 UTC
Request maintainer approval
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-31 06:26:36 UTC
Comment on attachment 144268 [details]
Depend on BeautifulSoup 4.x

Maintainer timeout
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-12-31 06:41:29 UTC
A commit references this bug:

Author: koobs
Date: Wed Dec 31 06:41:05 UTC 2014
New revision: 375871
URL: https://svnweb.freebsd.org/changeset/ports/375871

Log:
  www/py-django_compressor: Update to 1.4

  - Update to 1.4
  - Update Python bits to USES / USE_PYTHON
  - Extend Python compatibility to 3.x
  - Add SLIMIT option
  - Switch BeautifulSoup dependency to 4.x
  - Update pkg-desc

  PR:		191387
  Submitted by:	Melvyn Sopacua <melvyn magemana nl>
  Approved by:	maintainer timeout (4 months)

Changes:
  head/www/py-django_compressor/Makefile
  head/www/py-django_compressor/distinfo
  head/www/py-django_compressor/pkg-descr
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-31 06:42:31 UTC
Committed, thanks Melvyn! Apologies for the delay.